3rdparty/stout#26 reports how pre-existing code format warnings block merging PRs that only touch unrelated files.
Can/should we change the check-code-style check to only complain about issues in files included in the PR to avoid unnecessary blocks?
I think it's totally valid to reject this suggestion, and instead we could declare that we should fix warnings at HEAD before submitting new work in order to keep head clean. (But if that's our stance, we should clean HEAD before turning on this check in any repos!)
3rdparty/stout#26 reports how pre-existing code format warnings block merging PRs that only touch unrelated files.
Can/should we change the
check-code-stylecheck to only complain about issues in files included in the PR to avoid unnecessary blocks?I think it's totally valid to reject this suggestion, and instead we could declare that we should fix warnings at HEAD before submitting new work in order to keep head clean. (But if that's our stance, we should clean HEAD before turning on this check in any repos!)