Skip to content

Commit df5c671

Browse files
authored
[Common] Improve Common PCH (#18306)
1 parent d2eec1a commit df5c671

1 file changed

Lines changed: 10 additions & 0 deletions

File tree

‎Common/Core/CMakeLists.txt‎

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -51,13 +51,23 @@ if(NOT DEFINED ENV{USE_RECC})
5151
<Framework/AnalysisTask.h>
5252
<Framework/ConfigContext.h>
5353
<Framework/DataProcessorSpec.h>
54+
# Measured over all 1463 workflow translation units in the tree: these are
55+
# the framework headers a large majority include and that were not
56+
# precompiled here. Percentages are of those 1463.
57+
<Framework/Configurable.h> # 78%
58+
<Framework/InitContext.h> # 78%
59+
<Framework/AnalysisDataModel.h> # 76%
60+
<Framework/HistogramRegistry.h> # 70%
61+
<Framework/AnalysisHelpers.h> # 69%
62+
<Framework/HistogramSpec.h> # 67%
5463
# NOT runDataProcessing.h. It states the contract itself: "we need to
5564
# declare the customize method before include this file". Precompiling it
5665
# makes it the first include in every workflow, so a source's customize() is
5766
# never seen, its options are never registered, and the binary aborts at
5867
# --dump-workflow with "missing option: ...". The link succeeds, so this
5968
# surfaces as a runtime failure with no hint that a PCH caused it.
6069

70+
<cstdint> # 51%
6171
<memory>
6272
<string>
6373
<vector>

0 commit comments

Comments
 (0)