Skip to content

Commit 78df46f

Browse files
authored
Revise PR merging policy for linter checks
Updated policy regarding linter and code-checker issues in PRs.
1 parent b6cc96c commit 78df46f

1 file changed

Lines changed: 4 additions & 1 deletion

File tree

‎docs/gettingstarted/contributingtocode.md‎

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,10 @@ The CI checks evaluate:
100100
- Labeler: Assigns [labels](https://github.com/AliceO2Group/O2Physics/labels) to the PR based on which parts of the code base were modified.
101101
- Title prefix checker: Verifies that the title of the PR has a valid prefix with tags corresponding to the labels. If a valid prefix is not found, it is created.
102102

103-
__In general, a PR should not be merged if it does not pass all checks, unless there are good reasons to ignore the errors and warnings.__
103+
__Policy when dealing with linter / code-checker__
104+
- It is agreed that the issues brought up by linter and code-checker tools should be fixed on a best-effort basis.
105+
- However, for the purposes of merging, the linter checks are not mandatory.
106+
- The final decision on merging PRs is taken by the code owners.
104107

105108
Checks flagged as "Required" must succeed before a PR can be merged.
106109

0 commit comments

Comments
 (0)