refactor(db_goals): 拆里程碑域至 db_goals_milestone.rs

Author: Aparencia

app/src-tauri/src/db_goals.rs

@@ -13,9 +13,15 @@ use rusqlite::{params, Connection};
 use crate::db::{unix_seconds, Db};
 use crate::error::Result;
 use crate::goal_schema::{
-    Goal, GoalMilestone, NewGoal, NewMilestone, CRITERIA_GROUP_SETTLED, MILESTONE_DONE,
+    Goal, NewGoal, NewMilestone, CRITERIA_GROUP_SETTLED, MILESTONE_DONE,
     MILESTONE_IN_PROGRESS, MILESTONE_PENDING,
 };
+use self::milestone::add_milestone_row;
+
+// 子模块声明（AGENTS.md §3 单文件 ≤300 行；#[path] 使兄弟文件平铺在同目录，各自带 @ai-context）。
+/// 里程碑域：里程碑 CRUD + 三写路径共用的插入行 helper。
+#[path = "db_goals_milestone.rs"]
+mod milestone;
 
 /// 三表 DDL + 索引（幂等：CREATE TABLE IF NOT EXISTS；旧库升级自动补表）。
 pub(crate) fn init(conn: &Connection) -> Result<()> {
@@ -177,96 +183,6 @@ impl Db {
         })
     }
 
-    /// 目标里程碑清单（order_idx 升序——计划顺序即创建语义）。
-    pub fn list_milestones(&self, goal_id: i64) -> Result<Vec<GoalMilestone>> {
-        self.with_conn(|conn| {
-            let mut stmt = conn.prepare(
-                "SELECT * FROM goal_milestones WHERE goal_id = ?1 ORDER BY order_idx ASC, id ASC",
-            )?;
-            let rows = stmt.query_map(params![goal_id], row_to_milestone)?;
-            rows.collect::<rusqlite::Result<Vec<_>>>().map_err(Into::into)
-        })
-    }
-
-    /// 新增里程碑（order_idx ≤0 时自动追加在末尾；criteria_type 白名单在命令层）。
-    pub fn add_milestone(&self, goal_id: i64, new: &NewMilestone) -> Result<GoalMilestone> {
-        let now = unix_seconds();
-        self.with_conn(|conn| {
-            let idx = conn.query_row(
-                "SELECT COALESCE(MAX(order_idx), -1) + 1 FROM goal_milestones WHERE goal_id = ?1",
-                params![goal_id],
-                |r| r.get::<_, i64>(0),
-            )?;
-            let order = if new.order_idx > 0 { new.order_idx } else { idx };
-            conn.execute(
-                "INSERT INTO goal_milestones (goal_id, title, due_at, order_idx, status, criteria_type, ref_group_id, created_at)
-                 VALUES (?1, ?2, ?3, ?4, 'pending', ?5, ?6, ?7)",
-                params![
-                    goal_id, new.title, new.due_at, order, new.criteria_type,
-                    new.ref_group_id, now
-                ],
-            )?;
-            Ok(GoalMilestone {
-                id: conn.last_insert_rowid(),
-                goal_id,
-                title: new.title.clone(),
-                due_at: new.due_at,
-                order_idx: order,
-                status: MILESTONE_PENDING.to_string(),
-                criteria_type: new.criteria_type.clone(),
-                ref_group_id: new.ref_group_id,
-                completed_at: None,
-                created_at: now,
-            })
-        })
-    }
-
-    /// 更新里程碑（整段覆盖：标题/期限；顺序不在此改——增删即重排语义）。
-    pub fn update_milestone(&self, id: i64, title: &str, due_at: Option<i64>) -> Result<bool> {
-        self.with_conn(|conn| {
-            let affected = conn.execute(
-                "UPDATE goal_milestones SET title = ?2, due_at = ?3 WHERE id = ?1",
-                params![id, title, due_at],
-            )?;
-            Ok(affected > 0)
-        })
-    }
-
-    /// 按 id 读取里程碑（旧状态读取——状态流转前判据，不存在 → None）。
-    pub fn get_milestone(&self, id: i64) -> Result<Option<GoalMilestone>> {
-        self.with_conn(|conn| {
-            let mut stmt = conn.prepare("SELECT * FROM goal_milestones WHERE id = ?1")?;
-            let mut rows = stmt.query_map(params![id], row_to_milestone)?;
-            match rows.next() {
-                Some(Ok(m)) => Ok(Some(m)),
-                Some(Err(e)) => Err(e.into()),
-                None => Ok(None),
-            }
-        })
-    }
-
-    /// 删除里程碑（不存在 → false）。
-    pub fn delete_milestone(&self, id: i64) -> Result<bool> {
-        self.with_conn(|conn| {
-            let affected = conn.execute("DELETE FROM goal_milestones WHERE id = ?1", params![id])?;
-            Ok(affected > 0)
-        })
-    }
-
-    /// 里程碑状态流转（done 写 completed_at；非完成态清空——状态机白名单在命令层）。
-    pub fn set_milestone_status(&self, id: i64, status: &str) -> Result<bool> {
-        let now = unix_seconds();
-        self.with_conn(|conn| {
-            let affected = conn.execute(
-                "UPDATE goal_milestones SET status = ?2,
-                 completed_at = CASE WHEN ?3 THEN ?4 ELSE NULL END
-                 WHERE id = ?1",
-                params![id, status, status == MILESTONE_DONE, now],
-            )?;
-            Ok(affected > 0)
-        })
-    }
-
     /// 绑定组到目标（UNIQUE 幂等：重复绑定返回 false；组不存在靠外键报错，
     /// 命令层先行校验）。
     pub fn bind_group(&self, goal_id: i64, group_id: i64) -> Result<bool> {
@@ -654,22 +570,6 @@ impl Db {
     }
 }
 
-/// 里程碑插入行（create_goal 事务与 add_milestone 共用；criteria_type 默认 manual）。
-fn add_milestone_row(
-    conn: &Connection,
-    goal_id: i64,
-    m: &NewMilestone,
-    order_idx: i64,
-    now: i64,
-) -> Result<()> {
-    conn.execute(
-        "INSERT INTO goal_milestones (goal_id, title, due_at, order_idx, status, criteria_type, ref_group_id, created_at)
-         VALUES (?1, ?2, ?3, ?4, 'pending', ?5, ?6, ?7)",
-        params![goal_id, m.title, m.due_at, order_idx, m.criteria_type, m.ref_group_id, now],
-    )?;
-    Ok(())
-}
-
 /// goals 行 → Goal。
 fn row_to_goal(row: &rusqlite::Row<'_>) -> rusqlite::Result<Goal> {
     Ok(Goal {
@@ -686,22 +586,6 @@ fn row_to_goal(row: &rusqlite::Row<'_>) -> rusqlite::Result<Goal> {
     })
 }
 
-/// goal_milestones 行 → GoalMilestone。
-fn row_to_milestone(row: &rusqlite::Row<'_>) -> rusqlite::Result<GoalMilestone> {
-    Ok(GoalMilestone {
-        id: row.get(0)?,
-        goal_id: row.get(1)?,
-        title: row.get(2)?,
-        due_at: row.get(3)?,
-        order_idx: row.get(4)?,
-        status: row.get(5)?,
-        criteria_type: row.get(6)?,
-        ref_group_id: row.get(7)?,
-        completed_at: row.get(8)?,
-        created_at: row.get(9)?,
-    })
-}
-
 #[cfg(test)]
 #[path = "db_goals_tests.rs"]
 mod tests;

app/src-tauri/src/db_goals_milestone.rs

@@ -0,0 +1,141 @@
+//! 里程碑域：`goal_milestones` 实体 CRUD + 里程碑插入行 helper + 行映射。
+//!
+//! @ai-context: 由 db_goals.rs 按域拆出（AGENTS.md §3 单文件 ≤300 行）；主文件
+//!              db_goals.rs 只留模块文档 + schema init + 子模块声明 + 测试接线。
+//! @ai-context: `add_milestone_row` 是 goal_milestones **三条插入路径中两条**的
+//!              共用实现——建目标事务在 db_goals_goal.rs（create_goal）、AI 规划
+//!              事务在 db_goals_plan.rs（apply_plan_core）；第三条 add_milestone
+//!              内联 INSERT 保持原样。**只此一份，禁止在别处复制**。
+//! @ai-context: 副作用/边界：方法都走 Db::with_conn 单锁（std::sync::Mutex
+//!              **不可重入**）；调用方若已持锁（事务闭包内）只能调
+//!              `add_milestone_row(&Connection, …)`，不得再进 self.*。
+
+use rusqlite::{params, Connection};
+
+use crate::db::{unix_seconds, Db};
+use crate::error::Result;
+use crate::goal_schema::{GoalMilestone, NewMilestone, MILESTONE_DONE, MILESTONE_PENDING};
+
+impl Db {
+    /// 目标里程碑清单（order_idx 升序——计划顺序即创建语义）。
+    pub fn list_milestones(&self, goal_id: i64) -> Result<Vec<GoalMilestone>> {
+        self.with_conn(|conn| {
+            let mut stmt = conn.prepare(
+                "SELECT * FROM goal_milestones WHERE goal_id = ?1 ORDER BY order_idx ASC, id ASC",
+            )?;
+            let rows = stmt.query_map(params![goal_id], row_to_milestone)?;
+            rows.collect::<rusqlite::Result<Vec<_>>>().map_err(Into::into)
+        })
+    }
+
+    /// 新增里程碑（order_idx ≤0 时自动追加在末尾；criteria_type 白名单在命令层）。
+    pub fn add_milestone(&self, goal_id: i64, new: &NewMilestone) -> Result<GoalMilestone> {
+        let now = unix_seconds();
+        self.with_conn(|conn| {
+            let idx = conn.query_row(
+                "SELECT COALESCE(MAX(order_idx), -1) + 1 FROM goal_milestones WHERE goal_id = ?1",
+                params![goal_id],
+                |r| r.get::<_, i64>(0),
+            )?;
+            let order = if new.order_idx > 0 { new.order_idx } else { idx };
+            conn.execute(
+                "INSERT INTO goal_milestones (goal_id, title, due_at, order_idx, status, criteria_type, ref_group_id, created_at)
+                 VALUES (?1, ?2, ?3, ?4, 'pending', ?5, ?6, ?7)",
+                params![
+                    goal_id, new.title, new.due_at, order, new.criteria_type,
+                    new.ref_group_id, now
+                ],
+            )?;
+            Ok(GoalMilestone {
+                id: conn.last_insert_rowid(),
+                goal_id,
+                title: new.title.clone(),
+                due_at: new.due_at,
+                order_idx: order,
+                status: MILESTONE_PENDING.to_string(),
+                criteria_type: new.criteria_type.clone(),
+                ref_group_id: new.ref_group_id,
+                completed_at: None,
+                created_at: now,
+            })
+        })
+    }
+
+    /// 更新里程碑（整段覆盖：标题/期限；顺序不在此改——增删即重排语义）。
+    pub fn update_milestone(&self, id: i64, title: &str, due_at: Option<i64>) -> Result<bool> {
+        self.with_conn(|conn| {
+            let affected = conn.execute(
+                "UPDATE goal_milestones SET title = ?2, due_at = ?3 WHERE id = ?1",
+                params![id, title, due_at],
+            )?;
+            Ok(affected > 0)
+        })
+    }
+
+    /// 按 id 读取里程碑（旧状态读取——状态流转前判据，不存在 → None）。
+    pub fn get_milestone(&self, id: i64) -> Result<Option<GoalMilestone>> {
+        self.with_conn(|conn| {
+            let mut stmt = conn.prepare("SELECT * FROM goal_milestones WHERE id = ?1")?;
+            let mut rows = stmt.query_map(params![id], row_to_milestone)?;
+            match rows.next() {
+                Some(Ok(m)) => Ok(Some(m)),
+                Some(Err(e)) => Err(e.into()),
+                None => Ok(None),
+            }
+        })
+    }
+
+    /// 删除里程碑（不存在 → false）。
+    pub fn delete_milestone(&self, id: i64) -> Result<bool> {
+        self.with_conn(|conn| {
+            let affected = conn.execute("DELETE FROM goal_milestones WHERE id = ?1", params![id])?;
+            Ok(affected > 0)
+        })
+    }
+
+    /// 里程碑状态流转（done 写 completed_at；非完成态清空——状态机白名单在命令层）。
+    pub fn set_milestone_status(&self, id: i64, status: &str) -> Result<bool> {
+        let now = unix_seconds();
+        self.with_conn(|conn| {
+            let affected = conn.execute(
+                "UPDATE goal_milestones SET status = ?2,
+                 completed_at = CASE WHEN ?3 THEN ?4 ELSE NULL END
+                 WHERE id = ?1",
+                params![id, status, status == MILESTONE_DONE, now],
+            )?;
+            Ok(affected > 0)
+        })
+    }
+}
+
+/// 里程碑插入行（create_goal 事务与 add_milestone 共用；criteria_type 默认 manual）。
+pub(super) fn add_milestone_row(
+    conn: &Connection,
+    goal_id: i64,
+    m: &NewMilestone,
+    order_idx: i64,
+    now: i64,
+) -> Result<()> {
+    conn.execute(
+        "INSERT INTO goal_milestones (goal_id, title, due_at, order_idx, status, criteria_type, ref_group_id, created_at)
+         VALUES (?1, ?2, ?3, ?4, 'pending', ?5, ?6, ?7)",
+        params![goal_id, m.title, m.due_at, order_idx, m.criteria_type, m.ref_group_id, now],
+    )?;
+    Ok(())
+}
+
+/// goal_milestones 行 → GoalMilestone。
+fn row_to_milestone(row: &rusqlite::Row<'_>) -> rusqlite::Result<GoalMilestone> {
+    Ok(GoalMilestone {
+        id: row.get(0)?,
+        goal_id: row.get(1)?,
+        title: row.get(2)?,
+        due_at: row.get(3)?,
+        order_idx: row.get(4)?,
+        status: row.get(5)?,
+        criteria_type: row.get(6)?,
+        ref_group_id: row.get(7)?,
+        completed_at: row.get(8)?,
+        created_at: row.get(9)?,
+    })
+}

docs/standards/line-limit-exemptions.md

@@ -103,7 +103,7 @@
 | app/src/pages/SessionsPage.tsx | 352 | 本层为状态宿主与数据编排：会话列表/详情状态、事件驱动刷新（自动摘取，待细化） | 若再增长：按职责拆分 |
 | app/src/components/NoteLinkToSystem.tsx | 351 | v0.19.7（REQ-286）重构：挂体系选择器（体系下拉 + 三 tab + LinkEntityPicker 搜索树列表 + 三类内联轻建编排 + 既有反查/撤链/钳制语义保持）——实体选择/创建交互已下沉 LinkEntityPicker.tsx（134 行），本文件保留编排与数据装载内聚 | 若再增长：树行构建（flattenNodeRows）与实体装载拆至 useSystemEntities.ts hook |
 | app/src-tauri/src/commands_ai_settings.rs | 349 | AI 设置命令域（视图/密钥/授权/目标 AI） + v0.19.1 ai_set_kb_qa 最小面命令（+28）——read-modify-write 同域先例（ai_set_goal_plan）内聚 | 若再增长：kb/goal 最小面命令拆至 commands_ai_settings_extra.rs |
-| app/src-tauri/src/commands_goals.rs | 344 | 超硬限（>600 行），不允许豁免 —— v0.18.0（REQ-248~250）：学习目标命令域（15 命令 + inner 纯编排 + 访谈校验/埋点/宣言组装/进度收集）——命令薄壳与 inner 同域（commands_knowledge_core 先例）；列表/详情/进度三视图共用 collect_signals/goal_card_metrics；v0.18.1 生命周期命令已拆至 commands_goals_lifecycle.rs | 若再增长：里程碑命令组拆至 commands_goals_milestones.rs |
+| app/src-tauri/src/commands_goals.rs | 344 | v0.18.0（REQ-248~250）学习目标命令域——批 0-C3 Task 6 分 3 步拆出 `commands_goals_views.rs`（读侧视图）/ `commands_goals_milestones.rs`（里程碑+绑组写入域）/ `commands_goals_intent.rs`（访谈输入契约）三个平铺子模块，`#[path]` 由父模块自己声明 ⇒ `lib.rs` 零改动；本文件保留目标生命周期核心（5 条命令 + 5 个 inner）+ 跨模块 seam（`require_goal`/`collect_signals`/`parse_criteria`，故 `commands_goals_lifecycle.rs`/`commands_goals_plan.rs` 零改动）+ `goal_created` 埋点与访谈组装；11 处 `emit_changed(DataDomain::Goals)` 中 5 处留本文件、6 处随里程碑/绑组命令迁出；15 条 IPC 名逐字不变（注册路径两段→三段共 10 条，已在 `app_commands.rs` 同批改写） | 若再增长：目标 CRUD 核心之外的共享 seam（`require_goal`/`collect_signals`/`parse_criteria`，18 行）可拆至 `commands_goals_seam.rs`（内容地板 ≈213 行） |
 | app/src-tauri/src/structure_models.rs | 343 | v0.5.0 模型版：模型清单/独立状态机下载器（进度事件/.part 原子写/按需启用三分类）+ 磁盘就绪判定（disk_done）内聚 | 若再增长：download_one 拆至 structure_download.rs |
 | app/src-tauri/src/db_ai_tasks.rs | 340 | 任务注册表在 AppState 内存（HashMap）——重启即失、未采纳（自动摘取，待细化） | 若再增长：按职责拆分 |
 | app/src-tauri/src/screen_merge_tests.rs | 339 | 屏级聚合/净化纯函数测试域（聚类/行合并/零跨度/图去重回归）单模块 #[path] 挂载 | 若再增长：净化组拆至 screen_merge_purify_tests.rs |