From 83c8735131c1de1406ab26fee6249f71598e1e9c Mon Sep 17 00:00:00 2001 From: Jinming Hu Date: Fri, 6 Nov 2026 12:19:33 +1100 Subject: [PATCH 1/2] Skip API review validation for C++ partner-feed releases Guard only the API-review steps at runtime when PublishToVcpkgPartnerFeed=true, preserving existing conditions for normal releases and all other validation. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --- .../templates/jobs/archetype-sdk-client.yml | 11 +++++++---- .../templates/steps/partner-feed-api-review.yml | 14 ++++++++++++++ 2 files changed, 21 insertions(+), 4 deletions(-) create mode 100644 eng/pipelines/templates/steps/partner-feed-api-review.yml diff --git a/eng/pipelines/templates/jobs/archetype-sdk-client.yml b/eng/pipelines/templates/jobs/archetype-sdk-client.yml index d465deccd9..88a60a4276 100644 --- a/eng/pipelines/templates/jobs/archetype-sdk-client.yml +++ b/eng/pipelines/templates/jobs/archetype-sdk-client.yml @@ -323,11 +323,14 @@ jobs: ArtifactPath: $(Build.ArtifactStagingDirectory)/PackageInfo ArtifactName: PackageInfo - - template: /eng/common/pipelines/templates/steps/create-apireview.yml + - template: /eng/pipelines/templates/steps/partner-feed-api-review.yml parameters: - ArtifactPath: $(Build.ArtifactStagingDirectory)/packages - Artifacts: ${{ parameters.Artifacts }} - ConfigFileDir: $(Build.ArtifactStagingDirectory)/PackageInfo + Steps: + - template: /eng/common/pipelines/templates/steps/create-apireview.yml + parameters: + ArtifactPath: $(Build.ArtifactStagingDirectory)/packages + Artifacts: ${{ parameters.Artifacts }} + ConfigFileDir: $(Build.ArtifactStagingDirectory)/PackageInfo - ${{ if eq(variables['Build.Reason'], 'PullRequest') }}: - ${{ each artifact in parameters.Artifacts }}: diff --git a/eng/pipelines/templates/steps/partner-feed-api-review.yml b/eng/pipelines/templates/steps/partner-feed-api-review.yml new file mode 100644 index 0000000000..8427773e0e --- /dev/null +++ b/eng/pipelines/templates/steps/partner-feed-api-review.yml @@ -0,0 +1,14 @@ +parameters: + - name: Steps + type: stepList + +steps: + - ${{ each step in parameters.Steps }}: + - ${{ each pair in step }}: + ${{ if ne(pair.key, 'condition') }}: + ${{ pair.key }}: ${{ pair.value }} + condition: >- + and( + ne(variables['PublishToVcpkgPartnerFeed'], 'true'), + ${{ coalesce(step.condition, 'succeeded()') }} + ) From 875dbcbd319ceb914a88f56596bb73238ca5d965 Mon Sep 17 00:00:00 2001 From: Jinming Hu Date: Sat, 7 Nov 2026 09:03:23 +1100 Subject: [PATCH 2/2] Rename partner-feed step guard for clarity Rename the generic runtime helper to skip-steps-for-partner-feed.yml without changing its content or behavior. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --- eng/pipelines/templates/jobs/archetype-sdk-client.yml | 2 +- ...tner-feed-api-review.yml => skip-steps-for-partner-feed.yml} | 0 2 files changed, 1 insertion(+), 1 deletion(-) rename eng/pipelines/templates/steps/{partner-feed-api-review.yml => skip-steps-for-partner-feed.yml} (100%) diff --git a/eng/pipelines/templates/jobs/archetype-sdk-client.yml b/eng/pipelines/templates/jobs/archetype-sdk-client.yml index 88a60a4276..ebc8a11431 100644 --- a/eng/pipelines/templates/jobs/archetype-sdk-client.yml +++ b/eng/pipelines/templates/jobs/archetype-sdk-client.yml @@ -323,7 +323,7 @@ jobs: ArtifactPath: $(Build.ArtifactStagingDirectory)/PackageInfo ArtifactName: PackageInfo - - template: /eng/pipelines/templates/steps/partner-feed-api-review.yml + - template: /eng/pipelines/templates/steps/skip-steps-for-partner-feed.yml parameters: Steps: - template: /eng/common/pipelines/templates/steps/create-apireview.yml diff --git a/eng/pipelines/templates/steps/partner-feed-api-review.yml b/eng/pipelines/templates/steps/skip-steps-for-partner-feed.yml similarity index 100% rename from eng/pipelines/templates/steps/partner-feed-api-review.yml rename to eng/pipelines/templates/steps/skip-steps-for-partner-feed.yml