Cannot add entry for distr in BEAUti

[walterxie]

launch BEAUti mvn exec:exec -Dbeast.module=beast.fx -Dbeast.main=beastfx.app.beauti.Beauti, load alignment and select bModelTest in Site Model panel, and then click Priors panel, the err dialog will pop out:

[[0], [0], [0]]
java.lang.IndexOutOfBoundsException: Index 0 out of bounds for length 0
input distr could not be added.
java.lang.IndexOutOfBoundsException: Index 0 out of bounds for length 0
	at java.base/jdk.internal.util.Preconditions.outOfBounds(Preconditions.java:100)
	at java.base/jdk.internal.util.Preconditions.outOfBoundsCheckIndex(Preconditions.java:106)
	at java.base/jdk.internal.util.Preconditions.checkIndex(Preconditions.java:302)
	at java.base/java.util.Objects.checkIndex(Objects.java:365)
	at java.base/java.util.ArrayList.get(ArrayList.java:428)
	at beast.fx@2.8.0-beta7/beastfx.app.inputeditor.ScalarDistributionInputEditor.createComboBox(ScalarDistributionInputEditor.java:627)
	at beast.fx@2.8.0-beta7/beastfx.app.inputeditor.ScalarDistributionInputEditor.init(ScalarDistributionInputEditor.java:119)
	at beast.fx@2.8.0-beta7/beastfx.app.inputeditor.InputEditorFactory.createInputEditor(InputEditorFactory.java:264)
	at beast.fx@2.8.0-beta7/beastfx.app.inputeditor.InputEditorFactory.createInputEditor(InputEditorFactory.java:145)

[alexeid]

This is a bug in BEAUti rather than in bModelTest, fixed upstream in CompEvol/beast3#126.

ScalarDistributionInputEditor.init() assumed its input is always a list of distributions with a valid item number. BMTPrior has a single ScalarDistribution valued distr input, so the editor was created with the distribution itself as the input value and itemNr == -1, and the cast to List threw. The static template caches were left half filled by that failure (scalarTemplates assigned, templateDomains still empty), so every editor created afterwards failed on templateDomains.get(k++) — the Index 0 out of bounds for length 0 reported here.

The fix resolves the distribution from either a list entry or the value of the input itself, and only publishes the template caches once they are complete. It comes with a regression test that reproduces this exact stack trace without the fix.

No change is needed in bModelTest; the distr input of BMTPrior stays editable in the Priors panel as intended. Closing here — please reopen if it still shows up once a beast3 release containing CompEvol/beast3#126 is out.