From 437a5ca9a7d698eeca2fb70553142c75e9474647 Mon Sep 17 00:00:00 2001 From: Gal Shubeli Date: Wed, 15 Jul 2026 12:20:11 +0300 Subject: [PATCH] chore: address PR #613 review nits (test PII + meta docstring) Two low-risk cleanups from the automated review of the staging->main release PR (#613): - tests/test_usage_tracking.py: replace the real employee email used to build USER_ID with a fictitious example.com address. Keeps the base64 encoding behaviour identical while keeping PII out of test data. - api/routes/meta.py: the module docstring referenced "version/health" but only /version exists. Align the docstring with the actual surface. The other automated findings were verified as false positives and are left unchanged (see PR replies): publish-pypi.yml already builds once and shares the artifact across both publish jobs with success-gated `needs`; the Vite dev proxy already forwards /version via the /api prefix (buildApiUrl -> /api/version); and `openai` is a transitive dependency of graphiti-core (0.29.1), so the [server] extra install always includes it. Co-Authored-By: Claude Opus 4.8 (1M context) --- api/routes/meta.py | 2 +- tests/test_usage_tracking.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/api/routes/meta.py b/api/routes/meta.py index 55006ab8..9d08cb72 100644 --- a/api/routes/meta.py +++ b/api/routes/meta.py @@ -1,4 +1,4 @@ -"""Public metadata routes (version/health) for the QueryWeaver API. +"""Public metadata route (``/version``) for the QueryWeaver API. These endpoints are intentionally unauthenticated so the frontend can read them before login. Their tag is not mapped to any MCP type, so FastMCP's diff --git a/tests/test_usage_tracking.py b/tests/test_usage_tracking.py index 2baf0435..1d3a0973 100644 --- a/tests/test_usage_tracking.py +++ b/tests/test_usage_tracking.py @@ -21,7 +21,7 @@ pytestmark = [pytest.mark.unit] -EMAIL = "gal.shubeli@falkordb.com" +EMAIL = "test.user@example.com" USER_ID = base64.b64encode(EMAIL.encode()).decode()