diff --git a/tests/const/test_const_apptype_split_unit.py b/tests/const/test_const_apptype_split_unit.py index 7003713ea..e198baf3a 100644 --- a/tests/const/test_const_apptype_split_unit.py +++ b/tests/const/test_const_apptype_split_unit.py @@ -1189,7 +1189,7 @@ def test_the_new_dunders_are_byte_identical_to_the_percent_form(self) -> None: rather than spot-checked. Swept over all 12,391 real members (TCP 6147, UDP 6143, SCTP 91, - DCCP 10, matching the population GitHub issue #783 measured), each + DCCP 10, matching the population PR #783 measured), each compared against what the pre-#798 ``%``-style formula would have produced for that same member's own ``svc``/``port``/``proto``. This is an invariance check -- it is true either side of #798's fix by diff --git a/tests/const/test_const_enum_builtin_parity.py b/tests/const/test_const_enum_builtin_parity.py index 5f4fe846b..b1079ddfe 100644 --- a/tests/const/test_const_enum_builtin_parity.py +++ b/tests/const/test_const_enum_builtin_parity.py @@ -95,7 +95,7 @@ #: #: Only :class:`~pcapkit.const.mh.cga_type.CGAType` still ends in #: :func:`~aenum.extend_enum` (its mint is not an IANA-style range at all, so -#: GitHub issues #775/#847's ruling never touched it). +#: the #775/#847 ruling never touched it). #: :class:`~pcapkit.const.ipv4.protection_authority.ProtectionAuthority` #: resolves the same way but no longer *registers* -- its bare ``Unassigned`` #: converted, so it now goes through ``_unregistered_member`` and the @@ -148,7 +148,7 @@ #: their ``_missing_`` guard (inherited from the *shared* #: :mod:`pcapkit.vendor.default` template) and which the issue's own last #: comment split back out, plus ``pcapkit.const.reg.apptype.apptype`` (already -#: an f-string since #792, and off the table anyway while GitHub issue #815 +#: an f-string since #792, and off the table anyway while PR #815 #: owns that tree). What is left with an actual ``%``-formatted ``__repr__`` #: is exactly these three -- each its own bespoke vendor template, like #: :data:`ISSUE_804_PAIR`'s pair, so each gets a const half and a vendor half. @@ -772,7 +772,7 @@ def test_the_auto_extending_integer_registries_still_extend(self) -> None: """:class:`~pcapkit.const.mh.cga_type.CGAType` is the one true survivor here: its ``Tag_`` mint is not an IANA-style range at all (a CGA extension type tag is a collision-avoidance random 128-bit value), so - GitHub issues #775/#847's mint-criterion ruling never touched it. + the #775/#847 mint-criterion ruling never touched it. :class:`~pcapkit.const.ipv4.protection_authority.ProtectionAuthority` used to stand here beside it -- its own unbounded ``_missing_`` also @@ -952,7 +952,7 @@ def test_the_disable_drops_only_where_nothing_else_needs_percent_formatting(self All four bespoke const modules now carry no ``%``-formatted code, so all four drop their module-level ``consider-using-f-string``. ``pcapkit.const.tcp.flags`` and ``pcapkit.const.reg.apptype.apptype`` - got there under GitHub issue #803, once their guards -- and, for the + got there under PR #803, once their guards -- and, for the latter, its three dunders and its span-handling tail -- were converted. ``pcapkit.const.ftp.command`` and ``pcapkit.const.http.method`` were *not* an oversight of #798, whose @@ -1135,7 +1135,7 @@ def test_the_issue_804_templates_render_the_committed_modules(self) -> None: The same proof shape as :meth:`test_the_tcp_flags_template_renders_the_committed_module`, - which GitHub issue #803 added for the other half of + which PR #677 added for the other half of :data:`BESPOKE_TEMPLATES`. This is what makes a half-applied conversion -- template edited but generated file not, or the reverse -- fail here rather than at the next crawl, which is the failure mode diff --git a/tests/const/test_const_enum_get.py b/tests/const/test_const_enum_get.py index 2ef095792..8a18afcb1 100644 --- a/tests/const/test_const_enum_get.py +++ b/tests/const/test_const_enum_get.py @@ -95,8 +95,8 @@ #: below rather than in this set. #: #: Both used to auto-*extend* their unassigned span across the full integer -#: range, via :func:`~aenum.extend_enum`. GitHub issues #775/#847's -#: mint-criterion ruling converted :class:`~pcapkit.const.ipv4. +#: range, via :func:`~aenum.extend_enum`. The #775/#847 mint-criterion +#: ruling converted :class:`~pcapkit.const.ipv4. #: protection_authority.ProtectionAuthority`'s bare ``Unassigned`` label, so it #: now resolves via :meth:`~pcapkit.corekit.enum.EnumRegistry. #: _unregistered_member` instead -- it still resolves anything (the property @@ -129,7 +129,7 @@ #: :class:`~pcapkit.const.pcapng.filter_type.FilterType` declares *no* static #: members at all -- every one of its 256 codes reaches ``_missing_``. Before -#: GitHub issues #775/#847's ruling that was masked by an accident: importing +#: the #775/#847 ruling that was masked by an accident: importing #: :mod:`pcapkit.protocols.misc.pcapng` evaluates ``Enum_FilterType(0)`` as a #: default argument at class-definition time, which used to permanently mint #: ``'Unassigned_0'`` as a side effect of merely importing the library -- @@ -383,8 +383,8 @@ def test_the_always_resolving_registries_have_nothing_to_fall_back_to(self) -> N Probing :class:`~pcapkit.const.mh.cga_type.CGAType` still *mutates* the registry: the call permanently registers a member on a - module-global class, because its mint is untouched by GitHub issues - #775/#847's ruling. That is done deliberately here, and + module-global class, because its mint is untouched by the + #775/#847 ruling. That is done deliberately here, and ``setUpClass`` registers a class cleanup that purges :mod:`pcapkit` afterwards so the pollution cannot reach another module. :class:`~pcapkit.const.ipv4.protection_authority.ProtectionAuthority` diff --git a/tests/const/test_const_enum_no_mint.py b/tests/const/test_const_enum_no_mint.py index 820a6a1a3..437c38f43 100644 --- a/tests/const/test_const_enum_no_mint.py +++ b/tests/const/test_const_enum_no_mint.py @@ -1448,7 +1448,7 @@ class RulingConversionSourceTests(unittest.TestCase): def test_no_reachable_gap_registries_no_longer_call_extend_enum(self) -> None: # EtherType now belongs to RULING_CONVERTED_WITH_REACHABLE_GAP: its # masked-branch exclusion (Old Xerox shadowed by the wider IEEE802.3 - # range) was fixed by GitHub issue #862/#865, and its first converted + # range) was fixed under GitHub issue #862, and its first converted # branch by source order is directly probeable like any other # reachable-gap registry now. The `_MIXED_REGISTRIES` subtraction # below is a defensive no-op today -- neither mixed registry needs diff --git a/tests/const/test_const_ethertype_862_unit.py b/tests/const/test_const_ethertype_862_unit.py index b56b95ad1..3efecd4bc 100644 --- a/tests/const/test_const_ethertype_862_unit.py +++ b/tests/const/test_const_ethertype_862_unit.py @@ -209,7 +209,7 @@ def test_nested_ranges_are_ordered_narrowest_first(self) -> None: "insert ahead of a containing range" -- not a general correctness proof for arbitrary nesting depth or arrival order. That exhaustive proof (every arrival order at 3 and 4 levels, plus randomised - fuzzing) was done separately during GitHub issue #862/#865's review + fuzzing) was done separately in the review of PR #865, #862's fix, and does not live in this repository as a test; this method only pins the two specific shortcuts that review considered and rejected. diff --git a/tests/const/test_const_method_value_lookup_908_unit.py b/tests/const/test_const_method_value_lookup_908_unit.py index c557c159a..e947858f2 100644 --- a/tests/const/test_const_method_value_lookup_908_unit.py +++ b/tests/const/test_const_method_value_lookup_908_unit.py @@ -31,12 +31,12 @@ zero-argument ``super()`` inside a :class:`staticmethod` has no first argument to bind (``RuntimeError: super(): no arguments``). So the override had to move to :class:`classmethod` as well, following the shape -GitHub issue #913's ``FEATCode.get`` sets for the same base method. +PR #913's ``FEATCode.get`` sets for the same base method. **Two behaviours settled by earlier issues must survive unchanged**, each pinned by its own test below rather than only implied by the others: -* Case-sensitivity, per :rfc:`9110#section-9.1` and GitHub issue #896/#907 -- +* Case-sensitivity, per :rfc:`9110#section-9.1` and GitHub issue #896 -- ``Method.get('get')`` must *not* resolve to :attr:`Method.GET`. * An unregistered member's *value* is the caller's own casing, never the upper-cased form -- GitHub issue #860's ruling, already exercised by @@ -126,7 +126,7 @@ class PreservedBehaviourTests(unittest.TestCase): """The two settled behaviours the fix must not disturb.""" def test_case_sensitivity_from_896_still_holds(self) -> None: - """RFC 9110 Section 9.1, via GitHub issue #896/#907: a name match is + """RFC 9110 Section 9.1, via GitHub issue #896: a name match is case-**sensitive**, so ``get('get')`` must not resolve to :attr:`Method.GET`. Fails against a naive fix that resolves ``key`` through ``cls(key)`` (which folds case via ``_missing_``) instead of @@ -306,7 +306,7 @@ def test_the_docstring_documents_the_value_error(self) -> None: class VendorTemplateParityTests(unittest.TestCase): """The fix lives in the crawler template, so a regeneration cannot - silently discard it -- following GitHub issue #913's own precedent + silently discard it -- following PR #913's own precedent (``test_the_crawler_template_carries_the_same_get``).""" def test_the_crawler_template_carries_the_same_get(self) -> None: diff --git a/tests/const/test_const_registry_protocol.py b/tests/const/test_const_registry_protocol.py index 5f0d75c3d..e69339fdf 100644 --- a/tests/const/test_const_registry_protocol.py +++ b/tests/const/test_const_registry_protocol.py @@ -966,7 +966,7 @@ def test_transtype_no_longer_mints_its_declared_unassigned_range(self) -> None: """:class:`~pcapkit.const.reg.transtype.TransType` used to be the other shape: its own ``_missing_`` minted permanently via :func:`~aenum.extend_enum` for ``148..252`` rather than going through - ``_unregistered_member``. GitHub issues #775/#847's mint-criterion + ``_unregistered_member``. The #775/#847 mint-criterion ruling converted it: the label is a bare ``Unassigned``, which is a notation for the reader rather than a name IANA assigned, so it now matches :class:`~pcapkit.const.arp.hardware.Hardware`'s shape above