From d81f7a45d7ae28124440b7ac56738def1b276592 Mon Sep 17 00:00:00 2001
From: William Allen <william.allen@kitware.com>
Date: Sun, 16 Aug 2026 19:46:27 -0400
Subject: [PATCH] Remove dead code from ProcessSubmission

I've noticed this dead code several times, but thought it was too trivial to justify a dedicated PR.  With major changes to this file upcoming, this is a good time to remove the dead code so it doesn't cause confusion.
---
 app/Jobs/ProcessSubmission.php |  5 -----
 config/cdash.php               |  1 -
 phpstan-baseline.neon          | 12 ------------
 3 files changed, 18 deletions(-)

diff --git a/app/Jobs/ProcessSubmission.php b/app/Jobs/ProcessSubmission.php
index 198cd67bfa..489236a254 100644
--- a/app/Jobs/ProcessSubmission.php
+++ b/app/Jobs/ProcessSubmission.php
@@ -46,10 +46,7 @@ class ProcessSubmission implements ShouldQueue
     use Queueable;
     use SerializesModels;
 
-    public int $timeout;
-
     public $filename;
-    public string $localFilename = '';
     public $projectid;
     public $buildid;
     public $expected_md5;
@@ -61,8 +58,6 @@ class ProcessSubmission implements ShouldQueue
      */
     public function __construct($filename, $projectid, $buildid, $expected_md5)
     {
-        $this->timeout = config('cdash.queue_timeout');
-
         $context = [];
         if (isset($projectid)) {
             $context['projectid'] = $projectid;
diff --git a/config/cdash.php b/config/cdash.php
index db1f387fda..7bea2b629d 100755
--- a/config/cdash.php
+++ b/config/cdash.php
@@ -46,7 +46,6 @@
     'login_field' => env('LOGIN_FIELD', 'Email'),
     'max_upload_quota' => env('MAX_UPLOAD_QUOTA', 10),
     'notify_pull_request' => env('NOTIFY_PULL_REQUEST', false),
-    'queue_timeout' => env('QUEUE_TIMEOUT', 2000),
     'retry_base' => env('QUEUE_RETRY_BASE', 5),
     'show_last_submission' => env('SHOW_LAST_SUBMISSION', true),
     'slow_page_time' => env('SLOW_PAGE_TIME', 10),
diff --git a/phpstan-baseline.neon b/phpstan-baseline.neon
index 6c58b77e1d..6f5da468ed 100644
--- a/phpstan-baseline.neon
+++ b/phpstan-baseline.neon
@@ -4791,12 +4791,6 @@ parameters:
 			count: 1
 			path: app/Jobs/ProcessSubmission.php
 
-		-
-			rawMessage: 'Method App\Jobs\ProcessSubmission::__construct() throws checked exception TypeError but it''s missing from the PHPDoc @throws tag.'
-			identifier: missingType.checkedException
-			count: 1
-			path: app/Jobs/ProcessSubmission.php
-
 		-
 			rawMessage: 'Method App\Jobs\ProcessSubmission::check_email_update_errors() return type has no value type specified in iterable type array.'
 			identifier: missingType.iterableValue
@@ -4935,12 +4929,6 @@ parameters:
 			count: 1
 			path: app/Jobs/ProcessSubmission.php
 
-		-
-			rawMessage: 'Property App\Jobs\ProcessSubmission::$timeout (int) does not accept bool|int|string.'
-			identifier: assign.propertyType
-			count: 1
-			path: app/Jobs/ProcessSubmission.php
-
 		-
 			rawMessage: 'Parameter #1 $value of method Carbon\Carbon::subHours() expects float|int, bool|int|string given.'
 			identifier: argument.type