Skip to content

MobFox on iPad doesn't size correctly #1

Description

@swemoney

On the iPad, a MobFox ad displayed through AdFlake gets fetched as it's full size, but AdFlake truncates it into a 320x50 ad. I don't run many networks but I didn't notice AdMob or Millennial Media being affected by the issue.

I quick fixed it by replacing the initWithDelegate [super initWithFrame: kAdFlakeViewDefaultFrame] in AdFlakeView.m as follows but haven't tested it enough to know if there's another problem elsewhere.

- (id)initWithDelegate:(id<AdFlakeDelegate>)d {    
    self = [super initWithFrame:(UI_USER_INTERFACE_IDIOM() == UIUserInterfaceIdiomPad) ? CGRectMake(0, 0, 728, 90) : kAdFlakeViewDefaultFrame];
    ....
}

As well as replacing the MobFoxBannerView initWithFrame in AdFlakeAdapterMobFox.m with...

- (void)getAd {
    MobFoxBannerView *adView = [[[MobFoxBannerView alloc] initWithFrame:((UI_USER_INTERFACE_IDIOM() == UIUserInterfaceIdiomPad) ? CGRectMake(0, 0, 728, 90) : kAdFlakeViewDefaultFrame)] autorelease];
    ....
}

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions