ItemStack.metadata incorrect name

[danilwhale]

Type
Field

Describe where the element is
net/minecraft/item/ItemStack
I f_9776894

Description of the element
Damage value of the stack

Expected name
damage

Additional Context

// ...
    public void damageAndBreak(int damage) {
        //               v
        this.metadata += damage;
        //                       v
        if (this.metadata > this.getMaxDamage()) {
            --this.size;
            if (this.size < 0) {
                this.size = 0;
            }
            this.metadata = 0;
        }
// ...

[SpaceWalkerRS]

This would be a big change so I'd like to think this through properly. We need to look into what versions are affected because the concept of damage values went away at some point I'm pretty sure. And I seem to remember we made the deliberate choice to keep the 'metadata' name for consistency.

[SpaceWalkerRS]

I didn't mean this as "won't fix", moreso that I see this as a big change so it should be considered carefully. I'll reopen the issue and hopefully we can get a discussion started.

[SpaceWalkerRS]

I'm looking at 1.7.2 and there the metadata/"damage value" is used for two different things. Firstly for items that can be "used up" like tools, and secondly for items that have custom data, like potions, maps, dyes, etc. I think that was the reason we originally went with a more generic metadata rather than damage, but I can see the argument to go with damage because it's a term that is used by most of the community.