{{this.reviewLabels.executionAssignedPorts}}{{t "webmcp.catalogLaunchPermissions"}}
{{t "webmcp.catalogExternalVolumesPending"}}
diff --git a/app/services/ai-command-service.js b/app/services/ai-command-service.js index 334e85e99c..f0d6e1df0e 100644 --- a/app/services/ai-command-service.js +++ b/app/services/ai-command-service.js @@ -1,5 +1,5 @@ import Service, { service } from '@ember/service'; -import { CommandEngine } from 'ui/utils/ai-command-engine'; +import { CommandEngine, serviceCreateReview } from 'ui/utils/ai-command-engine'; import { publicError, CommandError } from 'ui/utils/ai-command-contract'; import { safeCatalogQuestions, CATALOG_LAUNCH_COLLECTION } from 'ui/utils/ai-catalog-launch'; @@ -37,7 +37,8 @@ export default Service.extend({ publishPlan(plan, expectedPlanRef) { if ( expectedPlanRef !== undefined && this.get('pendingPlan.planRef') !== expectedPlanRef ) { return; } this.set('operationNotice', null); - this.set('pendingPlan', plan); + const reviewSignature = serviceCreateReview(plan); + this.set('pendingPlan', reviewSignature ? Object.assign({}, plan, {reviewSignature}) : plan); }, captureReviewContext() { @@ -73,9 +74,12 @@ export default Service.extend({ // Only the human confirmation component calls this method. It is never // included in the WebMCP registry; approval is checked again by the server. - confirmPendingPlan() { + confirmPendingPlan(reviewedPlan) { const plan = this.get('pendingPlan'); if ( !plan ) { return Promise.resolve(publicError(new CommandError('STALE_REFERENCE', 'planRef'))); } + if ( reviewedPlan && (reviewedPlan.planRef !== plan.planRef || reviewedPlan.reviewSignature !== plan.reviewSignature) ) { + return Promise.resolve(publicError(new CommandError('CONFLICT', 'planRef'))); + } if ( plan.humanOnly ) { return this.confirmHumanPlan(plan); } return this.engine.confirmPlan(plan.planRef); }, @@ -97,6 +101,7 @@ export default Service.extend({ if ( plan.planKind === 'catalog-launch' ) { this.assertCatalogHumanPlan(body, plan); } else if ( plan.planKind === 'resource-change' ? body.resourceType !== plan.resourceType || body.operation !== plan.operation || body.resourceId !== plan.serverResourceId : body.serviceId !== plan.serverServiceId ) { throw new CommandError('INVALID_RESPONSE'); } const summary = this.engine.planSummary(body, plan.planRef); + if ( plan.reviewSignature && serviceCreateReview(summary) !== plan.reviewSignature ) { throw new CommandError('CONFLICT'); } this.publishPlan(Object.assign({}, plan, summary), plan.planRef); return Object.assign({status: 'succeeded'}, summary); } catch (error) { return publicError(error); } @@ -228,7 +233,13 @@ export default Service.extend({ samePlan = reference.id === operation.planId; } if ( !samePlan ) { return; } - if ( ['succeeded', 'failed'].includes(operation.status) ) { + const summary = operation.planSummary; + if ( operation.status === 'succeeded' && pending.planKind === 'resource-change' && pending.resourceType === 'service' && pending.operation === 'create' && + summary && summary.planKind === 'resource-change' && summary.resourceType === 'service' && summary.operation === 'create' && + summary.planStatus === 'succeeded' && summary.verifiedResult === true && summary.executionResult ) { + if ( JSON.stringify([summary.displayPath, summary.displayDiff]) !== JSON.stringify([pending.displayPath, pending.displayDiff]) ) { return; } + this.publishPlan({...pending, executionResult: summary.executionResult, planStatus: 'succeeded', verifiedResult: true}, pending.planRef); + } else if ( ['succeeded', 'failed'].includes(operation.status) ) { const denied = pending.planKind === 'resource-change' && operation.status === 'failed' && operation.messageCode === 'ResourceChangeAuthorizationDenied'; this.set('operationNotice', denied ? {code: 'ResourceChangeAuthorizationDenied'} : null); this.set('pendingPlan', null); diff --git a/app/utils/ai-command-contract.js b/app/utils/ai-command-contract.js index 5f583da5c2..d256fb60b9 100644 --- a/app/utils/ai-command-contract.js +++ b/app/utils/ai-command-contract.js @@ -8,6 +8,27 @@ const schema = (properties, required = []) => ({type: 'object', properties, requ const commandArray = {type: 'array', maxItems: 64, 'x-maxTotalLength': 16384, items: {type: 'string', minLength: 0, maxLength: 4096, pattern: '^[^\\u0000]*$'}, description: 'Create only. At most 64 strings, each up to 4096 UTF-16 units, total up to 16384. NUL is forbidden. These exact arguments appear in the human review.'}; +const servicePorts = {type: 'array', maxItems: 64, + items: {type: 'string', minLength: 1, maxLength: 128, pattern: '^[^\\u0000\\r\\n]+$'}, + description: 'Service create only. Native PortSpec strings, for example ["8080:80/tcp", "53:53/udp", "80/tcp"]. An omitted host port lets the native service allocate it automatically. At most 64 entries of 1 through 128 UTF-16 units. [] publishes no ports. The server validates native port numbers, ranges and bindings. Do not send objects, URLs or launchConfig.'}; +const healthInteger = (description, minimum = 1) => ({type: 'integer', minimum, maximum: 2147483647, description}); +const serviceHealthCheck = {...schema({ + port: {type: 'integer', minimum: 1, maximum: 65535, description: 'Container port to check; required. Example: 80.'}, + requestLine: {type: 'string', minLength: 0, maxLength: 1024, pattern: '^[^\\u0000\\r\\n]*$', description: 'Optional exact HTTP request line, for example "GET /health HTTP/1.0". Omit or use "" for a TCP check. No CR, LF or NUL.'}, + responseTimeout: healthInteger('Response timeout in milliseconds, 1 through 2147483647.'), + interval: healthInteger('Check interval in milliseconds, 1 through 2147483647.'), + healthyThreshold: healthInteger('Number of consecutive successful checks, 1 through 2147483647.'), + unhealthyThreshold: healthInteger('Number of consecutive failed checks, 1 through 2147483647.'), + initializingTimeout: healthInteger('Initialization timeout in milliseconds, 0 through 2147483647.', 0), + reinitializingTimeout: healthInteger('Reinitialization timeout in milliseconds, 0 through 2147483647.', 0), + strategy: {...string('On failure: none does nothing; recreate replaces the unhealthy container. Omitted means native recreate.', 8), enum: ['none', 'recreate']}, +}, ['port']), description: 'Service create only. Closed native health-check subset. Example: {"port":80,"requestLine":"GET /health HTTP/1.0","interval":2000,"responseTimeout":2000,"healthyThreshold":2,"unhealthyThreshold":3,"strategy":"recreate"}. Omit healthCheck for no check. Null, arbitrary headers, credentials and quorum configuration are not supported.'}; + +// Reuse the tool schema when verifying the server's JSON review values. +export function validateServiceCreateField(field, value) { + const spec = field === 'ports' ? servicePorts : field === 'healthCheck' ? serviceHealthCheck : null; + validateValue(value, spec, `parameters.${field}`); +} const catalogAnswers = {type: 'array', maxItems: 100, items: schema({questionRef: string('questionRef from the selected version launchOptions.'), value: {type: ['string', 'number', 'boolean'], minLength: 0, maxLength: 4096, minimum: -Number.MAX_SAFE_INTEGER, maximum: Number.MAX_SAFE_INTEGER}, resourceRef: string('An authorized resourceRef, or a same-session serviceRef for service questions. Never send a raw resource ID.')}, ['questionRef']), description: 'Typed answers only. Each questionRef accepts exactly one value or resourceRef. For an optional reference, value "" explicitly selects no resource. Human-only inputs must be completed in the console; never send a password or secret value.'}; @@ -36,7 +57,7 @@ export const COMMANDS = Object.freeze([ auditFilters: {...auditFilters, description: 'Only family audit / auditLog. Explicitly query the native audit broker with these typed filters; do not combine with name query or parentRef. Available through the native browser session and the dedicated API Key bridge when matching Engine and broker audit-query components are installed. Current actor permission, Key scope and policy revision still apply. Request/response payloads remain human-only.'}}, ['family'])}, {name: 'get_resource', description: 'Read safe metadata from a resourceRef returned by find_resources. Description is preserved through 1024 UTF-16 units. Check truncatedFields and never construct an append or replacement from truncated text. Secrets, API keys, tokens, environment variables and raw configuration are never returned.', inputSchema: schema({resourceRef: string('Opaque resourceRef from find_resources, unchanged.')}, ['resourceRef'])}, - {name: 'preview_resource_change', write: true, description: 'Preview a typed stack, service, externalService, dnsService (Alias) or container change. A human must approve the exact server plan before apply. create needs name (and image for service/container); service/externalService/dnsService create also needs parentRef of its stack. Alias create makes an empty stopped Alias without targets; after verification use update_targets with serviceRefs for a separately approved target binding. External Service create requires exactly one hostname or nonempty externalIpAddresses, without an image. Plain create makes stopped workloads; start needs a separate plan. Catalog stack create_from_catalog needs catalogVersionRef and typed answers; startOnCreate explicitly controls service startup. Stack/service archive requires completely stopped workloads and empty parameters; it never stops or deletes them. restore clears only the target archive flag, does not start it or change parent/child flags. Other operations require targetRef. Credentials, raw IDs and arbitrary configuration are not accepted.', + {name: 'preview_resource_change', write: true, description: 'Preview a typed stack, service, externalService, dnsService (Alias) or container change. A human must approve the exact server plan before apply. create needs name (and image for service/container); service/externalService/dnsService create also needs parentRef of its stack. Only service create accepts ports (native PortSpec string array) and a closed healthCheck object; these require matching server support and are shown in human review. Existing service settings use upgrade, never update_metadata or a raw launchConfig. Alias create makes an empty stopped Alias without targets; after verification use update_targets with serviceRefs for a separately approved target binding. External Service create requires exactly one hostname or nonempty externalIpAddresses, without an image. Plain create makes stopped workloads; start needs a separate plan. Catalog stack create_from_catalog needs catalogVersionRef and typed answers; startOnCreate explicitly controls service startup. Stack/service archive requires completely stopped workloads and empty parameters; it never stops or deletes them. restore clears only the target archive flag, does not start it or change parent/child flags. Other operations require targetRef. Credentials, raw IDs and arbitrary configuration are not accepted.', inputSchema: schema({resourceType: {...string('Resource type from list_capabilities.'), enum: Object.keys(RESOURCE_CHANGES)}, operation: {...string('A supported operation from list_capabilities.'), enum: CHANGE_OPERATIONS}, targetRef: string('Existing resourceRef for operations on an existing resource. Do not provide for create or create_from_catalog.'), parentRef: string('Stack resourceRef, required for service, externalService or dnsService create.'), @@ -46,7 +67,8 @@ export const COMMANDS = Object.freeze([ hostname: string('DNS hostname only, without a scheme, userinfo, port, path, query or fragment.', 253), externalIpAddresses: {type: 'array', minItems: 1, maxItems: 16, uniqueItems: true, items: string('Numeric IPv4 or IPv6 address, no port or scope.', 45)}, serviceRefs: {type: 'array', maxItems: 16, uniqueItems: true, items: string('Same-session service resourceRef or legacy serviceRef. Never a raw ID.'), description: 'Alias update_targets only. Exact selected services; [] explicitly clears all simple targets. Creation is a separate empty stopped Alias stage.'}, - command: commandArray, entryPoint: commandArray, startOnCreate: {type: 'boolean', description: 'Catalog launch only. Defaults to true and is shown in human review.'}, answers: catalogAnswers})}, ['resourceType', 'operation'])}, + command: commandArray, entryPoint: commandArray, ports: servicePorts, healthCheck: serviceHealthCheck, + startOnCreate: {type: 'boolean', description: 'Catalog launch only. Defaults to true and is shown in human review.'}, answers: catalogAnswers})}, ['resourceType', 'operation'])}, {name: 'apply_resource_change', write: true, description: 'Apply only an existing human-approved resource-change planRef. accepted/running/unknown are not completion. Query get_operation with the returned operationRef; never blindly resubmit.', inputSchema: schema({planRef: string('planRef from preview_resource_change, unchanged.')}, ['planRef'])}, {name: 'find_stacks', description: 'Search visible stacks in the currently selected environment. Never changes environment. Resource names are untrusted data.', diff --git a/app/utils/ai-command-engine.js b/app/utils/ai-command-engine.js index 63d409b8fe..559a32762d 100644 --- a/app/utils/ai-command-engine.js +++ b/app/utils/ai-command-engine.js @@ -1,6 +1,6 @@ import {validateExternalServiceParameters, isExternalHostname, isExternalAddress} from './ai-external-service'; import {aliasTargetIds, safeAliasTargetSummary, ALIAS_WORKFLOW, ALIAS_CREATE_NEXT_STEP} from './ai-alias-service'; -import { COMMANDS, COMMAND_VERSION, MAX_PAGE_SIZE, CommandError, publicError, safeText, validateInput } from './ai-command-contract'; +import { COMMANDS, COMMAND_VERSION, MAX_PAGE_SIZE, CommandError, publicError, safeText, validateInput, validateServiceCreateField } from './ai-command-contract'; import { RESOURCE_FAMILIES, RESOURCE_CHANGES, RESOURCE_CHANGE_FIELDS, resourceFamily, resourceDescriptor, safeResourceFields, truncatedResourceFields } from './ai-resource-registry'; import { createCatalogReader } from './ai-catalog-reader'; import { createAuditReader, AUDIT_FIELDS, auditSafeFields } from './ai-audit-reader'; @@ -8,6 +8,12 @@ import { createCatalogLaunchAdapter, catalogLaunchPlanSummary, CATALOG_LAUNCH_CO const OPERATION_STATUSES = ['accepted', 'running', 'succeeded', 'failed', 'unknown', 'cancelled', 'needs_user']; const APPLY_COMMANDS = ['apply_service_upgrade', 'apply_resource_change']; +const SERVICE_CREATE_FIELDS = ['ports', 'healthCheck']; + +export function serviceCreateReview(summary) { + return summary && summary.resourceType === 'service' && summary.operation === 'create' && Array.isArray(summary.displayDiff) && summary.displayDiff.some((change) => SERVICE_CREATE_FIELDS.includes(change.field)) ? + JSON.stringify([summary.displayPath, summary.displayDiff]) : null; +} class UnknownOperation extends Error { constructor(operationRef) { super('UNKNOWN_RESULT'); this.operationRef = operationRef; } @@ -46,7 +52,7 @@ export class CommandEngine { } async execute(name, input, options = {}) { - let captured, result, startAck, businessStarted = false, descriptionMayHaveSaved = false; + let captured, result, startAck, businessStarted = false, descriptionMayHaveSaved = false, serviceCreateInputRejected = false; const commandName = COMMANDS.some((item) => item.name === name) ? name : 'unknown'; try { captured = this.context.capture(); @@ -74,6 +80,9 @@ export class CommandEngine { } else { // Never expose the transport error, response body, launchConfig or token. result = publicError(error); + serviceCreateInputRejected = name === 'preview_resource_change' && input && input.resourceType === 'service' && input.operation === 'create' && + input.parameters && SERVICE_CREATE_FIELDS.some((field) => Object.prototype.hasOwnProperty.call(input.parameters, field)) && + Number(error && (error.status || error.statusCode)) === 422 && error.body && error.body.code === 'ResourceChangeInputInvalid' && result.code === 'INVALID_INPUT'; } } if ( result.reason === 'TARGET_BUSY' ) { @@ -108,7 +117,11 @@ export class CommandEngine { 'parameters.serviceRefs': 'Find each exact service by name and Stack with find_resources. Select its same-session resourceRef; never choose the first same-name candidate, guess a raw ID or reuse a stale reference. Supply at most 16 distinct serviceRefs; [] explicitly clears the simple targets.', operation: 'Use list_capabilities and choose an implemented operation for this resource type.', }; - result.nextStep = input && ['archive', 'restore'].includes(input.operation) && result.field && result.field.startsWith('parameters') ? + result.nextStep = serviceCreateInputRejected ? + 'Check the native PortSpec strings and healthCheck fields and bounds. The server rejected this input. If these fields are unsupported on this server version, use the matching service-create adapter or the normal console. Do not drop requested settings, send launchConfig or retry through a generic update.' : + result.field && /^parameters\.(ports|healthCheck)(\.|\[|$)/.test(result.field) ? + 'Only service create accepts ports as at most 64 native PortSpec strings of 1 through 128 UTF-16 units, or healthCheck with required port 1 through 65535 and the exact fields and bounds in the schema. Timings are milliseconds; thresholds count checks. Reuse the selected Stack parentRef unchanged.' : + input && ['archive', 'restore'].includes(input.operation) && result.field && result.field.startsWith('parameters') ? 'Preview archive or restore separately with an existing targetRef and empty parameters. Do not include a service clone, archive flag or other settings.' : repairs[result.field] || (result.field && /^parameters\.(command|entryPoint)(\[\d+\])?$/.test(result.field) ? 'Use a string array: at most 64 items, 4096 UTF-16 units per item, 16384 in total, and no NUL. These arrays are supported only for service/container create.' : 'Use find_resources for the target family and reuse its resourceRef as targetRef. For service create, find the stack and pass its resourceRef as parentRef. Send only the fields supported by this operation.'); @@ -228,6 +241,7 @@ export class CommandEngine { safeFields: [...descriptor.fields], parentType: descriptor.parent ? descriptor.parent.type : null, parentRequired: !!(descriptor.parent && descriptor.parent.required), operations: RESOURCE_CHANGES[descriptor.type] ? Object.keys(RESOURCE_CHANGES[descriptor.type]) : [], + ...(descriptor.type === 'service' ? {createFields: [...RESOURCE_CHANGES.service.create.fields], createFieldsServerCheckRequired: true} : {}), ...(descriptor.type === 'dnsService' ? {workflow: [...ALIAS_WORKFLOW], workflowNotice: ALIAS_CREATE_NEXT_STEP} : {}), changeModeEnabled: captured.mode === 'enabled', changesRequireHumanApproval: true, unavailableReason: needsCheck ? null : !supported ? 'PENDING_ADAPTER' : source.unavailable || (!definition ? 'NOT_VISIBLE' : null)}; @@ -661,9 +675,10 @@ export class CommandEngine { return; } if ( reference.planKind === 'resource-change' ) { - this.resourcePlanSummary(plan, null); + const summary = this.resourcePlanSummary(plan, null); if ( plan.id !== reference.id || plan.resourceType !== reference.resourceType || plan.operation !== reference.operation || reference.resourceId && plan.resourceId !== reference.resourceId ) { throw new CommandError('INVALID_RESPONSE'); } + if ( reference.serviceCreateReview && serviceCreateReview(summary) !== reference.serviceCreateReview ) { throw new CommandError('CONFLICT'); } return; } if ( !plan || plan.id !== reference.id || (plan.serviceId && plan.serviceId !== reference.serviceId) ) { @@ -679,6 +694,11 @@ export class CommandEngine { verifiedResult: plan.verifiedResult === true, messageCode: safeText(plan.messageCode || plan.reason, 80)}; const authorizationDenied = result.status === 'failed' && plan.id && plan.id.startsWith('aichange-') && plan.messageCode === 'ResourceChangeAuthorizationDenied'; + let serviceCreateSummary; + if ( result.status === 'succeeded' && result.verifiedResult && plan.resourceType === 'service' && plan.operation === 'create' ) { + const summary = this.resourcePlanSummary(plan, null); + if ( summary.executionResult ) { result.executionResult = summary.executionResult; serviceCreateSummary = summary; } + } if ( authorizationDenied ) { Object.assign(result, {code: 'FORBIDDEN', verifiedResult: false, partialEffectsPossible: true, nextStep: 'A background authorization check denied this operation. Some changes may already have occurred; completion has not been verified. Check the current permissions, then query this same operationRef and inspect its original receipt and resources in the console. Do not blindly resubmit or approve another change.'}); @@ -707,6 +727,7 @@ export class CommandEngine { } else if ( result.status === 'succeeded' || result.status === 'failed' ) { const operation = {planId: plan.id, status: result.status}; if ( authorizationDenied ) { operation.messageCode = 'ResourceChangeAuthorizationDenied'; } + if ( serviceCreateSummary ) { operation.planSummary = serviceCreateSummary; } this.onOperation(operation); } return result; @@ -762,13 +783,17 @@ export class CommandEngine { } const displayDiff = plan.changes.map((change) => { if ( !change || !RESOURCE_CHANGE_FIELDS.includes(change.field) || - ![change.before, change.after].every((value) => value === null || typeof value === 'string' && value.length <= (['command', 'entryPoint', 'targetServices'].includes(change.field) ? 100000 : 1024) || + ![change.before, change.after].every((value) => value === null || typeof value === 'string' && value.length <= (['command', 'entryPoint', 'targetServices', 'ports', 'healthCheck'].includes(change.field) ? 100000 : 1024) || typeof value === 'boolean' || typeof value === 'number' && Number.isFinite(value)) ) { throw new CommandError('INVALID_RESPONSE'); } if ( change.field === 'hostname' && [change.before, change.after].some((value) => value !== null && !isExternalHostname(value)) ) { throw new CommandError('INVALID_RESPONSE'); } if ( change.field === 'targetServices' ) { if ( plan.resourceType !== 'dnsService' || change.after === null ) { throw new CommandError('INVALID_RESPONSE'); } safeAliasTargetSummary(change.before); safeAliasTargetSummary(change.after); } + if ( SERVICE_CREATE_FIELDS.includes(change.field) ) { + if ( plan.resourceType !== 'service' || plan.operation !== 'create' || change.before !== null || typeof change.after !== 'string' ) { throw new CommandError('INVALID_RESPONSE'); } + try { validateServiceCreateField(change.field, JSON.parse(change.after)); } catch (error) { throw new CommandError('INVALID_RESPONSE'); } + } if ( change.field === 'externalIpAddresses' ) { for ( const value of [change.before, change.after] ) { if ( value === null ) { continue; } @@ -801,8 +826,18 @@ export class CommandEngine { if ( ['archive', 'restore'].includes(plan.operation) && (displayDiff.length !== 1 || displayDiff[0].field !== 'archived') ) { throw new CommandError('INVALID_RESPONSE'); } + if ( SERVICE_CREATE_FIELDS.some((field) => displayDiff.filter((change) => change.field === field).length > 1) ) { throw new CommandError('INVALID_RESPONSE'); } + let executionResult; + if ( plan.executionResult !== undefined && plan.executionResult !== null ) { + const receipt = plan.executionResult; + if ( plan.resourceType !== 'service' || plan.operation !== 'create' || plan.status !== 'succeeded' || plan.verifiedResult !== true || + !receipt || typeof receipt !== 'object' || Array.isArray(receipt) || Object.keys(receipt).length !== 1 || !Object.prototype.hasOwnProperty.call(receipt, 'assignedPorts') ) { throw new CommandError('INVALID_RESPONSE'); } + try { validateServiceCreateField('ports', receipt.assignedPorts); } catch (error) { throw new CommandError('INVALID_RESPONSE'); } + executionResult = {assignedPorts: receipt.assignedPorts.slice()}; + } return {planRef, planKind: 'resource-change', resourceType: plan.resourceType, operation: plan.operation, - displayPath: safeText(plan.targetPath, 768), displayDiff, expiresAt: safeText(plan.expiresAt, 64), confirmationState: plan.confirmationState}; + displayPath: safeText(plan.targetPath, 768), displayDiff, expiresAt: safeText(plan.expiresAt, 64), confirmationState: plan.confirmationState, + ...(executionResult ? {executionResult, verifiedResult: true, planStatus: 'succeeded'} : {})}; } async preview_resource_change(input, captured, signal) { @@ -812,6 +847,9 @@ export class CommandEngine { const descriptor = operations && Object.prototype.hasOwnProperty.call(operations, input.operation) && operations[input.operation]; if ( !descriptor ) { throw new CommandError('INVALID_INPUT', 'operation'); } const parameters = Object.assign({}, input.parameters || {}); + // New nested input must not change while the server preview is in flight. + if ( Array.isArray(parameters.ports) ) { parameters.ports = parameters.ports.slice(); } + if ( parameters.healthCheck ) { parameters.healthCheck = Object.assign({}, parameters.healthCheck); } const missing = descriptor.required.find((field) => !Object.prototype.hasOwnProperty.call(parameters, field)); if ( missing ) { throw new CommandError('INVALID_INPUT', `parameters.${missing}`); } if ( Object.keys(parameters).some((field) => !descriptor.fields.includes(field)) || Object.keys(parameters).length < descriptor.minFields ) { @@ -845,6 +883,19 @@ export class CommandEngine { const plan = await this.call(captured, 'aiResourceChangePlans', 'POST', data, signal); const reference = {id: plan.id, planKind: 'resource-change', resourceType: input.resourceType, operation: input.operation, resourceId: target && target.id}; this.assertPlan(plan, reference); + if ( input.resourceType === 'service' && input.operation === 'create' ) { + for ( const field of SERVICE_CREATE_FIELDS ) { + const requested = Object.prototype.hasOwnProperty.call(parameters, field), change = plan.changes.find((item) => item.field === field); + if ( requested !== !!change ) { throw new CommandError('INVALID_RESPONSE'); } + if ( requested ) { + const expected = field === 'healthCheck' ? {...parameters.healthCheck, strategy: parameters.healthCheck.strategy || 'recreate'} : parameters.ports; + const actual = JSON.parse(change.after); + if ( field === 'ports' ? JSON.stringify(expected) !== JSON.stringify(actual) : + Object.keys(expected).length !== Object.keys(actual).length || Object.keys(expected).some((key) => expected[key] !== actual[key]) ) { throw new CommandError('INVALID_RESPONSE'); } + } + } + reference.serviceCreateReview = serviceCreateReview(this.resourcePlanSummary(plan, null)); + } const planRef = this.context.reference('plan', reference, captured); const summary = this.resourcePlanSummary(plan, planRef); this.onPlan(Object.assign({context: captured}, summary)); diff --git a/app/utils/ai-resource-registry.js b/app/utils/ai-resource-registry.js index 74db8054c8..f497c42f48 100644 --- a/app/utils/ai-resource-registry.js +++ b/app/utils/ai-resource-registry.js @@ -73,7 +73,7 @@ export const RESOURCE_CHANGES = Object.freeze({ stack: Object.freeze({start: action(), stop: action(), remove: action(), archive: action(), restore: action(), create: action(['name', 'description'], ['name']), create_from_catalog: action(['name', 'description', 'startOnCreate', 'answers'], ['name']), update_metadata: metadata}), service: Object.freeze({start: action(), stop: action(), restart: action(), remove: action(), archive: action(), restore: action(), scale: action(['scale'], ['scale']), - create: action(['name', 'image', 'scale', 'description', 'command', 'entryPoint'], ['name', 'image']), update_metadata: metadata}), + create: action(['name', 'image', 'scale', 'description', 'command', 'entryPoint', 'ports', 'healthCheck'], ['name', 'image']), update_metadata: metadata}), dnsService: Object.freeze({start: action(), stop: action(), remove: action(), update_metadata: metadata, create: action(['name', 'description'], ['name']), update_targets: action(['serviceRefs'], ['serviceRefs'])}), externalService: Object.freeze({start: action(), stop: action(), remove: action(), update_metadata: metadata, @@ -83,7 +83,7 @@ export const RESOURCE_CHANGES = Object.freeze({ create: action(['name', 'image', 'description', 'command', 'entryPoint'], ['name', 'image']), update_metadata: metadata}), }); export const CHANGE_OPERATIONS = Object.freeze([...new Set(Object.values(RESOURCE_CHANGES).flatMap((entry) => Object.keys(entry)))]); -export const RESOURCE_CHANGE_FIELDS = Object.freeze(['name', 'description', 'hostname', 'externalIpAddresses', 'targetServices', 'image', 'scale', 'command', 'entryPoint', 'stackId', 'archived', +export const RESOURCE_CHANGE_FIELDS = Object.freeze(['name', 'description', 'hostname', 'externalIpAddresses', 'targetServices', 'image', 'scale', 'command', 'entryPoint', 'ports', 'healthCheck', 'stackId', 'archived', 'state', 'operation', 'childServiceState', 'startOnCreate', 'affectedServiceCount', 'emptyStack', 'affectedInstanceCount', 'affectedMountCount', 'mountedDataRule']); // Only scalar allowlisted values cross the boundary. Nested structures can diff --git a/app/utils/ai-resource-review-labels.js b/app/utils/ai-resource-review-labels.js index b0d5f67b4a..c002eb4bdc 100644 --- a/app/utils/ai-resource-review-labels.js +++ b/app/utils/ai-resource-review-labels.js @@ -2,7 +2,7 @@ const TYPES = {certificate: 'certificatesPage.index.header', dnsService: 'servic const OPERATIONS = {update_targets: 'formTarget.target', start: 'action.start', stop: 'action.stop', restart: 'action.restart', remove: 'action.remove', create: 'saveCancel.create', create_from_catalog: 'newCatalog.saveNew', update_metadata: 'generic.edit', scale: 'serviceInfoPartial.scale', archive: 'archive.action', restore: 'archive.restore'}; const FIELDS = {targetServices: 'formTarget.target', hostname: 'formTarget.pointHostname', externalIpAddresses: 'formTarget.pointAddress', name: 'generic.name', description: 'generic.description', image: 'generic.image', scale: 'serviceInfoPartial.scale', - state: 'generic.state', stackId: 'apiKeyAccess.selector.types.stack', command: 'sidekickAddtlInfo.command', entryPoint: 'sidekickAddtlInfo.entryPoint', + state: 'generic.state', stackId: 'apiKeyAccess.selector.types.stack', command: 'sidekickAddtlInfo.command', entryPoint: 'sidekickAddtlInfo.entryPoint', ports: 'generic.ports', healthCheck: 'newContainer.tabs.healthCheck', operation: 'generic.actions', childServiceState: 'webmcp.childServiceState', affectedInstanceCount: 'webmcp.affectedInstanceCount', affectedMountCount: 'webmcp.affectedMountCount', startOnCreate: 'webmcp.startOnCreate', affectedServiceCount: 'webmcp.affectedServiceCount', emptyStack: 'webmcp.emptyStack', catalogTemplate: 'newCatalog.catalog', catalogVersion: 'newCatalog.templateVersion', serviceCount: 'apiKeyAccess.selector.types.service', @@ -11,6 +11,8 @@ const STATES = {active: 'formPorts.preflight.state.active', inactive: 'formPorts running: 'formPorts.preflight.state.running', stopped: 'formPorts.preflight.state.stopped', removed: 'webmcp.removedState', mixed: 'webmcp.mixedState', empty: 'webmcp.emptyStack', start: 'action.start', stop: 'action.stop', restart: 'action.restart', remove: 'action.remove'}; +const HEALTH_FIELDS = {port: 'port', requestLine: 'request', interval: 'interval', responseTimeout: 'timeout', healthyThreshold: 'healthyThreshold', + unhealthyThreshold: 'unhealthyThreshold', initializingTimeout: 'initializingTimeout', reinitializingTimeout: 'reinitializingTimeout', strategy: 'strategy'}; // Only an already sanitized public code selects fixed human guidance. export function resourceConfirmationErrorKey(code) { @@ -26,12 +28,25 @@ export function resourceReviewLabels(plan, translate) { if ( input === null ) { return text('webmcp.nullValue'); } if ( input === '' ) { return text('webmcp.emptyValue'); } if ( typeof input === 'boolean' ) { return text(input ? 'generic.yess' : 'generic.noo'); } + if ( field === 'healthCheck' ) { + // The command engine already checked this closed JSON value. Translate + // its labels and units while leaving the immutable review JSON intact. + try { + const check = JSON.parse(input); + return Object.keys(HEALTH_FIELDS).filter((key) => Object.prototype.hasOwnProperty.call(check, key)).map((key) => { + const name = HEALTH_FIELDS[key], unit = ['port', 'requestLine', 'strategy'].includes(key) ? '' : ` ${text(`formHealthCheck.${name}.unit`)}`; + const display = key === 'strategy' ? text(`formHealthCheck.strategy.${check[key]}`) : check[key] === '' ? text('webmcp.emptyValue') : String(check[key]); + return `${text(`formHealthCheck.${name}.label`)}: ${display}${unit}`; + }).join('\n'); + } catch (error) { return String(input); } + } if ( ['state', 'childServiceState'].includes(field) && label(STATES, input) ) { return text(label(STATES, input)); } if ( field === 'operation' && label(OPERATIONS, input) ) { return text(label(OPERATIONS, input)); } return String(input); }; return { resourceTypeLabel: text(label(TYPES, plan.resourceType)), operationLabel: text(label(OPERATIONS, plan.operation)), + executionAssignedPorts: plan.executionResult ? JSON.stringify(plan.executionResult.assignedPorts) : null, createsStopped: plan.operation === 'create' && ['service', 'container', 'externalService', 'dnsService'].includes(plan.resourceType), archiveNotices: ['archive', 'restore'].includes(plan.operation) ? [text(plan.operation === 'archive' ? 'archive.explanation' : 'archive.restoreExplanation'), text(plan.operation === 'archive' ? 'archive.requiresStopped' : 'archive.restoreBeforeStart'), text('archive.dataWarning')] : [], diff --git a/bridge/README.md b/bridge/README.md index 3628b443f0..59f0047462 100644 --- a/bridge/README.md +++ b/bridge/README.md @@ -5,15 +5,18 @@ command layer. It needs a compatible Engine with `api.ai.bridge.enabled=true`, a dedicated **AI collaboration bridge** Key and the parent repository's supported Node.js toolchain. It cannot approve its own change plans. -[Bridge **0.2.6**](https://github.com/PastureStack/web-console/releases/tag/1.6.204) -is published with Web Console 1.6.204. Verified audit-admission authentication and -Key-policy failures give safe corrective guidance while start/result ACK, -context and revision protections remain. All 13 release assets passed anonymous -byte-count/SHA256 readback. Matching Engine 0.183.365 / Server 1.6.564 assembly and native -acceptance remain pending; use the release's documented compatibility limits. - -The [0.2.6 release archive](https://github.com/PastureStack/web-console/releases/tag/1.6.204) -contains twelve typed tools for resource-family +[Bridge **0.2.7** / Web Console **1.6.205**](../docs/releases/web-console-1.6.205.md) +is a source candidate, not a published archive. It adds Service create `ports` +and `healthCheck` using the same typed command contract as the browser. Matching +Engine **0.183.366** support and a compatible Server assembly are required. +Creation uses bridge networking and starts stopped. Human approval binds the +exact review; verified native port assignments appear only in read-only +`executionResult.assignedPorts`, separately from approved changes. See the +[field contract](../docs/webmcp.md#service-create-ports-and-health-checks). +Candidate CI, publication and runtime acceptance remain pending. + +The latest published [0.2.6 release archive](https://github.com/PastureStack/web-console/releases/tag/1.6.204) +contains the same twelve typed tool names for resource-family discovery, safe metadata reads and stack/service/container lifecycle plans. Unsupported-operation replies explain that Global services follow eligible hosts rather than a manual instance count; they do not advise retrying the plan. @@ -55,7 +58,8 @@ native browser support. The operator must separately opt in to `api.ai.bridge.enabled` and, for upgrade plans, `api.ai.service.upgrade.enabled`; both Engine flags default to false. -Download the numeric release's `pasturestack-webmcp-bridge-0.2.6.zip` and its +Until 0.2.7 is published, the following download example uses published 0.2.6, +which does not include the new Service create fields. Download its archive and `.zip.sha256` checksum, then verify before extraction: ```sh @@ -79,10 +83,11 @@ records the included source hashes; the root also includes LICENSE and the bridge CycloneDX SBOM. The published 0.2.6 source proof is linked in the [release note](../docs/releases/web-console-1.6.204.md): its fresh source ZIP/SBOM and original CI are separate from carried 0.2.5 dependency/install/SDK evidence. -No new 0.2.6 install or SDK handshake is claimed. To package a source checkout: +No new 0.2.6 install or SDK handshake is claimed. To package the current 0.2.7 +source candidate, first generate a matching bridge SBOM and then run: ```sh -python scripts/package-webmcp-bridge.py --version 0.2.6 --sbom /path/to/webmcp-bridge.cdx.json --output /path/to/pasturestack-webmcp-bridge-0.2.6.zip +python scripts/package-webmcp-bridge.py --version 0.2.7 --sbom /path/to/webmcp-bridge.cdx.json --output /path/to/pasturestack-webmcp-bridge-0.2.7.zip ``` Store the following configuration outside the extracted source tree in a private diff --git a/bridge/package-lock.json b/bridge/package-lock.json index c859615ada..3ffc8bb17e 100644 --- a/bridge/package-lock.json +++ b/bridge/package-lock.json @@ -1,12 +1,12 @@ { "name": "@pasturestack/webmcp-bridge", - "version": "0.2.6", + "version": "0.2.7", "lockfileVersion": 3, "requires": true, "packages": { "": { "name": "@pasturestack/webmcp-bridge", - "version": "0.2.6", + "version": "0.2.7", "dependencies": { "@modelcontextprotocol/sdk": "1.32.2" }, diff --git a/bridge/package.json b/bridge/package.json index 33d4d2cdf0..ecd8f356e8 100644 --- a/bridge/package.json +++ b/bridge/package.json @@ -1,6 +1,6 @@ { "name": "@pasturestack/webmcp-bridge", - "version": "0.2.6", + "version": "0.2.7", "private": true, "type": "module", "description": "Isolated stdio adapter for the shared PastureStack command contract", diff --git a/bridge/server.mjs b/bridge/server.mjs index b72eea47ec..f6a8ec0ba6 100644 --- a/bridge/server.mjs +++ b/bridge/server.mjs @@ -7,7 +7,7 @@ try { const path = process.env.PASTURESTACK_BRIDGE_CONFIG; if (!path) throw new SetupError('CONFIG_REQUIRED'); const bridge = await createBridge(await loadConfig(path)); - const server = new Server({name: 'pasturestack-webmcp-bridge', version: '0.2.6'}, { + const server = new Server({name: 'pasturestack-webmcp-bridge', version: '0.2.7'}, { capabilities: {tools: {}}, instructions: 'Use names and returned opaque references. Never guess IDs. A human must approve change plans in the console. Rejected calls must be repaired only as directed; never evade permissions. Accepted/running is not success. Read the existing operation until verifiedResult=true.', }); diff --git a/docs/baselines/npm-package-lock.sass-replacement.node24-ignore-scripts.json b/docs/baselines/npm-package-lock.sass-replacement.node24-ignore-scripts.json index eb422cf6ca..63ce53299c 100644 --- a/docs/baselines/npm-package-lock.sass-replacement.node24-ignore-scripts.json +++ b/docs/baselines/npm-package-lock.sass-replacement.node24-ignore-scripts.json @@ -1,12 +1,12 @@ { "name": "@pasturestack/web-console", - "version": "1.6.204", + "version": "1.6.205", "lockfileVersion": 3, "requires": true, "packages": { "": { "name": "@pasturestack/web-console", - "version": "1.6.204", + "version": "1.6.205", "license": "Apache-2.0", "dependencies": { "sass": "1.103.1" diff --git a/docs/releases/web-console-1.6.205.md b/docs/releases/web-console-1.6.205.md new file mode 100644 index 0000000000..31009d6970 --- /dev/null +++ b/docs/releases/web-console-1.6.205.md @@ -0,0 +1,66 @@ +# Web Console 1.6.205 / bridge 0.2.7 source candidate + +This source candidate extends the existing twelve typed tools with Service +create ports and health checks. It is not published or deployed. Matching +Engine **0.183.366** support is required; compatible Server assembly and runtime +acceptance remain pending. Published Web Console 1.6.204 / bridge 0.2.6 does not +include this extension. + +## Service creation + +`preview_resource_change` accepts Service create `ports` as up to 64 native +PortSpec strings and a closed `healthCheck` object. Native validation handles +port numbers, bindings and IPv4/IPv6. Bare `80` or `80/tcp` requests random +public-port assignment; `[]` publishes no ports. The service uses +`networkMode: "bridge"` and `startOnCreate: false`. Starting it requires a +separate approved plan. + +Health checks require a container port and support the documented request line, +timings, thresholds and `none`/`recreate` strategy. Timings use milliseconds; +thresholds count checks. The review retains exact JSON port strings and shows +localized health-check labels and units in all thirteen locales. Full bounds +and examples are in the [field contract](../webmcp.md#service-create-ports-and-health-checks). +Existing service configuration changes retain the normal upgrade workflow. + +Human approval binds the exact displayed path and changes. A changed review +invalidates confirmation. After apply, a verified successful operation may +expose read-only `executionResult.assignedPorts` in the tool result and human +dialog. This receipt is separate from the immutable approved `changes`; it +does not approve new settings or imply startup. Accepted, running and unknown +results still require reading the existing operation. + +Browser and stdio use the same command sources with protocol version `1.0`. +Build ceilings, page startup in off mode, current actor/Key limits, durable +audit acknowledgements and human confirmation retain their existing behavior. + +## Source validation + +Focused checks already passed on the implementation before version/document +synchronization: + +- Service create and resource lifecycle scripts: 36 cases, including 9 Service + create cases. These use controlled transport fixtures. +- Human dialog/service integration: 2 Service create cases, including the + confirmation, apply, operation, pending-plan and dialog result chain. +- Review labels: 6 cases, including field and unit labels in all 13 locales. + +These counts are component evidence, not native platform or browser acceptance. +The new Service create script is included in the existing full CI entry point +and bridge source archive allowlist. It must run again against the immutable +release producer commit in CI. + +## Qualification and publication still required + +Package versions, bridge handshake, packager and the active release/test lock +baseline are synchronized. Dependency graphs are unchanged; this does not +constitute a fresh dependency scan, bridge installation or SDK handshake. +No candidate artifact, digest, SBOM qualification or producer SHA is claimed. + +Use the existing full/enabled CI and required security checks on one immutable +source commit. Retain the original producer artifacts, archive/manifest/SBOM +verification and WebMCP sidecar; the reviewed merge and numeric tag must retain +the tested source tree. Package the matching bridge exact sources and SBOM, +then verify the published assets' actual bytes. Publication must not rebuild +the qualified Web Console component. Compatible Engine/Server assembly and +designated native/browser, role/Key, cross-ID, weak-model and cleanup acceptance +require their own evidence. diff --git a/docs/webmcp.md b/docs/webmcp.md index 1e0ecfee3e..e8781c16d5 100644 --- a/docs/webmcp.md +++ b/docs/webmcp.md @@ -6,11 +6,12 @@ Ordinary console actions and general-purpose Keys retain their existing behavior ## Tools and workflow -[Web Console 1.6.202 / bridge 0.2.4](releases/web-console-1.6.202.md) is published -and retains the twelve tools below. New External Service, DNS Alias and audit -query workflows require matching Engine 0.183.361 / broker components. Web -component qualification passed; combined Server and live workflow acceptance -remain pending. +[Web Console 1.6.205 / bridge 0.2.7](releases/web-console-1.6.205.md) is a source +candidate with the twelve tools below. Service create ports and health checks +require matching Engine 0.183.366 support. Candidate qualification, publication, +compatible Server assembly and live workflow acceptance remain pending. External +Service, DNS Alias and audit queries retain their matching Engine/broker +requirements. | Tool | Purpose | | --- | --- | @@ -48,8 +49,9 @@ metadata edits; service start/stop/restart/remove/scale/create and metadata edit and container start/stop/restart/remove/create and metadata edits. A service create takes a stack reference. New services and containers are created stopped; starting them requires a separate approved plan. Parameters contain only the -listed name, description, image, scale and create-time command/entryPoint fields, -never arbitrary launch configuration. Command arrays allow at most 64 strings, +listed name, description, image, scale and create-time command/entryPoint fields; +Service create additionally accepts `ports` and `healthCheck` as described below. +Arbitrary launch configuration is not accepted. Command arrays allow at most 64 strings, 4096 UTF-16 units per string and 16384 in total; NUL is rejected. The human review shows their actual escaped JSON, including empty and null values. @@ -64,6 +66,37 @@ Engine/broker owner; raw audit payloads and export remain human-only. Catalog metadata and its bounded launch adapter are described below. No tool accepts raw IDs, URLs, HTTP methods or caller-selected output fields. +### Service create ports and health checks + +Choose the intended Stack's opaque `parentRef`, then preview +`resourceType: "service"`, `operation: "create"` with its name, image and optional settings. +`ports` is an array of at most 64 native PortSpec strings, each 1 through 128 +UTF-16 units, for example `["8080:80/tcp", "53:53/udp", "80/tcp"]`. An omitted +public port, including bare `80` or `80/tcp`, requests native random public-port +allocation. Native IPv4/IPv6 bindings and port validation remain server-owned; +do not convert these strings into port objects. CR, LF and NUL are rejected. +`[]` publishes no ports. + +`healthCheck` requires container `port` (1 through 65535). Its optional fields are +`requestLine`, `responseTimeout`, `interval`, `healthyThreshold`, +`unhealthyThreshold`, `initializingTimeout`, `reinitializingTimeout` and +`strategy`. Omit or use an empty request line for TCP; an HTTP example is +`GET /health HTTP/1.0`. The request line is at most 1024 UTF-16 units and rejects +CR, LF and NUL. Timings use milliseconds and thresholds count checks. +The integer maximum is 2147483647; initialization timeouts may be zero and the +other timing/threshold values must be positive. Strategy is `none` or `recreate` +(the native default). Omit `healthCheck` for no check. Null, extra headers, +credentials and quorum strategy configuration are not accepted. + +The service uses `networkMode: "bridge"` and `startOnCreate: false`; start it +with a separate approved plan. Existing Service settings use the normal upgrade +workflow. Human review shows port strings unchanged and health-check labels +with their units. Approval is invalid if those reviewed settings change. +After apply, use `get_operation` until success is verified. Only a verified +successful Service create may return read-only `executionResult.assignedPorts`; +those native assignments are shown separately and never amend the approved +`changes`. An accepted or unknown result is not completion. + ## Browser and human controls Build with `WEBMCP_MODE=read-only` or `WEBMCP_MODE=enabled` to include the @@ -144,6 +177,10 @@ For the resource-family and lifecycle changes, run `node --test scripts/test-webmcp-resources.mjs`, `node scripts/test-ai-collaboration-ui.js --filter="resource plan"`, and `node --test --test-name-pattern="bounded stdio create arrays" bridge/test/stdio.test.mjs`. +For the Service create extension, also run +`node --test scripts/test-webmcp-service-create.mjs`, +`node scripts/test-ai-collaboration-ui.js --filter="service create"` and +`node --test scripts/test-ai-resource-review-labels.mjs`. The stdio request frame is bounded at 256 KiB; the platform HTTP response body has a separate 1 MiB limit. Oversize failures never print request payloads. diff --git a/package-lock.json b/package-lock.json index eb422cf6ca..63ce53299c 100644 --- a/package-lock.json +++ b/package-lock.json @@ -1,12 +1,12 @@ { "name": "@pasturestack/web-console", - "version": "1.6.204", + "version": "1.6.205", "lockfileVersion": 3, "requires": true, "packages": { "": { "name": "@pasturestack/web-console", - "version": "1.6.204", + "version": "1.6.205", "license": "Apache-2.0", "dependencies": { "sass": "1.103.1" diff --git a/package.json b/package.json index ea0b6b939d..8ed60df42b 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "@pasturestack/web-console", - "version": "1.6.204", + "version": "1.6.205", "private": true, "description": "PastureStack browser console for the compatible control platform.", "repository": { diff --git a/scripts/ci b/scripts/ci index 85b1a44ced..8f6bf841b3 100755 --- a/scripts/ci +++ b/scripts/ci @@ -11,7 +11,7 @@ fi ./scripts/check-modernization-blockers ./scripts/check-ui-ember-api-store-fetch-upgrade node --test scripts/test-webmcp-path-boundaries.mjs -node --test scripts/test-ai-catalog-reader.mjs scripts/test-webmcp-catalog.mjs scripts/test-webmcp-catalog-launch.mjs scripts/test-webmcp-archive.mjs scripts/test-webmcp-resources.mjs +node --test scripts/test-ai-catalog-reader.mjs scripts/test-webmcp-catalog.mjs scripts/test-webmcp-catalog-launch.mjs scripts/test-webmcp-archive.mjs scripts/test-webmcp-resources.mjs scripts/test-webmcp-service-create.mjs node --test scripts/test-webmcp-external-service.mjs node --test scripts/test-webmcp-alias-service.mjs node --test scripts/test-webmcp-certificate-metadata.mjs diff --git a/scripts/package-webmcp-bridge.py b/scripts/package-webmcp-bridge.py index 3a910891fb..df10fdc5cd 100644 --- a/scripts/package-webmcp-bridge.py +++ b/scripts/package-webmcp-bridge.py @@ -11,7 +11,7 @@ import zipfile -VERSION = "0.2.6" +VERSION = "0.2.7" SOURCE_FILES = ( "LICENSE", "app/utils/ai-command-context.js", @@ -35,6 +35,7 @@ "bridge/test/resources.test.mjs", "bridge/test/stdio.test.mjs", "scripts/test-webmcp-resources.mjs", + "scripts/test-webmcp-service-create.mjs", "scripts/test-webmcp-manual-scale.mjs", "bridge/test/catalog.test.mjs", "scripts/test-ai-catalog-reader.mjs", diff --git a/scripts/test-ai-collaboration-ui.js b/scripts/test-ai-collaboration-ui.js index d8b5118bad..074f67872d 100644 --- a/scripts/test-ai-collaboration-ui.js +++ b/scripts/test-ai-collaboration-ui.js @@ -224,6 +224,98 @@ async function main() { assert.equal((await f.service.confirmPendingPlan()).code, 'CONTEXT_CHANGED'); }); + await test('service create review binds ports and healthCheck to the exact human confirmation', async () => { + const dto = {...resourcePlan(), resourceType: 'service', resourceId: null, operation: 'create', changes: [ + {field: 'ports', before: null, after: '["8080:80/tcp"]'}, + {field: 'healthCheck', before: null, after: '{"port":80,"interval":2000,"strategy":"recreate"}'}, + ]}; + for (const field of ['ports', 'healthCheck']) { + const f = fixture('off'); f.service.reviewInboxPlan(dto); + const reviewed = f.service.pendingPlan; + const modal = {get, plan: reviewed, commands: f.service}; + assert.equal(confirmationDefinition.stale.call(modal), false); + const changed = structuredClone(dto); + changed.changes.find(item => item.field === field).after = field === 'ports' ? '["8081:80/tcp"]' : '{"port":81,"interval":2000,"strategy":"recreate"}'; + f.service.publishPlan({...reviewed, ...f.service.engine.planSummary(changed, reviewed.planRef)}); + assert.equal(confirmationDefinition.stale.call(modal), true); + assert.equal((await f.service.confirmPendingPlan(reviewed)).code, 'CONFLICT'); assert.equal(f.requests.length, 0); + f.service.reviewInboxPlan(dto); + const original = f.service.pendingPlan; + f.service.userStore.rawRequest = async options => { f.requests.push(options); return {body: {...changed, confirmationState: 'approved'}}; }; + assert.equal((await f.service.confirmPendingPlan(original)).code, 'CONFLICT'); + assert.equal(f.service.pendingPlan.confirmationState, 'pending'); assert.equal(f.requests.length, 1); + } + }); + + await test('service create verified receipt reaches the live confirmation modal and ignores stale completions', async () => { + for (const scenario of ['complete', 'context-changed', 'newer-plan']) { + const f = fixture('enabled'), entered = deferred(), barrier = deferred(), requests = []; + let dto = {...resourcePlan(), resourceType: 'service', resourceId: null, operation: 'create', changes: [ + {field: 'name', before: null, after: 'web'}, {field: 'ports', before: null, after: '["80/tcp"]'}, + {field: 'healthCheck', before: null, after: '{"port":80,"strategy":"recreate"}'}, + ]}; + const transport = async request => { + requests.push(request); + if (request.url === 'projects/project/aiResourceChangePlans') return {body: structuredClone(dto)}; + if (request.url.endsWith('?action=confirm')) { dto = {...dto, confirmationState: 'approved'}; return {body: structuredClone(dto)}; } + if (request.url.endsWith('?action=apply')) { + assert.equal(dto.confirmationState, 'approved'); dto = {...dto, status: 'accepted'}; return {body: structuredClone(dto)}; + } + if (request.url.endsWith('/' + dto.id)) { + entered.resolve(); await barrier.promise; + return {body: {...structuredClone(dto), status: 'succeeded', verifiedResult: true, executionResult: {assignedPorts: ['32768:80/tcp']}}}; + } + throw Error('Unexpected service-create receipt route'); + }; + f.service.engine = new CommandEngine({context: f.context, request: transport, ensureSession: async () => {}, wait: async () => {}, + audit: async () => ({accepted: true, requestId: 'receipt-audit'}), onPlan: (plan, expected) => f.service.publishPlan(plan, expected), + onOperation: operation => f.service.clearCompletedPlan(operation)}); + const parentRef = f.context.reference('resource', {id: 'stack', family: 'stack', resourceType: 'stack', scope: 'project'}, f.context.capture()); + const preview = await f.service.execute('preview_resource_change', {resourceType: 'service', operation: 'create', parentRef, + parameters: {name: 'web', image: 'nginx:1.28', ports: ['80/tcp'], healthCheck: {port: 80}}}); + assert.equal(preview.status, 'needs_user'); + const originalDiff = structuredClone(f.service.pendingPlan.displayDiff); + const modal = {get, setProperties, commands: f.service, intl: {t: key => key}, approved: false, submitDisabled: false, + modalService: {modalOpts: {plan: f.service.pendingPlan}}, clearHumanInputs() {}, + get plan() { return this.modalService.modalOpts.plan; }, + set(key, value) { if (key === 'modalService.modalOpts.plan') this.modalService.modalOpts.plan = value; else this[key] = value; }, + }; + await confirmationDefinition.actions.confirm.call(modal); + assert.equal(modal.approved, true); assert.equal(f.service.pendingPlan.confirmationState, 'approved'); + const accepted = await f.service.execute('apply_resource_change', {planRef: preview.planRef}); + assert.equal(accepted.status, 'accepted'); + const pending = f.service.execute('get_operation', {operationRef: accepted.operationRef}); await entered.promise; + if (scenario === 'context-changed') f.snapshot.generation = 'replacement-session'; + if (scenario === 'newer-plan') f.service.reviewInboxPlan(resourcePlan('2')); + const beforeCompletion = f.service.pendingPlan; + barrier.resolve(); const completed = await pending; + confirmationDefinition.pendingChanged.call(modal); + if (scenario === 'complete') { + assert.equal(completed.status, 'succeeded'); assert.equal(completed.verifiedResult, true); + assert.equal(f.service.pendingPlan.planRef, preview.planRef); assert.equal(f.service.pendingPlan.confirmationState, 'approved'); + assert.deepEqual(f.service.pendingPlan.displayDiff, originalDiff); assert.notEqual(f.service.pendingPlan, beforeCompletion); + assert.equal(modal.modalService.modalOpts.plan, f.service.pendingPlan); + const reviewLabels = confirmationDefinition.reviewLabels.call(modal); + assert.equal(reviewLabels.executionAssignedPorts, '["32768:80/tcp"]'); + const Handlebars = require('handlebars').create(); + Handlebars.registerHelper('t', key => key); Handlebars.registerHelper('action', () => ''); + Handlebars.registerHelper('or', (left, right) => left || right); Handlebars.registerHelper('top-errors', () => ''); + const html = Handlebars.compile(fs.readFileSync(path.join(app, 'components/modal-confirm-ai-upgrade/template.hbs'), 'utf8'))({ + plan: modal.plan, reviewLabels, isResourceChange: true, isCatalogLaunch: false, alreadyApproved: true, submitDisabled: true, + }); + assert.match(html, /