diff --git a/.github/workflows/rebase-translations.yml b/.github/workflows/rebase-translations.yml index 1fc1dd5..37f5daa 100644 --- a/.github/workflows/rebase-translations.yml +++ b/.github/workflows/rebase-translations.yml @@ -34,7 +34,7 @@ jobs: steps: - name: Rebase open translation PRs - uses: QuantEcon/action-translation@v0.16.1 + uses: QuantEcon/action-translation@v0 with: mode: rebase anthropic-api-key: ${{ secrets.ANTHROPIC_API_KEY }} diff --git a/.github/workflows/review-translations.yml b/.github/workflows/review-translations.yml index 0380800..af37bbf 100644 --- a/.github/workflows/review-translations.yml +++ b/.github/workflows/review-translations.yml @@ -1,47 +1,44 @@ # Review Translations — Quality check on translation PRs # When a PR is opened/updated that carries the 'action-translation' label, # this workflow runs a quality review and posts a comment. +# +# Mirrors the upstream template in action-translation +# docs/user/tutorials/connect-existing.md — keep it in step with that. name: Review Translations on: pull_request: types: [opened, synchronize, labeled, reopened] -# Serialise reviews per PR. -# -# The sync action creates the PR and then applies its labels in a separate call, -# so a single sync fires `opened` plus one `labeled` event per label, all within -# a couple of seconds. Every one of those starts a full review, and the action's -# "update the existing comment, else create one" logic is a check-then-act with -# no lock — concurrent runs all observe "no comment yet" and each create one. -# That is how PR #6 collected two independent review comments. -# -# cancel-in-progress is deliberately false. The labels are applied in one API -# call, so event ordering is not guaranteed; if 'automated' arrived last it would -# cancel the in-flight review for 'action-translation' and then skip its own job -# via the filter below, leaving no review at all. Queuing instead means the first -# run creates the comment and any later run updates it — one comment, always. -concurrency: - group: review-translations-${{ github.event.pull_request.number }} - cancel-in-progress: false - jobs: review: - # Require the 'action-translation' label, and — for `labeled` events — ignore - # labels other than that one. Without the second clause the 'automated' label - # fires a second, redundant review of the identical diff. - if: >- + # Ignore `labeled` events for every other label: a sync adds its labels in a single + # addLabels call, but GitHub emits one `labeled` event per label, and each would + # otherwise start a full (billed) review of the same diff. + if: > contains(github.event.pull_request.labels.*.name, 'action-translation') && - (github.event.action != 'labeled' || - github.event.label.name == 'action-translation') + (github.event.action != 'labeled' || github.event.label.name == 'action-translation') runs-on: ubuntu-latest + # v0.17.0's review dedupe deletes superseded comments, which needs pull-requests: write. + permissions: + contents: read + pull-requests: write + + # One review per PR — supersede an in-flight review instead of running both. + # Job-level (not workflow-level) on purpose: the group is entered only after the `if` + # above has passed, so a `labeled` event for 'automated' skips out without cancelling + # the real review. At workflow level it would cancel first and skip second, leaving none. + concurrency: + group: review-translations-${{ github.event.pull_request.number }} + cancel-in-progress: true + steps: - uses: actions/checkout@v6 with: fetch-depth: 2 - - uses: QuantEcon/action-translation@v0.16.1 + - uses: QuantEcon/action-translation@v0 with: mode: review source-repo: QuantEcon/lecture-python-programming