[DATA REQUEST] Add county-level CONUS shapefile to this repo

[jvcarag]

Certain procedures in this repo require a county-level CONUS shapefile to perform geospatial lat/long-to-county matching (example below maps pumped-hydro sites to their corresponding counties). Currently the procedure pulls this shapefile from a separate ReEDS repository.

ReEDS_Input_Processing/psh/calculate_existing_psh_capacities.py

Lines 51 to 60 in b57ce18

	reeds_path = os.path.expanduser('~/github/ReEDS')
	outdir_path = os.path.join(reeds_path, 'inputs', 'storage')
	dfcounty = gpd.read_file(
	os.path.join(
	reeds_path,
	'inputs',
	'shapefiles',
	'US_COUNTY_2022'
	)
	)

Could we add this required county-level shapefile to the shapefiles/ folder in this repository so this and other future procedures no longer pull data from external sources?

[patrickbrown4]

Sorry, I think I removed these but didn't catch all the places they were used.
It's now accomplished via the reeds.spatial.get_map('county') function, which downloads the TIGER/Line shapefile to {reeds_path}/inputs/shapefiles/cache the first time it's called and then reads from that downloaded file thereafter. So you should be able to just replace these lines with

import reeds
dfcounty = reeds.spatial.get_map('county')

There are sometimes self-signed certificate errors with python downloads, and I haven't yet figured out a general solution to them - let me know those cause issues (or if you've figured out how to fix them and I can copy your fix!)

[jvcarag]

Thanks for the suggestion @patrickbrown4 : based on how ReEDS is imported in your code suggestion, is it proper to clone this ReEDS_Input_Processing repo to the same location as the ReEDS repo I want to use?

[patrickbrown4]

We don't yet have a generalized approach, but most of the rest of the scripts use some variation of:

sys.path.append(os.path.expanduser('~/github/ReEDS'))
import reeds

[jvcarag]

Thanks so much! I'll be updating the procedures in the psh folder and will close this Issue with the upcoming PR