Skip to content

Why do you have two CompletableFuture examples for challenge 1? #4

Description

@TexasFred

Hi there,

I just discovered your repo. You've got interesting stuff there! Congrats!!!

While reading the examples I found two examples for challenge 1 using Java and CompletableFuture

https://github.com/ReactiveMeetupLucerne/AsyncNonBlockingExamplesJVM/blob/master/src/main/java/challenge1/java8/CompletableFutureExample.java

and

https://github.com/ReactiveMeetupLucerne/AsyncNonBlockingExamplesJVM/blob/master/src/main/java/challenge1/java8/GmoCompletableFutureDemo.java

Why do you have two examples? The first one seems a bit non-idomatic regarding collecting the prices in a synchronized method, this smells like "shared mutual state"...

What do you think?

Best regards,
Fred

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions