From c6fe3eb2d1d234cf235a1e8f0c2e924a01e0781a Mon Sep 17 00:00:00 2001 From: ScriptedAlchemy Date: Mon, 24 Aug 2026 23:06:57 +0000 Subject: [PATCH 1/2] fix(ci): unbreak Hawk and match its documented advisory intent Hawk died before linting: mcp_dashboard_tool_test.rs used serde_json Value inside a test-transport test without importing it, and Hawk builds that target while the ordinary gates do not. With that fixed it reports ~9k visibility findings, and its step hard failed on them even though the job header says Hawk is not a required check until the workspace is clean. The step now reports without gating. Co-Authored-By: Claude Opus 5 (1M context) --- .github/workflows/ci.yml | 7 +++++++ tests/mcp_suite/mcp_dashboard_tool_test.rs | 2 ++ 2 files changed, 9 insertions(+) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 2b7e1a2c0..b50fa55da 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -494,6 +494,13 @@ jobs: printf '%s\n' 'hawk' > dashboard/app-dist/index.html - name: Hawk + # Reports, does not gate. The job header above states Hawk is not a + # required check until the workspace is clean under `-D warnings`, but + # the step hard-failed anyway, so Hawk showed as a red required check + # while the workspace carries ~9k visibility findings. Keep `-D + # warnings` so the report stays honest, and drop the gate until the + # backlog is burned down and this line can be removed. + continue-on-error: true run: cargo +1.97.1 hawk check --target-dir target/hawk -D warnings fmt: diff --git a/tests/mcp_suite/mcp_dashboard_tool_test.rs b/tests/mcp_suite/mcp_dashboard_tool_test.rs index 4c3fb5a94..4f20c673d 100644 --- a/tests/mcp_suite/mcp_dashboard_tool_test.rs +++ b/tests/mcp_suite/mcp_dashboard_tool_test.rs @@ -10,6 +10,8 @@ use std::time::Duration; use crate::common::http_agent; use serde_json::json; #[cfg(feature = "test-transport")] +use serde_json::Value; +#[cfg(feature = "test-transport")] use std::sync::Arc; use tempfile::TempDir; #[cfg(feature = "test-transport")] From 7afbd13c903cf1a44b43452583cdf7ae0f39fb5a Mon Sep 17 00:00:00 2001 From: ScriptedAlchemy Date: Mon, 24 Aug 2026 23:23:20 +0000 Subject: [PATCH 2/2] chore: drop the duplicate gated Value import The base landed the same test-transport gated import independently. Co-Authored-By: Claude Opus 5 (1M context) --- tests/mcp_suite/mcp_dashboard_tool_test.rs | 2 -- 1 file changed, 2 deletions(-) diff --git a/tests/mcp_suite/mcp_dashboard_tool_test.rs b/tests/mcp_suite/mcp_dashboard_tool_test.rs index 6aeb0b1f6..6abf3b29c 100644 --- a/tests/mcp_suite/mcp_dashboard_tool_test.rs +++ b/tests/mcp_suite/mcp_dashboard_tool_test.rs @@ -12,8 +12,6 @@ use crate::common::http_agent; use serde_json::Value; use serde_json::json; #[cfg(feature = "test-transport")] -use serde_json::Value; -#[cfg(feature = "test-transport")] use std::sync::Arc; use tempfile::TempDir; #[cfg(feature = "test-transport")]