From bc031021a5daab753ccb226f1bef35f9c06f6827 Mon Sep 17 00:00:00 2001 From: Will Zhao Date: Thu, 30 Jul 2026 18:01:08 -0700 Subject: [PATCH] ci: replace the dead live smoke test with the unit tests, fix CODEOWNERS The GitHub Actions Test job ran the action for real against secrets.LOGGIA_*, and the API now answers "Batch test run not found": the suite and environment those secrets point at belong to Shiplight Cloud v1 and no longer exist. There is nowhere to repoint it. This action only speaks to the v1 API, and the current platform's CI path does not involve this action at all, so no v2 equivalent exists. Removed the job and enabled the unit tests that were sitting commented out in the same workflow. They pass (3 tests, covering token validation and test-context parsing) and they need no live backend, so CI is green and testing something real rather than red and testing nothing. Also dropped the workflow's permissions from write-all to contents: read, which is all the remaining job needs now that nothing comments on pull requests. CODEOWNERS still carried the actions/typescript-action template default, @actions/actions-oss-maintainers, a team that does not exist in this org, so review requests silently went nowhere. Now @feng-shiplight. Co-Authored-By: Claude Opus 5 (1M context) --- .github/workflows/ci.yml | 31 +++++-------------------------- CODEOWNERS | 2 +- 2 files changed, 6 insertions(+), 27 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 0b0d856..a4505e9 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -9,7 +9,8 @@ on: - main - master -permissions: write-all +permissions: + contents: read jobs: test-typescript: @@ -40,28 +41,6 @@ jobs: id: npm-lint run: npm run lint - # - name: Test - # id: npm-ci-test - # run: npm run ci-test - - test-action: - name: GitHub Actions Test - runs-on: ubuntu-latest - - steps: - - name: Checkout - id: checkout - uses: actions/checkout@v4 - - - name: Test Local Action - id: test-action - uses: ./ - with: - api-token: ${{ secrets.LOGGIA_API_TOKEN }} - test-suite-id: ${{ secrets.LOGGIA_TEST_SUITE_ID }} - environment-id: ${{ secrets.LOGGIA_ENVIRONMENT_ID }} - environment-url: ${{ secrets.LOGGIA_TEST_SUITE_ENVIRONMENT_URL }} - - - name: Print Output - id: output - run: echo "${{ steps.test-action.outputs.time }}" + - name: Test + id: npm-ci-test + run: npm run ci-test diff --git a/CODEOWNERS b/CODEOWNERS index da17f53..9e79d94 100644 --- a/CODEOWNERS +++ b/CODEOWNERS @@ -4,4 +4,4 @@ ############################################################################ # Default owners, unless a later match takes precedence. -* @actions/actions-oss-maintainers +* @feng-shiplight