From ef2a4aa8a8e36ac8352a2b0351f255b71a755d88 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Val=C3=A9rian=20Rey?= Date: Wed, 7 Oct 2026 17:31:00 +0200 Subject: [PATCH] Drop redundant projector_or_default call in weightings The `projector` setters of UPGradWeighting and DualProjWeighting already apply `projector_or_default`, so `__init__` does not need to apply it too. Co-Authored-By: Claude Opus 5.5 --- src/torchjd/aggregation/_dualproj.py | 2 +- src/torchjd/aggregation/_upgrad.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/torchjd/aggregation/_dualproj.py b/src/torchjd/aggregation/_dualproj.py index 84206b476..a9a4172ac 100644 --- a/src/torchjd/aggregation/_dualproj.py +++ b/src/torchjd/aggregation/_dualproj.py @@ -29,7 +29,7 @@ def __init__( ) -> None: super().__init__() self.pref_vector = pref_vector - self.projector = projector_or_default(projector) + self.projector = projector def forward(self, gramian: PSDMatrix, /) -> Tensor: u = self.weighting(gramian) diff --git a/src/torchjd/aggregation/_upgrad.py b/src/torchjd/aggregation/_upgrad.py index 133bb0145..caafe5b80 100644 --- a/src/torchjd/aggregation/_upgrad.py +++ b/src/torchjd/aggregation/_upgrad.py @@ -30,7 +30,7 @@ def __init__( ) -> None: super().__init__() self.pref_vector = pref_vector - self.projector = projector_or_default(projector) + self.projector = projector def forward(self, gramian: PSDMatrix, /) -> Tensor: U = torch.diag(self.weighting(gramian))