Skip to content

Android support gradle 8 #73

Description

@NoatToan

Hi! 👋

Firstly, thanks for your work on this project! 🙂

Today I used patch-package to patch react-native-extra-dimensions-android@1.2.5 for the project I'm working on.

Here is the diff that solved my problem:

diff --git a/node_modules/react-native-extra-dimensions-android/android/build.gradle b/node_modules/react-native-extra-dimensions-android/android/build.gradle
index c470e07..f653760 100644
--- a/node_modules/react-native-extra-dimensions-android/android/build.gradle
+++ b/node_modules/react-native-extra-dimensions-android/android/build.gradle
@@ -10,6 +10,7 @@ def DEFAULT_TARGET_SDK_VERSION = 26
 def DEFAULT_SUPPORT_LIB_VERSION = "27.0.2"
 
 android {
+    namespace "ca.jaysoo.extradimensions"
     compileSdkVersion rootProject.hasProperty('compileSdkVersion') ? rootProject.compileSdkVersion : DEFAULT_COMPILE_SDK_VERSION
     buildToolsVersion rootProject.hasProperty('buildToolsVersion') ? rootProject.buildToolsVersion : DEFAULT_BUILD_TOOLS_VERSION
 
diff --git a/node_modules/react-native-extra-dimensions-android/android/src/main/AndroidManifest.xml b/node_modules/react-native-extra-dimensions-android/android/src/main/AndroidManifest.xml
index cc0f8ba..5fbaa4c 100644
--- a/node_modules/react-native-extra-dimensions-android/android/src/main/AndroidManifest.xml
+++ b/node_modules/react-native-extra-dimensions-android/android/src/main/AndroidManifest.xml
@@ -1,3 +1,3 @@
 <manifest xmlns:android="http://schemas.android.com/apk/res/android"
-          package="ca.jaysoo.extradimensions">
+          >
 </manifest>

This issue body was partially generated by patch-package.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions