perf: skip Jira client init when no keys are present

extract_jira_tickets() built the Jira client before checking whether the
text contained any Jira keys. Since add_jira_tickets() runs for every
provider, a configured-but-unreferenced Jira would construct a client (and
log an init failure if misconfigured) on every keyless PR.

Extract keys first and return early when there are none, so the client is
only built when there is something to fetch.

Co-Authored-By: Claude

Author: dellch

pr_agent/tools/ticket_pr_compliance_check.py

@@ -82,8 +82,15 @@ def extract_jira_tickets(text, max_characters=MAX_TICKET_CHARACTERS):
     """
     Find Jira ticket keys in the given text and fetch their content. Returns a list of
     ticket dicts in the same shape used by the rest of the ticket-analysis flow. Returns
-    an empty list when Jira is not configured or no keys are found.
+    an empty list when no keys are found or when Jira is not configured.
     """
+    # Look for keys before building a client: most PRs have none, and building the
+    # client first would do needless work (and log a noisy init failure if Jira is
+    # misconfigured) even when there is nothing to fetch.
+    keys = find_jira_tickets(text or "")
+    if not keys:
+        return []
+
     jira_client = _get_jira_client()
     if jira_client is None:
         return []
@@ -93,7 +100,6 @@ def extract_jira_tickets(text, max_characters=MAX_TICKET_CHARACTERS):
     # instance-specific (e.g. "customfield_10127"), so it must be configured; empty
     # means no requirements are extracted.
     requirements_field = get_settings().get("JIRA.JIRA_REQUIREMENTS_FIELD", "") or ""
-    keys = find_jira_tickets(text or "")
     if len(keys) > MAX_TICKETS:
         get_logger().info(f"Too many Jira tickets found: {len(keys)}; limiting to {MAX_TICKETS}")
         keys = keys[:MAX_TICKETS]

tests/unittest/test_jira_ticket_extraction.py

@@ -110,6 +110,15 @@ def test_returns_empty_when_not_configured(self):
         self._disable_jira()
         assert extract_jira_tickets("bugfix/abc-123-x") == []
 
+    def test_no_client_built_when_no_keys(self):
+        """No Jira keys in the text -> return early without constructing a client, so a
+        keyless PR pays no client-init cost (or noisy init-failure log)."""
+        self._configure_jira()
+        with patch("pr_agent.tools.ticket_pr_compliance_check.Jira") as jira_cls:
+            result = extract_jira_tickets("nothing ticket-like here")
+        assert result == []
+        jira_cls.assert_not_called()
+
     def test_fetches_lowercase_branch_key(self):
         """The whole point: a lowercased branch key is detected and fetched as upper."""
         self._configure_jira()