Skip to content

Implement the use-system-libuv build option that uvloop supports #39

Description

@owenlamont

This is a follow up to the discussion on: #38

I was trying to package Winloop as a conda-forge package but I had issues with the statically linked libuv since conda-forge strongly discourages vendoring libraries (especially when that dependency already exists as a conda-forge package - which libuv does).

I inspected how uvloops conda-forge package was implemented and discovered uvloop has a use-system-libuv build option that lets it link dynamically against the DLL compiled libuv in the conda-forge package.

So this is an enhancement request to implement the same build option uvloop does to add extra flexibility for linking with libuv.

I left the conda-forge PR open to add winloop with the vendored libuv for now... but I'm not sure whether it'll be accepted or not. If dynamic linking could be optionally enabled it would resolve a lot of problems for deploying winloop there (and perhaps other places).

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions