From 0a0875ac7d17b03f5e58b4a8e9d062cd1a783cd1 Mon Sep 17 00:00:00 2001 From: Sukhada Kulkarni Date: Fri, 20 Mar 2026 15:21:25 -1000 Subject: [PATCH] ci: use repository variables instead of hardcoded env block MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Replace hardcoded env values in ci-cd.yml with repository variables (vars.*). This allows the same values to be shared across multiple workflow files without duplication and drift. Repository variables to set in GitHub Settings → Variables: GCP_REGION, GAR_REGISTRY, GKE_CLUSTER, GKE_LOCATION, STAGING_NAMESPACE, STAGING_DEPLOYMENT, WIF_PROVIDER, WIF_SERVICE_ACCOUNT Co-Authored-By: Claude Opus 4.6 (1M context) --- .github/workflows/ci-cd.yml | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/.github/workflows/ci-cd.yml b/.github/workflows/ci-cd.yml index 4e697fc92..dc3c894f2 100644 --- a/.github/workflows/ci-cd.yml +++ b/.github/workflows/ci-cd.yml @@ -4,14 +4,14 @@ on: push: env: - GCP_REGION: us-west1 - GAR_REGISTRY: us-west1-docker.pkg.dev/spoke-407503/spoke/core - GKE_CLUSTER: spoke-cluster - GKE_LOCATION: us-west1-a - STAGING_NAMESPACE: spoke-staging - STAGING_DEPLOYMENT: main-spoke - WIF_PROVIDER: projects/630731592917/locations/global/workloadIdentityPools/github-actions/providers/github - WIF_SERVICE_ACCOUNT: spoke-ci@spoke-407503.iam.gserviceaccount.com + GCP_REGION: ${{ vars.GCP_REGION }} + GAR_REGISTRY: ${{ vars.GAR_REGISTRY }} + GKE_CLUSTER: ${{ vars.GKE_CLUSTER }} + GKE_LOCATION: ${{ vars.GKE_LOCATION }} + STAGING_NAMESPACE: ${{ vars.STAGING_NAMESPACE }} + STAGING_DEPLOYMENT: ${{ vars.STAGING_DEPLOYMENT }} + WIF_PROVIDER: ${{ vars.WIF_PROVIDER }} + WIF_SERVICE_ACCOUNT: ${{ vars.WIF_SERVICE_ACCOUNT }} jobs: hadolint: