From ecdbdb71bab6dee2d9b1f1f3ac9d7469fe1d6cae Mon Sep 17 00:00:00 2001 From: Raul Salvat Date: Tue, 11 Aug 2026 22:56:46 -0400 Subject: [PATCH 1/2] Customize: Use `assertIsCallable()` for callable assertions. Replaces generic `assertTrue( is_callable() )` assertions in the Customize widgets tests with the dedicated PHPUnit assertion. See #65819. --- tests/phpunit/tests/customize/widgets.php | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/tests/phpunit/tests/customize/widgets.php b/tests/phpunit/tests/customize/widgets.php index 5b64f85ce3392..c2ed6dbc661e2 100644 --- a/tests/phpunit/tests/customize/widgets.php +++ b/tests/phpunit/tests/customize/widgets.php @@ -397,8 +397,8 @@ public function test_get_setting_args() { foreach ( $default_args as $key => $default_value ) { $this->assertSame( $default_value, $args[ $key ] ); } - $this->assertTrue( is_callable( $args['sanitize_callback'] ), 'sanitize_callback is callable' ); - $this->asserttrue( is_callable( $args['sanitize_js_callback'] ), 'sanitize_js_callback is callable' ); + $this->assertIsCallable( $args['sanitize_callback'], 'sanitize_callback is callable' ); + $this->assertIsCallable( $args['sanitize_js_callback'], 'sanitize_js_callback is callable' ); $this->assertSame( 'WIDGET_FOO[2]', $args['uppercase_id_set_by_filter'] ); $default_args = array( @@ -411,8 +411,8 @@ public function test_get_setting_args() { foreach ( $default_args as $key => $default_value ) { $this->assertSame( $default_value, $args[ $key ] ); } - $this->assertTrue( is_callable( $args['sanitize_callback'] ), 'sanitize_callback is callable' ); - $this->asserttrue( is_callable( $args['sanitize_js_callback'] ), 'sanitize_js_callback is callable' ); + $this->assertIsCallable( $args['sanitize_callback'], 'sanitize_callback is callable' ); + $this->assertIsCallable( $args['sanitize_js_callback'], 'sanitize_js_callback is callable' ); remove_theme_support( 'customize-selective-refresh-widgets' ); $args = $this->manager->widgets->get_setting_args( 'widget_search[2]' ); @@ -443,8 +443,8 @@ public function test_get_setting_args() { foreach ( $default_args as $key => $default_value ) { $this->assertSame( $default_value, $args[ $key ] ); } - $this->assertTrue( is_callable( $args['sanitize_callback'] ), 'sanitize_callback is callable' ); - $this->asserttrue( is_callable( $args['sanitize_js_callback'] ), 'sanitize_js_callback is callable' ); + $this->assertIsCallable( $args['sanitize_callback'], 'sanitize_callback is callable' ); + $this->assertIsCallable( $args['sanitize_js_callback'], 'sanitize_js_callback is callable' ); $this->assertSame( 'SIDEBARS_WIDGETS[SIDEBAR-1]', $args['uppercase_id_set_by_filter'] ); $override_args = array( From 5176787ce4bfe4395162627c1d1c095d7b9f6415 Mon Sep 17 00:00:00 2001 From: Raul Salvat Date: Wed, 12 Aug 2026 11:09:55 -0400 Subject: [PATCH 2/2] Tests: Use `assertIsCallable()` in multisite cache tests. Replaces generic `assertTrue( is_callable() )` assertions with PHPUnit's dedicated callable assertion in the multisite cache fallback tests. See #65819. --- tests/phpunit/tests/multisite/wpCacheSwitchToBlogFallback.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/phpunit/tests/multisite/wpCacheSwitchToBlogFallback.php b/tests/phpunit/tests/multisite/wpCacheSwitchToBlogFallback.php index 35083088017b0..ffc3e1f263f6d 100644 --- a/tests/phpunit/tests/multisite/wpCacheSwitchToBlogFallback.php +++ b/tests/phpunit/tests/multisite/wpCacheSwitchToBlogFallback.php @@ -121,8 +121,8 @@ public function test_wp_cache_switch_to_blog_function_exists() { $this->assertTrue( function_exists( 'wp_cache_switch_to_blog_fallback' ), 'wp_cache_switch_to_blog_fallback() should always exist' ); // Both should be callable. - $this->assertTrue( is_callable( 'wp_cache_switch_to_blog' ) ); - $this->assertTrue( is_callable( 'wp_cache_switch_to_blog_fallback' ) ); + $this->assertIsCallable( 'wp_cache_switch_to_blog' ); + $this->assertIsCallable( 'wp_cache_switch_to_blog_fallback' ); } /**