Skip to content

[CI]: CI silently auto-fixes import ordering (and other safe fixes) instead of failing #168

Description

@krisztianfekete

Our [tool.ruff] sets fix = true, so ruff check . in CI applies safe autofixes on the fly.
For most rules this doesn't matter (they have no safe fix and still fail, which is the lint failures we all see). But for the auto-fixable ones, mainly import sorting (I) and quote/whitespace normalization, CI fixes them in its own checkout, exits 0, and the violation quietly lands on main un-fixed because nothing gets committed.

Fix: run ruff check --no-fix . in CI so those get reported instead of silently patched. Keeping fix = true for local dev is still fine.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions