From 0b71874c25b75ce3faea1ee33604f19fed78dc22 Mon Sep 17 00:00:00 2001 From: Gage Krumbach Date: Fri, 6 Nov 2026 12:52:03 -0600 Subject: [PATCH 1/2] chore: infra team owns CI and release automation The workflows, the release scripts and the upstream bump bot hold the tokens that publish packages and push branches. Simon asked for the organization's infra team to review changes to them; this makes @ai-openshell/infra the code owner of .github/, scripts/release/, scripts/retag-image.sh, scripts/branch-tip.sh and deploy/ci/upstream/. Co-Authored-By: Claude Opus 5.5 Signed-off-by: Gage Krumbach --- .github/CODEOWNERS | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+) create mode 100644 .github/CODEOWNERS diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS new file mode 100644 index 0000000..0d56d27 --- /dev/null +++ b/.github/CODEOWNERS @@ -0,0 +1,21 @@ +# OpenShell Dashboard code owners +# These users will be automatically requested for review on PRs. + +# Default owners for everything +* @Gkrumbach07 + +# Architecture decisions require explicit review +docs/adrs/ @Gkrumbach07 + +# Auth and security changes require explicit review +backend/pkg/auth/ @Gkrumbach07 +.claude/rules/security.md @Gkrumbach07 + +# CI and release automation: these hold the tokens that publish packages and +# push branches, so a change gets a security review from the organization's +# infra team. A later rule wins, so these override the default above. +/.github/ @ai-openshell/infra +/scripts/release/ @ai-openshell/infra +/scripts/retag-image.sh @ai-openshell/infra +/scripts/branch-tip.sh @ai-openshell/infra +/deploy/ci/upstream/ @ai-openshell/infra From 93c8b9d0253a64daffc4bd8d76ce9b19cb0e2cf3 Mon Sep 17 00:00:00 2001 From: Gage Krumbach Date: Tue, 17 Nov 2026 10:28:17 -0600 Subject: [PATCH 2/2] chore: the console team owns the repository by default CODEOWNERS named only Gkrumbach07, and main-integrity needs one code owner's approval, so no pull request of his could merge. The default owner is now the ai-openshell/console team (Gkrumbach07 and danreed-rh), as sdk-go uses ai-openshell/sdk, so each maintainer can approve the other's work. The ADR and auth rules named the same owner as the default and are dropped. The root CODEOWNERS goes: .github/CODEOWNERS takes precedence, so it was dead. scripts/quay-login.sh (#134) joins the files infra reviews. Co-Authored-By: Claude Opus 5.5 Signed-off-by: Gage Krumbach --- .github/CODEOWNERS | 26 ++++++++++++-------------- CODEOWNERS | 12 ------------ 2 files changed, 12 insertions(+), 26 deletions(-) delete mode 100644 CODEOWNERS diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index 0d56d27..a8f4b50 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -1,21 +1,19 @@ -# OpenShell Dashboard code owners -# These users will be automatically requested for review on PRs. +# OpenShell console code owners. GitHub requests a review from these owners, +# and the organization's main-integrity ruleset needs one code owner's approval +# to merge. Owners are teams, so a maintainer joins or leaves in the +# organization's team settings and this file does not change. -# Default owners for everything -* @Gkrumbach07 +# The console's maintainers own everything by default. The team has more than +# one member, so each can approve the other's pull requests. +* @ai-openshell/console -# Architecture decisions require explicit review -docs/adrs/ @Gkrumbach07 - -# Auth and security changes require explicit review -backend/pkg/auth/ @Gkrumbach07 -.claude/rules/security.md @Gkrumbach07 - -# CI and release automation: these hold the tokens that publish packages and -# push branches, so a change gets a security review from the organization's -# infra team. A later rule wins, so these override the default above. +# CI and release automation: these hold the credentials that publish images and +# charts and push branches, so a change gets a security review from the +# organization's infra team. A later rule wins, so these override the default +# above. /.github/ @ai-openshell/infra /scripts/release/ @ai-openshell/infra /scripts/retag-image.sh @ai-openshell/infra /scripts/branch-tip.sh @ai-openshell/infra +/scripts/quay-login.sh @ai-openshell/infra /deploy/ci/upstream/ @ai-openshell/infra diff --git a/CODEOWNERS b/CODEOWNERS deleted file mode 100644 index c21a09c..0000000 --- a/CODEOWNERS +++ /dev/null @@ -1,12 +0,0 @@ -# OpenShell Dashboard code owners -# These users will be automatically requested for review on PRs. - -# Default owners for everything -* @Gkrumbach07 - -# Architecture decisions require explicit review -docs/adrs/ @Gkrumbach07 - -# Auth and security changes require explicit review -backend/pkg/auth/ @Gkrumbach07 -.claude/rules/security.md @Gkrumbach07