From d9a22e00de9706d87a1c499bcfc1e424ba5cb0d6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ra=C3=BAl=20Cumplido?= Date: Fri, 2 Oct 2026 09:40:16 +0200 Subject: [PATCH] GH-51687: [C++] Skipt test that require threads if ARROW_ENABLE_THREADING=OFF --- cpp/src/arrow/util/async_generator_test.cc | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/cpp/src/arrow/util/async_generator_test.cc b/cpp/src/arrow/util/async_generator_test.cc index 9d965dbc4e5f..e51410b73e81 100644 --- a/cpp/src/arrow/util/async_generator_test.cc +++ b/cpp/src/arrow/util/async_generator_test.cc @@ -976,6 +976,9 @@ TEST_F(MergedGeneratorErrorHookTest, OuterErrorToWaiterNotOvertakenByLaterPull) // receives the error has completed, even when it is requested while the generator is // already completing. TEST_F(MergedGeneratorErrorHookTest, InnerErrorToWaiterNotOvertakenDuringCompletion) { +#ifndef ARROW_ENABLE_THREADING + GTEST_SKIP() << "Test requires threading support"; +#endif auto failing = Future::Make(); AsyncGenerator failing_sub = [failing]() { return failing; }; std::vector> subs = {failing_sub}; @@ -994,6 +997,9 @@ TEST_F(MergedGeneratorErrorHookTest, InnerErrorToWaiterNotOvertakenDuringComplet } TEST_F(MergedGeneratorErrorHookTest, OuterErrorToWaiterNotOvertakenDuringCompletion) { +#ifndef ARROW_ENABLE_THREADING + GTEST_SKIP() << "Test requires threading support"; +#endif auto failing = Future>::Make(); AsyncGenerator> source = [failing]() { return failing; }; MergedGenerator gen(std::move(source), 1); @@ -1011,6 +1017,9 @@ TEST_F(MergedGeneratorErrorHookTest, OuterErrorToWaiterNotOvertakenDuringComplet } TEST_F(MergedGeneratorErrorHookTest, ClaimedErrorNotOvertakenDuringCompletion) { +#ifndef ARROW_ENABLE_THREADING + GTEST_SKIP() << "Test requires threading support"; +#endif auto failing = Future::Make(); AsyncGenerator failing_sub = [failing]() { return failing; }; std::vector> subs = {MakeVectorGenerator({TestInt(1)}),