framework/db: test persist() when the savepoint can't be taken, and named savepoints

Author: Alpha162

framework/db/src/test/java/com/cloud/utils/GenericDaoBasePersistTransactionTest.java

@@ -43,6 +43,7 @@
 
 import com.cloud.utils.db.GenericDaoBase;
 import com.cloud.utils.db.TransactionLegacy;
+import com.cloud.utils.exception.CloudRuntimeException;
 
 // Kept outside com.cloud.utils.db because framework/db excludes that package's tests from the build.
 @RunWith(MockitoJUnitRunner.class)
@@ -142,6 +143,19 @@ public void persistOutsideATransactionCommitsWithoutASavepoint() throws SQLExcep
         Assert.assertFalse(txn.dbTxnStarted());
     }
 
+    @Test
+    public void persistInsideCallerTransactionLeavesItIntactWhenTheSavepointCannotBeTaken() throws SQLException {
+        Mockito.when(conn.setSavepoint()).thenThrow(new SQLException("Connection lost"));
+        txn.start();
+
+        Assert.assertThrows(CloudRuntimeException.class, () -> dao.persist(new PersistTestVO()));
+
+        Mockito.verify(conn, Mockito.never()).rollback();
+        Assert.assertTrue(txn.dbTxnStarted());
+        Assert.assertTrue(txn.commit());
+        Mockito.verify(conn).commit();
+    }
+
     @Test
     public void failedSetSavepointLeavesTheCallerTransactionIntact() throws SQLException {
         Mockito.when(conn.setSavepoint()).thenThrow(new SQLException("Connection lost"));
@@ -168,6 +182,20 @@ public void failedReleaseSavepointLeavesItAvailableForRollback() throws SQLExcep
         Mockito.verify(conn).commit();
     }
 
+    @Test
+    public void namedSavepointRollsBackOnlyItsOwnLevel() throws SQLException {
+        Mockito.when(conn.setSavepoint("persist")).thenReturn(savepoint);
+        txn.start();
+        final Savepoint sp = txn.setSavepoint("persist");
+
+        txn.rollback(sp);
+
+        Mockito.verify(conn).rollback(savepoint);
+        Mockito.verify(conn, Mockito.never()).rollback();
+        Assert.assertTrue(txn.commit());
+        Mockito.verify(conn).commit();
+    }
+
     @Entity
     @Table(name = "persist_test")
     public static class PersistTestVO {