Remove agent commands that the management server stopped sending

These commands belong to the storage model that predates the storage
subsystem introduced in 4.2. Nothing in the management server creates
or subclasses any of them any more, so the handlers in every hypervisor
resource were unreachable:

  AttachIsoCommand, BackupSnapshotCommand, CheckConsoleProxyLoadCommand,
  WatchConsoleProxyLoadCommand, CheckStorageAvailabilityCommand,
  CreateCommand, CreatePrivateTemplateFromSnapshotCommand,
  CreatePrivateTemplateFromVolumeCommand, CreateVolumeFromSnapshotCommand,
  ManageSnapshotCommand, PrimaryStorageDownloadCommand,
  RebootRouterCommand, UpgradeSnapshotCommand

Removed with them:

  - the Answer classes only they produced: AttachIsoAnswer,
    BackupSnapshotAnswer, CreateAnswer, CreateVolumeFromSnapshotAnswer,
    ManageSnapshotAnswer, CreatePrivateTemplateAnswer.
    PrimaryStorageDownloadAnswer stays, the KVM storage processor still
    uses it as a plain failure answer.
  - the XenServer wrappers and the VMware, simulator and console proxy
    handlers, the corresponding VmwareStorageManager and mock manager
    methods, and the dispatch branches that routed to them.
  - the execute(PrimaryStorageDownloadCommand) method of the
    StoragePoolResource interface and the CreateCommand entry in
    AgentAttache's list of commands refused while connecting.
  - the unit tests in core, XenServer, Hyper-V and KVM that built these
    commands.
  - the ManagedNFS storage pool type. Its only adaptor was removed
    earlier and no code has ever created a pool of that type.

Not touched: the ovm and ovm3 plugins, which are not part of the build
and still reference these classes; the Hyper-V .NET agent, which has its
own C# handlers for CreateCommand and PrimaryStorageDownloadCommand;
and log messages and configuration descriptions that merely mention the
old command names.

The vmware plugin needs the non redistributable vSphere SDK to compile,
which is not available in this build environment; its changes were
reviewed but not compiled.

Author: wido

agent/src/main/java/com/cloud/agent/resource/consoleproxy/ConsoleProxyResource.java

@@ -16,16 +16,11 @@
 // under the License.
 package com.cloud.agent.resource.consoleproxy;
 
-import java.io.BufferedReader;
 import java.io.BufferedWriter;
 import java.io.FileWriter;
 import java.io.IOException;
-import java.io.InputStream;
-import java.io.InputStreamReader;
 import java.lang.reflect.InvocationTargetException;
 import java.lang.reflect.Method;
-import java.net.URL;
-import java.net.URLConnection;
 import java.util.HashMap;
 import java.util.Map;
 import java.util.Properties;
@@ -49,10 +44,7 @@
 import com.cloud.agent.api.ReadyCommand;
 import com.cloud.agent.api.StartupCommand;
 import com.cloud.agent.api.StartupProxyCommand;
-import com.cloud.agent.api.proxy.CheckConsoleProxyLoadCommand;
-import com.cloud.agent.api.proxy.ConsoleProxyLoadAnswer;
 import com.cloud.agent.api.proxy.StartConsoleProxyAgentHttpHandlerCommand;
-import com.cloud.agent.api.proxy.WatchConsoleProxyLoadCommand;
 import com.cloud.exception.AgentControlChannelException;
 import com.cloud.host.Host;
 import com.cloud.host.Host.Type;
@@ -94,11 +86,7 @@ public class ConsoleProxyResource extends ServerResourceBase implements ServerRe
 
     @Override
     public Answer executeRequest(final Command cmd) {
-        if (cmd instanceof CheckConsoleProxyLoadCommand) {
-            return execute((CheckConsoleProxyLoadCommand)cmd);
-        } else if (cmd instanceof WatchConsoleProxyLoadCommand) {
-            return execute((WatchConsoleProxyLoadCommand)cmd);
-        } else if (cmd instanceof ReadyCommand) {
+        if (cmd instanceof ReadyCommand) {
             logger.info("Receive ReadyCommand, response with ReadyAnswer");
             return new ReadyAnswer((ReadyCommand)cmd);
         } else if (cmd instanceof CheckHealthCommand) {
@@ -142,51 +130,6 @@ private void disableRpFilter() {
         }
     }
 
-    protected Answer execute(final CheckConsoleProxyLoadCommand cmd) {
-        return executeProxyLoadScan(cmd, cmd.getProxyVmId(), cmd.getProxyVmName(), cmd.getProxyManagementIp(), cmd.getProxyCmdPort());
-    }
-
-    protected Answer execute(final WatchConsoleProxyLoadCommand cmd) {
-        return executeProxyLoadScan(cmd, cmd.getProxyVmId(), cmd.getProxyVmName(), cmd.getProxyManagementIp(), cmd.getProxyCmdPort());
-    }
-
-    private Answer executeProxyLoadScan(final Command cmd, final long proxyVmId, final String proxyVmName, final String proxyManagementIp, final int cmdPort) {
-        String result = null;
-
-        final StringBuffer sb = new StringBuffer();
-        sb.append("http://").append(proxyManagementIp).append(":" + cmdPort).append("/cmd/getstatus");
-
-        boolean success = true;
-        try {
-            final URL url = new URL(sb.toString());
-            final URLConnection conn = url.openConnection();
-
-            final InputStream is = conn.getInputStream();
-            final BufferedReader reader = new BufferedReader(new InputStreamReader(is,"UTF-8"));
-            final StringBuilder sb2 = new StringBuilder();
-            String line = null;
-            try {
-                while ((line = reader.readLine()) != null)
-                    sb2.append(line + "\n");
-                result = sb2.toString();
-            } catch (final IOException e) {
-                success = false;
-            } finally {
-                try {
-                    is.close();
-                } catch (final IOException e) {
-                    logger.warn("Exception when closing , console proxy address: {}", proxyManagementIp);
-                    success = false;
-                }
-            }
-        } catch (final IOException e) {
-            logger.warn("Unable to open console proxy command port url, console proxy address: {}", proxyManagementIp);
-            success = false;
-        }
-
-        return new ConsoleProxyLoadAnswer(cmd, proxyVmId, proxyVmName, success, result);
-    }
-
     @Override
     protected String getDefaultScriptsDir() {
         return null;

api/src/main/java/com/cloud/storage/Storage.java

@@ -181,7 +181,6 @@ public static enum StoragePoolType {
         SMB(true, false, EncryptionSupport.Unsupported),
         Gluster(true, false, EncryptionSupport.Unsupported),
         PowerFlex(true, true, EncryptionSupport.Hypervisor), // Dell EMC PowerFlex/ScaleIO (formerly VxFlexOS)
-        ManagedNFS(true, false, EncryptionSupport.Unsupported),
         Linstor(true, true, EncryptionSupport.Storage),
         DatastoreCluster(true, true, EncryptionSupport.Unsupported), // for VMware, to abstract pool of clusters
         StorPool(true, true, EncryptionSupport.Hypervisor),

api/src/test/java/com/cloud/storage/StorageTest.java

@@ -46,7 +46,6 @@ public void isSharedStoragePool() {
         Assert.assertTrue(StoragePoolType.OCFS2.isShared());
         Assert.assertTrue(StoragePoolType.SMB.isShared());
         Assert.assertTrue(StoragePoolType.Gluster.isShared());
-        Assert.assertTrue(StoragePoolType.ManagedNFS.isShared());
         Assert.assertTrue(StoragePoolType.DatastoreCluster.isShared());
         Assert.assertTrue(StoragePoolType.Linstor.isShared());
     }
@@ -70,7 +69,6 @@ public void supportsOverProvisioningTestAllStoragePoolTypes() {
         Assert.assertFalse(StoragePoolType.OCFS2.supportsOverProvisioning());
         Assert.assertFalse(StoragePoolType.SMB.supportsOverProvisioning());
         Assert.assertFalse(StoragePoolType.Gluster.supportsOverProvisioning());
-        Assert.assertFalse(StoragePoolType.ManagedNFS.supportsOverProvisioning());
         Assert.assertTrue(StoragePoolType.DatastoreCluster.supportsOverProvisioning());
         Assert.assertTrue(StoragePoolType.Linstor.supportsOverProvisioning());
     }