From 990e3f42025a2d795c0993bac7fdad927ef783c5 Mon Sep 17 00:00:00 2001 From: Sylwester Lachiewicz Date: Mon, 12 Oct 2026 14:32:45 +0000 Subject: [PATCH 1/3] Skip Spotless in the JDK 27 site build too The javadoc report forks a build that runs spotless:check, which crashes on JDK 27 like the main build (palantir/palantir-java-format#1786). --- .github/workflows/maven.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/maven.yml b/.github/workflows/maven.yml index 87aed6441d6d..9d19abaee8c7 100644 --- a/.github/workflows/maven.yml +++ b/.github/workflows/maven.yml @@ -224,7 +224,8 @@ jobs: - name: Build site with downloaded Maven shell: bash - run: mvn site -e -B -V -Preporting + # the javadoc report forks a build that runs Spotless; same JDK 27 skip as above + run: mvn site -e -B -V -Preporting ${{ matrix.java == '27' && '-Dspotless.skip=true' || '' }} - name: Upload Mimir caches uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7.0.1 From 3ac67d9193f59336bddc9214099d1bbbb48ddfff Mon Sep 17 00:00:00 2001 From: Sylwester Lachiewicz Date: Mon, 12 Oct 2026 19:22:29 +0000 Subject: [PATCH 2/3] Skip Spotless on JDK 27 through a POM profile The profile applies to local builds as well as CI, so the -Dspotless.skip arguments leave the workflow. Drop it once maven-parent ships a palantir-java-format that runs on JDK 27 (palantir/palantir-java-format#1786). --- .github/workflows/maven.yml | 9 +++------ pom.xml | 11 +++++++++++ 2 files changed, 14 insertions(+), 6 deletions(-) diff --git a/.github/workflows/maven.yml b/.github/workflows/maven.yml index 9d19abaee8c7..93e39135ec11 100644 --- a/.github/workflows/maven.yml +++ b/.github/workflows/maven.yml @@ -219,13 +219,11 @@ jobs: - name: Build with downloaded Maven shell: bash - # palantir-java-format crashes on JDK 27 (palantir/palantir-java-format#1786); drop the skip once a fixed release is in maven-parent - run: mvn verify -Papache-release -Dgpg.skip=true -e -B -V ${{ matrix.java == '27' && '-Dspotless.skip=true' || '' }} + run: mvn verify -Papache-release -Dgpg.skip=true -e -B -V - name: Build site with downloaded Maven shell: bash - # the javadoc report forks a build that runs Spotless; same JDK 27 skip as above - run: mvn site -e -B -V -Preporting ${{ matrix.java == '27' && '-Dspotless.skip=true' || '' }} + run: mvn site -e -B -V -Preporting - name: Upload Mimir caches uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7.0.1 @@ -322,8 +320,7 @@ jobs: - name: Build Maven and ITs and run them shell: bash - # palantir-java-format crashes on JDK 27 (palantir/palantir-java-format#1786); drop the skip once a fixed release is in maven-parent - run: mvn install -e -B -V -Prun-its,mimir ${{ matrix.java == '27' && '-Dspotless.skip=true' || '' }} + run: mvn install -e -B -V -Prun-its,mimir - name: Upload Mimir caches uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7.0.1 diff --git a/pom.xml b/pom.xml index fe0847b796c8..89eeec340d71 100644 --- a/pom.xml +++ b/pom.xml @@ -978,6 +978,17 @@ under the License. + + + jdk27-skip-spotless + + [27,) + + + true + + mockito From 0e7539ee595f1eeab5021338f2666d3faf81fcb3 Mon Sep 17 00:00:00 2001 From: Sylwester Lachiewicz Date: Mon, 12 Oct 2026 22:04:49 +0200 Subject: [PATCH 3/3] Activate the JDK 27 Spotless profile by property, not The model builder tests in maven-impl build the root POM in sessions without java.version, where a activation is an error. --- pom.xml | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/pom.xml b/pom.xml index 89eeec340d71..0330806b138d 100644 --- a/pom.xml +++ b/pom.xml @@ -980,10 +980,15 @@ under the License. + drop this profile once maven-parent ships a fixed release. + Activated by property, not : the model builder tests build this POM in sessions + without java.version, where a activation is an error. --> jdk27-skip-spotless - [27,) + + java.specification.version + 27 + true