From 10d9cea7fd9e3326513659e81be7f4ca361f9730 Mon Sep 17 00:00:00 2001
From: Matt Raible <matt@raibledesigns.com>
Date: Thu, 13 Aug 2026 06:40:45 -0600
Subject: [PATCH] Use double-quoted attributes in the media file links inserted
 into new entries

The "create a post from your uploaded files" flow built its image and enclosure markup with single-quoted attributes and an invalid closing </img> tag, and the resulting image did not render after publishing. The media chooser on the entry editor already inserts the same link with double quotes and a self-closing img tag, and that form works, so this flow now matches it. Reported by Greg Huber on dev@roller.
---
 .../weblogger/ui/struts2/editor/EntryAddWithMediaFile.java  | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/app/src/main/java/org/apache/roller/weblogger/ui/struts2/editor/EntryAddWithMediaFile.java b/app/src/main/java/org/apache/roller/weblogger/ui/struts2/editor/EntryAddWithMediaFile.java
index 40c67e39b5..ef5512820e 100644
--- a/app/src/main/java/org/apache/roller/weblogger/ui/struts2/editor/EntryAddWithMediaFile.java
+++ b/app/src/main/java/org/apache/roller/weblogger/ui/struts2/editor/EntryAddWithMediaFile.java
@@ -76,14 +76,14 @@ public String execute() {
 
                     if (mediaFile.isImageFile()) {
                         link = "<p>" + mediaFile.getName() + "</p>";
-                        link += "<a href='<url>'><img src='<urlt>' alt='<name>' width='<width>' height='<height>'></img></a>";
+                        link += "<a href=\"<url>\"><img src=\"<urlt>\" alt=\"<name>\" width=\"<width>\" height=\"<height>\" /></a>";
                         link = link.replace("<url>", mediaFile.getPermalink())
                                    .replace("<urlt>", mediaFile.getThumbnailURL())
                                    .replace("<name>", mediaFile.getName())
                                    .replace("<width>", ""+mediaFile.getThumbnailWidth())
                                    .replace("<height>", ""+mediaFile.getThumbnailHeight());
                     } else {
-                        link = "<a href='<url>'><name></a> (<size> bytes, <type>)";
+                        link = "<a href=\"<url>\"><name></a> (<size> bytes, <type>)";
                         link = link.replace("<url>", mediaFile.getPermalink())
                                    .replace("<name>", mediaFile.getName())
                                    .replace("<size>",""+mediaFile.getLength())
@@ -97,7 +97,7 @@ public String execute() {
                 sb.append("<p>")
                   .append(getText("mediaFileEdit.includesEnclosure"))
                   .append("<br />")
-                  .append("<a href='" + bean.getEnclosureURL() + "'>")
+                  .append("<a href=\"" + bean.getEnclosureURL() + "\">")
                   .append(bean.getEnclosureURL())
                   .append("</a></p>");
             }