From b272bc709fb3708d48faab6092eb0e3569754046 Mon Sep 17 00:00:00 2001 From: Xinyuan Lin Date: Tue, 27 Oct 2026 16:12:19 -0700 Subject: [PATCH] refactor(frontend): drop dead members in execution history --- .../workflow-execution-history.component.html | 2 +- .../workflow-execution-history.component.spec.ts | 5 ----- .../workflow-execution-history.component.ts | 3 --- 3 files changed, 1 insertion(+), 9 deletions(-) diff --git a/frontend/src/app/dashboard/component/user/user-workflow/ngbd-modal-workflow-executions/workflow-execution-history.component.html b/frontend/src/app/dashboard/component/user/user-workflow/ngbd-modal-workflow-executions/workflow-execution-history.component.html index 6ea319314c2..49152402e25 100644 --- a/frontend/src/app/dashboard/component/user/user-workflow/ngbd-modal-workflow-executions/workflow-execution-history.component.html +++ b/frontend/src/app/dashboard/component/user/user-workflow/ngbd-modal-workflow-executions/workflow-execution-history.component.html @@ -156,7 +156,7 @@ diff --git a/frontend/src/app/dashboard/component/user/user-workflow/ngbd-modal-workflow-executions/workflow-execution-history.component.spec.ts b/frontend/src/app/dashboard/component/user/user-workflow/ngbd-modal-workflow-executions/workflow-execution-history.component.spec.ts index 8fe249275d7..033312b469f 100644 --- a/frontend/src/app/dashboard/component/user/user-workflow/ngbd-modal-workflow-executions/workflow-execution-history.component.spec.ts +++ b/frontend/src/app/dashboard/component/user/user-workflow/ngbd-modal-workflow-executions/workflow-execution-history.component.spec.ts @@ -33,8 +33,6 @@ import { WorkflowRuntimeStatistics } from "../../../../type/workflow-runtime-sta import { NotificationService } from "../../../../../common/service/notification/notification.service"; import { UserService } from "../../../../../common/service/user/user.service"; import { StubUserService } from "../../../../../common/service/user/stub-user.service"; -import { OperatorMetadataService } from "../../../../../workspace/service/operator-metadata/operator-metadata.service"; -import { StubOperatorMetadataService } from "../../../../../workspace/service/operator-metadata/stub-operator-metadata.service"; import { commonTestProviders } from "../../../../../common/testing/test-utils"; import { DebugElement } from "@angular/core"; import { By } from "@angular/platform-browser"; @@ -164,9 +162,6 @@ describe("WorkflowExecutionHistoryComponent", () => { providers: [ { provide: WorkflowExecutionsService, useValue: executionsService }, { provide: NotificationService, useValue: notificationService }, - // WorkflowActionService is injected (though unused by the component logic); - // the stub metadata service lets the real one instantiate, as in menu.component.spec.ts. - { provide: OperatorMetadataService, useClass: StubOperatorMetadataService }, // UserService backs the child in each table row. { provide: UserService, useClass: StubUserService }, { provide: NZ_MODAL_DATA, useValue: options.modalData === null ? null : options.modalData ?? { wid: 1 } }, diff --git a/frontend/src/app/dashboard/component/user/user-workflow/ngbd-modal-workflow-executions/workflow-execution-history.component.ts b/frontend/src/app/dashboard/component/user/user-workflow/ngbd-modal-workflow-executions/workflow-execution-history.component.ts index e0b1f114d8d..0c3290ae708 100644 --- a/frontend/src/app/dashboard/component/user/user-workflow/ngbd-modal-workflow-executions/workflow-execution-history.component.ts +++ b/frontend/src/app/dashboard/component/user/user-workflow/ngbd-modal-workflow-executions/workflow-execution-history.component.ts @@ -23,7 +23,6 @@ import { EXECUTION_STATUS_CODE, WorkflowExecutionsEntry } from "../../../../type import { WorkflowExecutionsService } from "../../../../service/user/workflow-executions/workflow-executions.service"; import { ExecutionState } from "../../../../../workspace/types/execute-workflow.interface"; import { NotificationService } from "../../../../../common/service/notification/notification.service"; -import { WorkflowActionService } from "../../../../../workspace/service/workflow-graph/model/workflow-action.service"; import Fuse from "fuse.js"; import { ceil } from "lodash"; import { NZ_MODAL_DATA, NzModalRef, NzModalService } from "ng-zorro-antd/modal"; @@ -118,7 +117,6 @@ export class WorkflowExecutionHistoryComponent implements OnInit, AfterViewInit public processTimeBarChart = WorkflowExecutionHistoryComponent.PROCESS_TIME_BAR_CHART; public workflowExecutionsDisplayedList: WorkflowExecutionsEntry[] | undefined; public workflowExecutionsIsEditingName: number[] = []; - public currentlyHoveredExecution: WorkflowExecutionsEntry | undefined; public executionsTableHeaders: string[] = [ "", "Avatar", @@ -201,7 +199,6 @@ export class WorkflowExecutionHistoryComponent implements OnInit, AfterViewInit private workflowExecutionsService: WorkflowExecutionsService, private notificationService: NotificationService, private runtimeStatisticsModal: NzModalService, - private workflowActionService: WorkflowActionService, private route: ActivatedRoute, @Optional() @Inject(NZ_MODAL_DATA) private modalData: any ) {}