Skip to content

dev-develop changes rendering, functional tests #459

Description

@truckee

In version 2.2,

    <div class="col-md-2">
        {{ form_row(form.center) }}
    </div>

is rendered as

<div class="form-group"><label class="control-label" for="household_center">Site:</label><select     id="household_center" name="household[center]"         disabled="disabled" class="form-control"><option  value="">Select site</option><option value="819">Incline Village</option><option value="817" selected="selected">Kings Beach</option><option value="816">Tahoe City</option><option value="818">Truckee</option></select></div>

after getting rid of the deprecation notice by requiring dev-develop the same code is rendered as

<div class="form-group"><label class="control-label" for="household_center">Site:</label><select     id="household_center" name="household[center]"         disabled="disabled" class="form-control"><option  value="">Select site</option><option value="607"
                                                    >
                    Incline Village
                </option><option value="605"
                         selected="selected"                            >
                    Kings Beach
                </option><option value="604"
                                                    >
                    Tahoe City
                </option><option value="606"
                                                    >
                    Truckee
                </option></select></div>
            </div>

This causes a functional test based on $crawler->filter("#household_center option:selected")->text() to fail. It is, of course, easy to fix the test with trim($crawler->filter("#household_center option:selected")->text()). I would not, however, expect that a non-development version, should one become available without the deprecation notice, would cause tests to fail. Is there some reason why rendering must change?

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions