From c7587403211eb5a3b42b818908dfae49347d933d Mon Sep 17 00:00:00 2001 From: Andrey Parfenov Date: Wed, 19 Aug 2026 00:47:48 +0200 Subject: [PATCH 1/2] Harden apt setup in Linux analysis workflows --- .github/workflows/cppcheck.yml | 7 +++++-- .github/workflows/valgrind.yml | 23 +++++++---------------- 2 files changed, 12 insertions(+), 18 deletions(-) diff --git a/.github/workflows/cppcheck.yml b/.github/workflows/cppcheck.yml index c4357ead0..2d6ad7430 100644 --- a/.github/workflows/cppcheck.yml +++ b/.github/workflows/cppcheck.yml @@ -5,13 +5,16 @@ on: [push, pull_request] jobs: cppcheck: runs-on: ubuntu-latest + timeout-minutes: 30 steps: - - uses: actions/checkout@v2 + - uses: actions/checkout@v7 - name: Install CppCheck + timeout-minutes: 15 run: | + sudo sed -i '/azure\.archive\.ubuntu\.com/d' /etc/apt/apt-mirrors.txt sudo -H apt-get update -y - sudo -H apt-get install cppcheck + sudo -H apt-get install -y cppcheck env: DEBIAN_FRONTEND: noninteractive - name: Run Cppcheck diff --git a/.github/workflows/valgrind.yml b/.github/workflows/valgrind.yml index 9dc098137..ee4af0c22 100644 --- a/.github/workflows/valgrind.yml +++ b/.github/workflows/valgrind.yml @@ -5,6 +5,7 @@ on: [push, pull_request] jobs: RunValgrind: runs-on: ${{ matrix.os }} + timeout-minutes: 90 strategy: fail-fast: false @@ -15,15 +16,17 @@ jobs: steps: # compile and prepare env - name: Clone Repository - uses: actions/checkout@v2 + uses: actions/checkout@v7 - name: Setup CMake uses: lukka/get-cmake@v4.3.2 with: cmakeVersion: '3.21.4' - name: Install Dependencies + timeout-minutes: 20 run: | + sudo sed -i '/azure\.archive\.ubuntu\.com/d' /etc/apt/apt-mirrors.txt sudo -H apt-get update -y - sudo -H apt-get install -y libbluetooth-dev + sudo -H apt-get install -y libbluetooth-dev valgrind python3-setuptools python3-pygments env: DEBIAN_FRONTEND: noninteractive - name: Compile BrainFlow @@ -54,22 +57,10 @@ jobs: cd build cmake -DCMAKE_PREFIX_PATH=$GITHUB_WORKSPACE/installed -DCMAKE_BUILD_TYPE=Debug .. make - - name: Install Valgrind - run: | - sudo -H apt-get update -y - sudo -H apt-get install -y valgrind - env: - DEBIAN_FRONTEND: noninteractive - - name: Install Python 3.10 - uses: actions/setup-python@v5 + - name: Install Python 3.11 + uses: actions/setup-python@v7 with: python-version: '3.11' - - name: Install Python Dependencies - run: | - sudo -H apt-get update -y - sudo -H apt-get install -y python3-setuptools python3-pygments - env: - DEBIAN_FRONTEND: noninteractive - name: Install Emulator run: | cd $GITHUB_WORKSPACE/emulator From 233fe6056b68e48de650cb56fd2d3485a37a4ef8 Mon Sep 17 00:00:00 2001 From: Andrey Parfenov Date: Fri, 21 Aug 2026 04:47:49 +0200 Subject: [PATCH 2/2] Fix workflow portability and Windows shell --- .github/workflows/cppcheck.yml | 4 +++- .github/workflows/run_windows.yml | 1 + .github/workflows/valgrind.yml | 4 +++- 3 files changed, 7 insertions(+), 2 deletions(-) diff --git a/.github/workflows/cppcheck.yml b/.github/workflows/cppcheck.yml index 2d6ad7430..55916fb9c 100644 --- a/.github/workflows/cppcheck.yml +++ b/.github/workflows/cppcheck.yml @@ -12,7 +12,9 @@ jobs: - name: Install CppCheck timeout-minutes: 15 run: | - sudo sed -i '/azure\.archive\.ubuntu\.com/d' /etc/apt/apt-mirrors.txt + if [[ -f /etc/apt/apt-mirrors.txt ]]; then + sudo sed -i '/azure\.archive\.ubuntu\.com/d' /etc/apt/apt-mirrors.txt + fi sudo -H apt-get update -y sudo -H apt-get install -y cppcheck env: diff --git a/.github/workflows/run_windows.yml b/.github/workflows/run_windows.yml index 344e510cc..8e36efd4d 100644 --- a/.github/workflows/run_windows.yml +++ b/.github/workflows/run_windows.yml @@ -237,6 +237,7 @@ jobs: shell: cmd - name: PSD Welch Nyquist Overlap Python Test run: python %GITHUB_WORKSPACE%\python_package\examples\tests\psd_welch_nyquist_overlap.py + shell: cmd - name: Wavelet Buffer Size Python Test run: python %GITHUB_WORKSPACE%\python_package\examples\tests\wavelet_buffer_size.py shell: cmd diff --git a/.github/workflows/valgrind.yml b/.github/workflows/valgrind.yml index ee4af0c22..0061f83ab 100644 --- a/.github/workflows/valgrind.yml +++ b/.github/workflows/valgrind.yml @@ -24,7 +24,9 @@ jobs: - name: Install Dependencies timeout-minutes: 20 run: | - sudo sed -i '/azure\.archive\.ubuntu\.com/d' /etc/apt/apt-mirrors.txt + if [[ -f /etc/apt/apt-mirrors.txt ]]; then + sudo sed -i '/azure\.archive\.ubuntu\.com/d' /etc/apt/apt-mirrors.txt + fi sudo -H apt-get update -y sudo -H apt-get install -y libbluetooth-dev valgrind python3-setuptools python3-pygments env: