From a207e3588ac1d2e558bd31aa116149f5aee2854a Mon Sep 17 00:00:00 2001 From: Ruchit Rathi Date: Tue, 18 Aug 2026 15:13:18 +0530 Subject: [PATCH] fix: re-enable Go strings test #1653 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The Go bindings test for string handling was disabled in PR #1651 when async tests were reorganized. The test files were moved to tests/runtime/strings/disabled/ but the test infrastructure only discovers test files in the main directory. Test discovery in crates/test/src/lib.rs walks through test directories looking for language-specific test files (test.go, runner.go, etc.) in the same directory as the test.wit file. Files in subdirectories are not discovered. The Go strings test was not async-related and should not have been disabled. It was collaterally affected when PR #1651 disabled multiple tests. This change moves the Go test files back to the main strings directory where they can be discovered and executed: - tests/runtime/strings/disabled/test.go → tests/runtime/strings/test.go - tests/runtime/strings/disabled/runner.go → tests/runtime/strings/runner.go The test files are valid and require no modifications. They test: - Basic Latin UTF-16 string handling - Unicode emoji and extended characters - Empty strings - String roundtrip operations Fixes: #1653 --- tests/runtime/strings/{disabled => }/runner.go | 0 tests/runtime/strings/{disabled => }/test.go | 0 2 files changed, 0 insertions(+), 0 deletions(-) rename tests/runtime/strings/{disabled => }/runner.go (100%) rename tests/runtime/strings/{disabled => }/test.go (100%) diff --git a/tests/runtime/strings/disabled/runner.go b/tests/runtime/strings/runner.go similarity index 100% rename from tests/runtime/strings/disabled/runner.go rename to tests/runtime/strings/runner.go diff --git a/tests/runtime/strings/disabled/test.go b/tests/runtime/strings/test.go similarity index 100% rename from tests/runtime/strings/disabled/test.go rename to tests/runtime/strings/test.go