Commit a60050e
committed
[Fix] Correct wrong signatures in the type stubs
These are the signatures users see in their IDE, and four were wrong:
- `TraceAnalyzer.__init__` declared a leading `analyzer` parameter that
does not exist and made `analysis_param`/`analysis_option` required. The
real signature is `(reader, output_path, analysis_param=None,
analysis_option=None)` per `trace_analyzer.py`.
- `TraceReader.__init__` declared `**kwargs`; it actually takes
`(trace, trace_type=UNKNOWN_TRACE, reader_init_params=None)`, and
exposes `c_reader`, which callers rely on to pick the C fast path.
- `Request.op` defaulted to `ReqOp.READ`, which is not a member of the
enum. `export_cache.cpp` binds the default as `OP_NOP`.
- `CacheBase.set_cache_size` was missing.1 parent 9da1369 commit a60050e
1 file changed
Lines changed: 15 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
18 | 18 | | |
19 | 19 | | |
20 | 20 | | |
21 | | - | |
| 21 | + | |
22 | 22 | | |
23 | 23 | | |
24 | 24 | | |
| |||
151 | 151 | | |
152 | 152 | | |
153 | 153 | | |
| 154 | + | |
154 | 155 | | |
155 | 156 | | |
156 | 157 | | |
| |||
323 | 324 | | |
324 | 325 | | |
325 | 326 | | |
326 | | - | |
| 327 | + | |
| 328 | + | |
| 329 | + | |
| 330 | + | |
| 331 | + | |
| 332 | + | |
327 | 333 | | |
328 | 334 | | |
329 | 335 | | |
| |||
360 | 366 | | |
361 | 367 | | |
362 | 368 | | |
363 | | - | |
| 369 | + | |
| 370 | + | |
| 371 | + | |
| 372 | + | |
| 373 | + | |
| 374 | + | |
| 375 | + | |
364 | 376 | | |
365 | 377 | | |
366 | 378 | | |
| |||
0 commit comments