Fix

Author: web-flow

cfg/gtk.cfg

@@ -5386,11 +5386,13 @@
     <arg nr="1" direction="in">
       <not-null/>
       <not-uninit/>
+      <strz/>
       <minsize type="argvalue" arg="3"/>
     </arg>
     <arg nr="2" direction="in">
       <not-null/>
       <not-uninit/>
+      <strz/>
       <minsize type="argvalue" arg="3"/>
     </arg>
     <arg nr="3" direction="in">

cfg/posix.cfg

@@ -5608,6 +5608,7 @@ The function 'mktemp' is considered to be dangerous due to race conditions and s
     <arg nr="1" direction="in">
       <not-null/>
       <not-uninit/>
+      <strz/>
       <minsize type="argvalue" arg="2"/>
     </arg>
     <arg nr="2" direction="in">
@@ -5784,6 +5785,7 @@ The function 'mktemp' is considered to be dangerous due to race conditions and s
     <arg nr="2" direction="in">
       <not-null/>
       <not-uninit/>
+      <strz/>
       <minsize type="argvalue" arg="3"/>
     </arg>
     <arg nr="3" direction="in">

cfg/windows.cfg

@@ -4293,11 +4293,13 @@ HFONT CreateFont(
     <arg nr="1" direction="in">
       <not-null/>
       <not-uninit/>
+      <strz/>
       <minsize type="argvalue" arg="3"/>
     </arg>
     <arg nr="2" direction="in">
       <not-null/>
       <not-uninit/>
+      <strz/>
       <minsize type="argvalue" arg="3"/>
     </arg>
     <arg nr="3" direction="in">

lib/checkfunctions.cpp

@@ -102,6 +102,12 @@ void CheckFunctionsImpl::functionCalledError(const Token* tok, Severity severity
     reportError(tok, severity, prefix + "Called", msg, CWE477, Certainty::normal);
 }
 
+static bool hasMinSize(const Token* ftok, int argnr, const Settings& settings)
+{
+    const auto minsizes = settings.library.argminsizes(ftok, argnr);
+    return minsizes && !minsizes->empty();
+}
+
 //---------------------------------------------------------------------------
 // Check <valid>, <strz> and <not-bool>
 //---------------------------------------------------------------------------
@@ -137,7 +143,7 @@ void CheckFunctionsImpl::invalidFunctionUsage()
                         invalidFunctionArgError(argtok, functionToken->str(), argnr, nullptr, mSettings.library.validarg(functionToken, argnr));
                 }
                 // check <strz>
-                if (mSettings.library.isargstrz(functionToken, argnr)) {
+                if (mSettings.library.isargstrz(functionToken, argnr) && !hasMinSize(functionToken, argnr, mSettings)) {
                     if (Token::Match(argtok, "& %var% !![") && argtok->next() && argtok->next()->valueType()) {
                         const ValueType * valueType = argtok->next()->valueType();
                         const Variable * variable = argtok->next()->variable();

test/cfg/posix.c

@@ -194,6 +194,12 @@ void invalidFunctionArgStr_mbsnrtowcs(void)
     if (mbsnrtowcs (wenough, &cp, 1, 10, &s) != 1 || wcscmp (wenough, L"AEF") != 0) {}
 }
 
+int invalidFunctionArgStr_strncasecmp(const char* s)
+{
+    const char buf[3] = {'a', 'b', 'c'};
+    return strncasecmp(buf, s, 3);
+}
+
 struct tm * ignoredReturnValue_localtime(const time_t *tp)
 {
     // cppcheck-suppress [ignoredReturnValue,localtimeCalled]
@@ -719,7 +725,7 @@ size_t bufferAccessOutOfBounds_strnlen(const char *s, size_t maxlen)
     size_t len = strnlen(buf,2);
     // cppcheck-suppress bufferAccessOutOfBounds
     len+=strnlen(buf,3);
-    len+=strnlen("ab",3);
+    len+=strnlen("ab",5);
     return len;
 }