From 40206cb4e1941f50acd1a0826e487a327695b855 Mon Sep 17 00:00:00 2001 From: roxblnfk Date: Tue, 6 Oct 2026 00:21:12 +0400 Subject: [PATCH] test(STI): render the children test through a real ORM Schema The test fed the raw array straight to the renderer since cycle/orm v1 support was dropped. A real Schema keys entities by role and moves the class into `Entity`, so the expected output now matches what the renderer gets in practice. Fixes #16 Assisted-By: Claude Opus 5.5 --- .../SingleTableInheritanceTest.php | 31 +++---------------- 1 file changed, 4 insertions(+), 27 deletions(-) diff --git a/tests/Schema/Renderer/OutputSchemaRenderer/SingleTableInheritanceTest.php b/tests/Schema/Renderer/OutputSchemaRenderer/SingleTableInheritanceTest.php index 690de65..eefa874 100644 --- a/tests/Schema/Renderer/OutputSchemaRenderer/SingleTableInheritanceTest.php +++ b/tests/Schema/Renderer/OutputSchemaRenderer/SingleTableInheritanceTest.php @@ -35,15 +35,14 @@ public function testSchemaWithChildrenPropertyShouldBeRendered(): void ], ]; - // TODO need fix - //$schema = new Schema($schemaArray); - //$schemaArray = (new SchemaToArrayConverter())->convert($schema); + $schema = new Schema($schemaArray); + $schemaArray = (new SchemaToArrayConverter())->convert($schema); $renderer = new OutputSchemaRenderer(OutputSchemaRenderer::FORMAT_PLAIN_TEXT); $this->assertSame( <<<'OUTPUT' -[Cycle\Schema\Renderer\Tests\Fixture\User] :: default.user - Role: user +[user] :: default.user + Entity: Cycle\Schema\Renderer\Tests\Fixture\User Mapper: Cycle\ORM\Mapper\Mapper Primary key: id Children: Cycle\Schema\Renderer\Tests\Fixture\Guest @@ -60,28 +59,6 @@ public function testSchemaWithChildrenPropertyShouldBeRendered(): void , $renderer->render($schemaArray) ); - -// TODO related to todo above -// $this->assertSame( -// <<<'OUTPUT' -//[user] :: default.user -// Entity: Cycle\Schema\Renderer\Tests\Fixture\User -// Mapper: Cycle\ORM\Mapper\Mapper -// Primary key: id -// Children: Cycle\Schema\Renderer\Tests\Fixture\Guest -// Cycle\Schema\Renderer\Tests\Fixture\Admin -// Fields: -// (property -> db.field -> typecast) -// 0 -> id -> int -// 1 -> email -// 2 -> balance -> float -// Relations: not defined -// -// -//OUTPUT -// , -// $renderer->render($schemaArray) -// ); } public function testSchemaWithChildrenAndDiscriminatorPropertiesShouldBeRendered(): void