Skip to content

Commit 1aff279

Browse files
ai: apply changes for #505 (1 review thread)
Addresses: - #3834302149 at lib/kernel/KernelAuth.ts:288 Signed-off-by: peco-engineer-bot[bot] <peco-engineer-bot[bot]@users.noreply.github.com>
1 parent 324168c commit 1aff279

1 file changed

Lines changed: 6 additions & 3 deletions

File tree

lib/kernel/KernelAuth.ts

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -280,9 +280,12 @@ const AZURE_HOST_SUFFIXES = ['.azuredatabricks.net', '.databricks.azure.us', '.d
280280

281281
/**
282282
* True when `host` is an Azure Databricks workspace host. Normalises the input
283-
* the same way `getManager` does (trim surrounding whitespace, lowercase, strip
284-
* scheme, then drop any path and explicit `:port`) so a caller passing a bare
285-
* host, a padded string, or a full URL with a port is treated identically.
283+
* more aggressively than the Thrift driver's `getManager` (which only
284+
* lowercases and strips a leading `https://`): here we also trim surrounding
285+
* whitespace, strip either scheme, then drop any path and explicit `:port`, so
286+
* a caller passing a bare host, a padded string, or a full URL with a port is
287+
* treated identically. The suffix set matches `getManager`, so routing stays a
288+
* superset — not a byte-for-byte match — of Thrift's.
286289
*/
287290
function isAzureHost(host: string): boolean {
288291
const normalized = host

0 commit comments

Comments
 (0)