Skip to content

Commit e0888ca

Browse files
committed
Tighten kernel async handle comments
Signed-off-by: Jay Xiao <jay.xiao@databricks.com>
1 parent b690929 commit e0888ca

2 files changed

Lines changed: 5 additions & 6 deletions

File tree

tests/e2e/test_kernel_backend.py

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -462,15 +462,14 @@ def test_dml_rowcount_wiring_does_not_break_dml(conn):
462462
cur.execute(f"DROP TABLE IF EXISTS {tbl}")
463463

464464

465-
# ── Async execution: state + result come from the server (attach-by-id) ──
465+
# ── Async execution: owning handle first, attach-by-id for re-fetch/resume ──
466466

467467

468468
def test_async_execute_polls_and_fetches_result(conn):
469469
"""The full async CUJ: ``execute_async`` → poll
470-
``get_query_state`` → ``get_async_execution_result``. State comes
471-
from the server by re-attaching to the statement id; first
472-
in-process result fetch uses the retained owning handle so kernel
473-
async telemetry is finalized."""
470+
``get_query_state`` → ``get_async_execution_result``. The first
471+
in-process flow uses the retained owning handle so kernel async
472+
telemetry is finalized."""
474473
with conn.cursor() as cur:
475474
cur.execute_async("SELECT 7 AS n")
476475
cur.get_async_execution_result() # polls to terminal, fetches

tests/unit/test_kernel_client.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1125,7 +1125,7 @@ def test_kernel_error_during_result_set_construction_is_mapped():
11251125

11261126

11271127
# ---------------------------------------------------------------------------
1128-
# get_execution_result is re-callable via attach-by-id
1128+
# get_execution_result uses the owning handle once, then attach-by-id
11291129
# ---------------------------------------------------------------------------
11301130

11311131

0 commit comments

Comments
 (0)