Skip to content

parse("Maria Kowalska z domu Nowak") cannot reach the Polish maiden marker — markers do not compose the way suffixes do #434

Description

@derek73

The Polish maiden marker "z domu" (lit. "of the house [of]") is two tokens, and unlike multi-word post-nominals it cannot be reached by adding its component words to the vocabulary.

parse("Maria Kowalska z domu Nowak")
# stock                          -> given='Maria', middle='Kowalska z domu', family='Nowak'
# + 'z','domu' in maiden_markers -> given='Maria', family='Kowalska', maiden='domu Nowak'

The first marker word is consumed as the marker and the second leaks into the maiden name.

Why this is not the same as multi-word suffixes

Adjacent suffix tokens are reassembled by a run predicate (is_wholly_suffix, nameparser/_pipeline/_vocab.py:246), which is why parse("John Smith, MD PhD").suffix is 'MD PhD' and why a two-word credential is reachable as its component words. Maiden markers have no equivalent — a marker matches one word and the extraction begins immediately after it.

So the multi-token question that #291 was carrying for markers does not dissolve the way it did for suffixes. It needs its own answer: either a marker run predicate, or an explicit decision that markers stay single-word and "z domu" stays out.

Provenance

Descoped from 2.0 (#274) and folded into #291 on 2026-07-27 as "pending the multi-token matching decision". #291 is closed as working-as-designed, so this carries the question forward. Recorded in docs/design/decisions.md under Excluded (MAIDEN_MARKERS), which should point here once this is decided.

Currently noted only in nameparser/config/maiden_markers.py's docstring.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions