Skip to content

execute_async API is unclear #136

Description

@danth

Description

The parameters to execute_async are binary_path and args, implying that it works like subprocess.run and executes the command directly.

However some integration tests pass a full Bash script as the binary_path, for example:

proc = target.execute_async("echo line1; echo line2; echo line3")

The implementation is based around this.

Analysis results

No response

Solution

Either change the implementation to run the process directly, or change the API to be more clear.

Error Occurrence Rate

Reproducible

How to reproduce

No response

Supporting Information

No response

Classification

Minor

First Affected Release

not released (main)

Last Affected Release

not released (main)

Expected Fixed Release

before release (main)

Category

  • Safety Relevant
  • Security Relevant

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    Projects

    Status
    Backlog

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions