From 7037fd28cc895881ceded1d820f22872f680317f Mon Sep 17 00:00:00 2001 From: Mykhailo Chalyi Date: Wed, 27 May 2026 01:37:41 +0000 Subject: [PATCH] fix(ci): bypass pnpm `--` separator that breaks napi build flag forwarding `pnpm run build:napi -- --target X --use-napi-cross` runs `napi build --platform --release -- --target X --use-napi-cross`. The `--` separator is treated by napi-rs CLI as "forward everything after to cargo", so `--use-napi-cross` (a napi flag, not a cargo flag) got routed to cargo and crashed the v0.7.2 npm build with `error: unexpected argument '--use-napi-cross' found`. (With npm, the `--` was not inserted, so the flag stayed with napi.) Replace `pnpm run build:napi -- ...` with `pnpm exec napi build ...` which invokes napi directly, no separator inserted. --- .github/workflows/publish-js.yml | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/.github/workflows/publish-js.yml b/.github/workflows/publish-js.yml index dc2ff8048..c98055c3e 100644 --- a/.github/workflows/publish-js.yml +++ b/.github/workflows/publish-js.yml @@ -38,24 +38,24 @@ jobs: settings: - host: macos-latest target: x86_64-apple-darwin - build: pnpm run build:napi -- --target x86_64-apple-darwin && pnpm run build:cjs && pnpm run build:ts + build: pnpm exec napi build --platform --release --target x86_64-apple-darwin && pnpm run build:cjs && pnpm run build:ts - host: macos-latest target: aarch64-apple-darwin - build: pnpm run build:napi -- --target aarch64-apple-darwin && pnpm run build:cjs && pnpm run build:ts + build: pnpm exec napi build --platform --release --target aarch64-apple-darwin && pnpm run build:cjs && pnpm run build:ts - host: ubuntu-latest target: x86_64-unknown-linux-gnu - build: pnpm run build:napi -- --target x86_64-unknown-linux-gnu --use-napi-cross && pnpm run build:cjs && pnpm run build:ts + build: pnpm exec napi build --platform --release --target x86_64-unknown-linux-gnu --use-napi-cross && pnpm run build:cjs && pnpm run build:ts - host: ubuntu-24.04-arm target: aarch64-unknown-linux-gnu - build: pnpm run build:napi -- --target aarch64-unknown-linux-gnu && pnpm run build:cjs && pnpm run build:ts + build: pnpm exec napi build --platform --release --target aarch64-unknown-linux-gnu && pnpm run build:cjs && pnpm run build:ts - host: windows-latest target: x86_64-pc-windows-msvc - build: pnpm run build:napi -- --target x86_64-pc-windows-msvc && pnpm run build:cjs && pnpm run build:ts + build: pnpm exec napi build --platform --release --target x86_64-pc-windows-msvc && pnpm run build:cjs && pnpm run build:ts # TODO: WASM disabled — tokio "full" features (from bashkit core) are # unsupported on wasm32. Needs architectural fix to gate tokio features. # - host: ubuntu-latest # target: wasm32-wasip1-threads - # build: pnpm run build:napi -- --target wasm32-wasip1-threads && pnpm run build:cjs && pnpm run build:ts + # build: pnpm exec napi build --platform --release --target wasm32-wasip1-threads && pnpm run build:cjs && pnpm run build:ts steps: - uses: actions/checkout@v6