Skip to content

Commit 2364de0

Browse files
authored
dataconnect.py: update "X-Client-Version" header value to match the Node/Admin/{version} convention (#975)
1 parent bcb713f commit 2364de0

2 files changed

Lines changed: 2 additions & 2 deletions

File tree

firebase_admin/dataconnect.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -461,7 +461,7 @@ def _get_headers(self) -> Dict[str, str]:
461461
return {
462462
"X-Firebase-Client": f"fire-admin-python/{firebase_admin.__version__}",
463463
"x-goog-api-client": _utils.get_metrics_header(),
464-
"X-Client-Version": f"python/{firebase_admin.__version__}",
464+
"X-Client-Version": f"Python/Admin/{firebase_admin.__version__}",
465465
"X-Firebase-Sqlconnect-Affinity": (
466466
f"{self._project_id}{self._connector_config.service_id}"
467467
),

tests/test_data_connect.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -702,7 +702,7 @@ def test_get_headers(self):
702702
assert isinstance(headers, dict)
703703
assert headers.get("X-Firebase-Client") == f"fire-admin-python/{firebase_admin.__version__}"
704704
assert headers.get("x-goog-api-client") == _utils.get_metrics_header()
705-
assert headers.get("X-Client-Version") == f"python/{firebase_admin.__version__}"
705+
assert headers.get("X-Client-Version") == f"Python/Admin/{firebase_admin.__version__}"
706706
assert headers.get("X-Firebase-Sqlconnect-Affinity") == "test-projectstarterproject"
707707

708708

0 commit comments

Comments
 (0)