test(cli): cover the concurrent-incidents section of incident-summary.sh

The fake fduty now answers `--json` calls with a fixed start_time so the
seventh section runs: assert the eight invocations, the exact ±15 min
window passed to `incident list`, and that the other reads still use
their compact defaults. A second case drops start_time and checks the
section prints its SKIPPED marker with the manual command instead.

Author: ysyneu

internal/cli/incident_summary_script_test.go

@@ -9,7 +9,11 @@ import (
 	"testing"
 )
 
-func TestIncidentSummaryScriptCompactOutput(t *testing.T) {
+// runIncidentSummaryScript runs skills/flashduty/scripts/incident-summary.sh against a fake
+// fduty that logs every invocation. detailJSON is what the fake prints for `--json` calls; every
+// other call prints a one-line placeholder.
+func runIncidentSummaryScript(t *testing.T, detailJSON string) (output string, calls []string) {
+	t.Helper()
 	if runtime.GOOS == "windows" {
 		t.Skip("Bash fixture is unavailable on Windows")
 	}
@@ -19,31 +23,67 @@ func TestIncidentSummaryScriptCompactOutput(t *testing.T) {
 		t.Fatalf("resolve repository root: %v", err)
 	}
 	script := filepath.Join(root, "skills", "flashduty", "scripts", "incident-summary.sh")
-	log := filepath.Join(t.TempDir(), "fduty.log")
-	bin := filepath.Join(t.TempDir(), "fduty")
-	if err := os.WriteFile(bin, []byte("#!/usr/bin/env bash\nprintf '%s\\n' \"$*\" >> \"$FDUTY_LOG\"\nprintf 'compact result\\n'\n"), 0o755); err != nil {
+	dir := t.TempDir()
+	log := filepath.Join(dir, "fduty.log")
+	bin := filepath.Join(dir, "fduty")
+	fake := "#!/usr/bin/env bash\n" +
+		"printf '%s\\n' \"$*\" >> \"$FDUTY_LOG\"\n" +
+		"case \" $* \" in\n" +
+		"  *' --json '*) printf '%s\\n' \"$FDUTY_DETAIL_JSON\" ;;\n" +
+		"  *) printf 'compact result\\n' ;;\n" +
+		"esac\n"
+	if err := os.WriteFile(bin, []byte(fake), 0o755); err != nil {
 		t.Fatalf("write fake fduty: %v", err)
 	}
 	t.Setenv("FDUTY_LOG", log)
+	t.Setenv("FDUTY_DETAIL_JSON", detailJSON)
 	t.Setenv("PATH", filepath.Dir(bin)+string(os.PathListSeparator)+os.Getenv("PATH"))
 
-	output, err := exec.Command("bash", script, "inc-1").CombinedOutput()
+	out, err := exec.Command("bash", script, "inc-1").CombinedOutput()
 	if err != nil {
-		t.Fatalf("run incident summary: %v\n%s", err, output)
+		t.Fatalf("run incident summary: %v\n%s", err, out)
 	}
 	invocations, err := os.ReadFile(log)
 	if err != nil {
 		t.Fatalf("read fake fduty log: %v", err)
 	}
-	lines := strings.FieldsFunc(strings.TrimSpace(string(invocations)), func(r rune) bool { return r == '\n' })
-	if len(lines) != 6 {
-		t.Fatalf("fduty calls = %d, want 6:\n%s", len(lines), invocations)
+	calls = strings.FieldsFunc(strings.TrimSpace(string(invocations)), func(r rune) bool { return r == '\n' })
+	return string(out), calls
+}
+
+func TestIncidentSummaryScriptCompactOutput(t *testing.T) {
+	// 2026-01-01T00:00:00Z = 1767225600; the concurrent-incidents window is ±15 min around it.
+	_, calls := runIncidentSummaryScript(t, `{"incident_id":"inc-1","start_time":"2026-01-01T00:00:00Z"}`)
+	if len(calls) != 8 {
+		t.Fatalf("fduty calls = %d, want 8:\n%s", len(calls), strings.Join(calls, "\n"))
 	}
 	wantDetail := "incident detail inc-1 --fields incident_id,title,incident_severity,progress,ai_summary,root_cause,resolution,alert_cnt,start_time,channel_id --output-format toon"
-	if lines[0] != wantDetail {
-		t.Fatalf("detail call = %q, want compact projection %q", lines[0], wantDetail)
+	if calls[0] != wantDetail {
+		t.Fatalf("detail call = %q, want compact projection %q", calls[0], wantDetail)
+	}
+	if strings.Contains(strings.Join(calls[1:6], "\n"), "--output-format toon") {
+		t.Fatalf("non-detail reads force raw toon instead of their compact defaults:\n%s", strings.Join(calls, "\n"))
+	}
+	if calls[6] != "incident detail inc-1 --json" {
+		t.Fatalf("start_time probe = %q, want %q", calls[6], "incident detail inc-1 --json")
+	}
+	// ⑦ is a projected read like ①: explicit --fields keeps full titles and the num/channel_id
+	// columns the card tells the agent to reason from, so toon is the compact form here.
+	wantConcurrent := "incident list --since 1767224700 --until 1767226500 --limit 50 --fields incident_id,num,title,incident_severity,progress,start_time,channel_id --output-format toon"
+	if calls[7] != wantConcurrent {
+		t.Fatalf("concurrent-incidents call = %q, want %q", calls[7], wantConcurrent)
+	}
+}
+
+func TestIncidentSummaryScriptSkipsConcurrentWithoutStartTime(t *testing.T) {
+	output, calls := runIncidentSummaryScript(t, `{"incident_id":"inc-1"}`)
+	if len(calls) != 7 {
+		t.Fatalf("fduty calls = %d, want 7 (six reads + the start_time probe, no list):\n%s", len(calls), strings.Join(calls, "\n"))
+	}
+	if !strings.Contains(output, "⑦ concurrent incidents: SKIPPED") {
+		t.Fatalf("output lacks the SKIPPED marker for ⑦:\n%s", output)
 	}
-	if strings.Contains(strings.Join(lines[1:], "\n"), "--output-format toon") {
-		t.Fatalf("non-detail reads force raw toon instead of their compact defaults:\n%s", invocations)
+	if !strings.Contains(output, "fduty incident list --since <start-15m> --until <start+15m>") {
+		t.Fatalf("SKIPPED marker lacks the manual command:\n%s", output)
 	}
 }