fix(cli): account for the page offset in the structured truncation note

The note fired whenever total > count, which misjudges the last page:
--limit 20 --page 2 against a total of 40 printed "use --page for the
rest" even though page 2 is the end. PrintList now takes the page size
and computes hasMore as (page-1)*limit+count < total, so the note only
appears when rows actually remain beyond the current page.

Author: ysyneu

internal/cli/alert.go

@@ -93,7 +93,7 @@ func newAlertListCmd() *cobra.Command {
 					if err != nil {
 						return err
 					}
-					return ctx.PrintList(proj, nil, len(result.Items), page, int(result.Total))
+					return ctx.PrintList(proj, nil, len(result.Items), page, limit, int(result.Total))
 				}
 
 				cols := []output.Column{
@@ -106,7 +106,7 @@ func newAlertListCmd() *cobra.Command {
 					{Header: "STARTED", Field: func(v any) string { return output.FormatTime(v.(flashduty.AlertItem).StartTime) }},
 				}
 
-				return ctx.PrintList(result.Items, cols, len(result.Items), page, int(result.Total))
+				return ctx.PrintList(result.Items, cols, len(result.Items), page, limit, int(result.Total))
 			})
 		},
 	}

internal/cli/alert_event.go

@@ -102,10 +102,10 @@ func newAlertEventListCmd() *cobra.Command {
 						return err
 					}
 					noteProjectionShortening(cmd.ErrOrStderr(), note)
-					return ctx.PrintList(proj, nil, len(result.Items), page, int(result.Total))
+					return ctx.PrintList(proj, nil, len(result.Items), page, limit, int(result.Total))
 				}
 
-				return ctx.PrintList(result.Items, cols, len(result.Items), page, int(result.Total))
+				return ctx.PrintList(result.Items, cols, len(result.Items), page, limit, int(result.Total))
 			})
 		},
 	}

internal/cli/audit.go

@@ -96,7 +96,7 @@ func newAuditSearchCmd() *cobra.Command {
 					}},
 				}
 
-				return ctx.PrintList(result.Docs, cols, len(result.Docs), page, int(result.Total))
+				return ctx.PrintList(result.Docs, cols, len(result.Docs), page, limit, int(result.Total))
 			})
 		},
 	}

internal/cli/change.go

@@ -86,7 +86,7 @@ func newChangeListCmd() *cobra.Command {
 					{Header: "TIME", Field: func(v any) string { return output.FormatTime(v.(flashduty.ChangeItem).StartTime) }},
 				}
 
-				return ctx.PrintList(result.Items, cols, len(result.Items), page, int(result.Total))
+				return ctx.PrintList(result.Items, cols, len(result.Items), page, limit, int(result.Total))
 			})
 		},
 	}

internal/cli/command.go

@@ -49,15 +49,17 @@ func runCommand(cmd *cobra.Command, args []string, fn func(ctx *RunContext) erro
 
 // PrintList prints items as a table and appends a "Showing N results (page P, total T)." footer.
 // In structured mode the footer is suppressed to keep stdout byte-pure for
-// jq/toon pipelines, so a page that doesn't cover the total is announced on
+// jq/toon pipelines, so a page with more rows beyond it is announced on
 // stderr instead — without it a consumer sees a partial page
-// (e.g. the default --limit 20 of a far larger total) as the whole set.
-func (ctx *RunContext) PrintList(items any, cols []output.Column, count, page, total int) error {
+// (e.g. the default --limit 20 of a far larger total) as the whole set. The
+// judgment accounts for the page offset: on the last page
+// ((page-1)*limit+count reaches total) there is no rest, so no note.
+func (ctx *RunContext) PrintList(items any, cols []output.Column, count, page, limit, total int) error {
 	if err := ctx.Printer.Print(items, cols); err != nil {
 		return err
 	}
 	if ctx.Structured() {
-		if total > count {
+		if (page-1)*limit+count < total {
 			_, _ = fmt.Fprintf(ctx.Cmd.ErrOrStderr(), "note: showing %d of %d total results (page %d); raise --limit or use --page for the rest\n", count, total, page)
 		}
 		return nil

internal/cli/command_test.go

@@ -1657,6 +1657,42 @@ func TestCommandAlertListStructuredAnnouncesTruncation(t *testing.T) {
 			t.Errorf("table mode already footers the count; no stderr note wanted, got:\n%s", stderrText)
 		}
 	})
+
+	// The truncation judgment must account for the page offset: page 2 of a
+	// total 40 at --limit 20 IS the last page — there is no rest, so no note.
+	fullPage := make([]any, 20)
+	for i := range fullPage {
+		fullPage[i] = alertRow()
+	}
+	lastPage := map[string]any{"items": fullPage, "total": 40}
+
+	t.Run("json last page prints no note", func(t *testing.T) {
+		saveAndResetGlobals(t)
+		stub := newGFStub(t)
+		stub.data = lastPage
+
+		_, stderrText, err := execCommandSplit("alert", "list", "--limit", "20", "--page", "2", "--output-format", "json")
+		if err != nil {
+			t.Fatalf("execCommandSplit: %v", err)
+		}
+		if strings.Contains(stderrText, "note: showing") {
+			t.Errorf("the last page has no rest to page for; no note wanted, got:\n%s", stderrText)
+		}
+	})
+
+	t.Run("json first page of same total still notes", func(t *testing.T) {
+		saveAndResetGlobals(t)
+		stub := newGFStub(t)
+		stub.data = lastPage
+
+		_, stderrText, err := execCommandSplit("alert", "list", "--limit", "20", "--page", "1", "--output-format", "json")
+		if err != nil {
+			t.Fatalf("execCommandSplit: %v", err)
+		}
+		if !strings.Contains(stderrText, "note: showing 20 of 40 total results (page 1)") {
+			t.Errorf("page 1 with a page 2 beyond it should announce itself on stderr, got:\n%s", stderrText)
+		}
+	})
 }
 
 // ---------------------------------------------------------------------------

internal/cli/incident.go

@@ -142,10 +142,10 @@ func newIncidentListCmd() *cobra.Command {
 						return err
 					}
 					noteProjectionShortening(cmd.ErrOrStderr(), note)
-					return ctx.PrintList(proj, nil, len(result.Items), page, int(result.Total))
+					return ctx.PrintList(proj, nil, len(result.Items), page, limit, int(result.Total))
 				}
 
-				return ctx.PrintList(result.Items, incidentColumns(), len(result.Items), page, int(result.Total))
+				return ctx.PrintList(result.Items, incidentColumns(), len(result.Items), page, limit, int(result.Total))
 			})
 		},
 	}

internal/cli/insight.go

@@ -131,7 +131,7 @@ func newInsightIncidentsCmd() *cobra.Command {
 					}},
 				}
 
-				return ctx.PrintList(result.Items, cols, len(result.Items), page, int(result.Total))
+				return ctx.PrintList(result.Items, cols, len(result.Items), page, limit, int(result.Total))
 			})
 		},
 	}