pmatch swallows exceptions

[cgvalayev]

Example:

$x = m\pmatch([
  '["test"]' => function () {
    return $this->foo();
  }
], ["test"]);

If $this->foo() throws then $x will be assigned to an instance of Closure. Expected to bubble up the exception.

[krtek4]

Hi,

The behavior was introduced by this commit e1043e0

Not really sure why @ace411 needed that.

As I am not using the library anymore, I'll maybe let him explain first why the change and then we can discuss this further.

Best,

[cgvalayev]

Thanks @krtek4, curious how come you are not using it anymore?

[krtek4]

Not doing work on PHP anymore :)

[cgvalayev]

Hey @krtek4 @ace411 any chance this could be reverted, it will take time to migrate from PHP so for now we really would love to use pattern matching but we can't be cause of this. This makes troubleshooting extremely difficult...

[krtek4]

As I said, not doing PHP anymore and I don't have any machine with a PHP setup to do the change.

If you submit à PR, I gladly merge it and then @ace411 can chime in if needed.

[ace411]

Hello. So sorry I'm late to the party. I've been really busy recently. I'll look into this.

[cgvalayev]

bumping this up

[Parables]

Any updates on this issue?