Merge remote-tracking branch 'origin/michaelrfairhurst/package-undefined-behavior' into michaelrfairhurst/package-undefined-behavior-mismatched-list-delete

Author: MichaelRFairhurst

c/cert/src/rules/INT32-C/SignedIntegerOverflow.ql

@@ -19,24 +19,10 @@
 
 import cpp
 import codingstandards.c.cert
-import codingstandards.cpp.Overflow
-import semmle.code.cpp.controlflow.Guards
-import semmle.code.cpp.valuenumbering.GlobalValueNumbering
+import codingstandards.cpp.rules.signedintegeroverflowshared.SignedIntegerOverflowShared
 
-from InterestingOverflowingOperation op
-where
-  not isExcluded(op, IntegerOverflowPackage::signedIntegerOverflowQuery()) and
-  (
-    // An operation that returns a signed integer type
-    op.getType().getUnderlyingType().(IntegralType).isSigned()
-    or
-    // The divide or rem expression on a signed integer
-    op.(DivOrRemOperation).getDividend().getType().getUnderlyingType().(IntegralType).isSigned()
-  ) and
-  // Not checked before the operation
-  not op.hasValidPreCheck() and
-  // Covered by INT34-C
-  not op instanceof LShiftExpr
-select op,
-  "Operation " + op.getOperator() + " of type " + op.getType().getUnderlyingType() +
-    " may overflow or underflow."
+module SignedIntegerOverflowConfig implements SignedIntegerOverflowSharedConfigSig {
+  Query getQuery() { result = IntegerOverflowPackage::signedIntegerOverflowQuery() }
+}
+
+import SignedIntegerOverflowShared<SignedIntegerOverflowConfig>

c/cert/test/rules/INT32-C/SignedIntegerOverflow.qlref

@@ -0,0 +1 @@
+c/common/test/rules/signedintegeroverflowshared/SignedIntegerOverflowShared.ql

c/cert/test/rules/INT32-C/SignedIntegerOverflow.testref

@@ -21,4 +21,4 @@
 | test.c:147:5:147:12 | ... %= ... | Operation %= of type signed int may overflow or underflow. |
 | test.c:161:3:161:5 | - ... | Operation - of type signed int may overflow or underflow. |
 | test.c:173:3:173:6 | ... ++ | Operation ++ of type signed int may overflow or underflow. |
-| test.c:189:3:189:6 | ... -- | Operation -- of type signed int may overflow or underflow. |
+| test.c:189:3:189:6 | ... -- | Operation -- of type signed int may overflow or underflow. |

…s/INT32-C/SignedIntegerOverflow.expected …red/SignedIntegerOverflowShared.expectedc/cert/test/rules/INT32-C/SignedIntegerOverflow.expected renamed to c/common/test/rules/signedintegeroverflowshared/SignedIntegerOverflowShared.expected c/cert/test/rules/INT32-C/SignedIntegerOverflow.expected renamed to c/common/test/rules/signedintegeroverflowshared/SignedIntegerOverflowShared.expected

@@ -0,0 +1,8 @@
+// GENERATED FILE - DO NOT MODIFY
+import codingstandards.cpp.rules.signedintegeroverflowshared.SignedIntegerOverflowShared
+
+module TestFileConfig implements SignedIntegerOverflowSharedConfigSig {
+  Query getQuery() { result instanceof TestQuery }
+}
+
+import SignedIntegerOverflowShared<TestFileConfig>

c/common/test/rules/signedintegeroverflowshared/SignedIntegerOverflowShared.ql

@@ -0,0 +1,2 @@
+ - `INT32-C` - `SignedIntegerOverflow.ql`:
+   - Refactored query logic into a shared library (`SignedIntegerOverflowShared.qll`) to enable reuse by MISRA C++ `RULE-4-1-3`. The query logic is unchanged and no visible changes to results or performance are expected.

c/cert/test/rules/INT32-C/test.c …rules/signedintegeroverflowshared/test.cc/cert/test/rules/INT32-C/test.c renamed to c/common/test/rules/signedintegeroverflowshared/test.c c/cert/test/rules/INT32-C/test.c renamed to c/common/test/rules/signedintegeroverflowshared/test.c

@@ -0,0 +1,2 @@
+ - `INT50-CPP` - `DoNotCastToAnOutOfRangeEnumerationValue.ql`:
+   - Refactored query logic into a shared library (`DoNotCastToAnOutOfRangeEnumerationValueShared.qll`) to enable reuse by MISRA C++ `RULE-4-1-3`. The query logic is unchanged and no visible changes to results or performance are expected.

change_notes/2026-03-13-share-signed-integer-overflow-query.md

@@ -18,44 +18,12 @@
 
 import cpp
 import codingstandards.cpp.cert
-import codingstandards.cpp.Enums
-import semmle.code.cpp.rangeanalysis.SimpleRangeAnalysis
-import codingstandards.cpp.SimpleRangeAnalysisCustomizations
+import codingstandards.cpp.rules.donotcasttoanoutofrangeenumerationvalueshared.DoNotCastToAnOutOfRangeEnumerationValueShared
 
-from Cast c, Enum e, string description
-where
-  not isExcluded(c, TypeRangesPackage::doNotCastToAnOutOfRangeEnumerationValueQuery()) and
-  // Conversion from an integral type to an enum type
-  c.getExpr().getType().getUnspecifiedType() instanceof IntegralType and
-  c.getType().getUnspecifiedType() = e and
-  not (
-    // The deduced bound for the expression is within the type range for the explicit type
-    upperBound(c.getExpr()) <= Enums::getValueRangeUpperBound(e) and
-    lowerBound(c.getExpr()) >= Enums::getValueRangeLowerBound(e)
-  ) and
-  // Not a compile time constant with the same value as an existing enum constant
-  not exists(float enumConstantValue |
-    enumConstantValue = Enums::getEnumConstantValue(e.getAnEnumConstant())
-  |
-    // Expression is a constant
-    c.getExpr().getValue().toFloat() = enumConstantValue
-    or
-    // Range analysis has precise bounds
-    enumConstantValue = upperBound(c.getExpr()) and
-    enumConstantValue = lowerBound(c.getExpr())
-  ) and
-  (
-    if exists(upperBound(c.getExpr()))
-    then
-      description =
-        "Cast to enum $@ with value range " + Enums::getValueRangeLowerBound(e) + "..." +
-          Enums::getValueRangeUpperBound(e) + " from expression with wider value range " +
-          lowerBound(c.getExpr()) + "..." + upperBound(c.getExpr()) + " in function " +
-          c.getEnclosingFunction().getName() + "."
-    else
-      description =
-        "Cast to enum $@ with value range " + Enums::getValueRangeLowerBound(e) + "..." +
-          Enums::getValueRangeUpperBound(e) +
-          " from expression with a potentially wider value range."
-  )
-select c, description, e, e.getName()
+module DoNotCastToAnOutOfRangeEnumerationValueConfig implements
+  DoNotCastToAnOutOfRangeEnumerationValueSharedConfigSig
+{
+  Query getQuery() { result = TypeRangesPackage::doNotCastToAnOutOfRangeEnumerationValueQuery() }
+}
+
+import DoNotCastToAnOutOfRangeEnumerationValueShared<DoNotCastToAnOutOfRangeEnumerationValueConfig>