Skip to content

[deep-report] Unify CloseOlderKey/CloseOlder* config fields into a CloseOlderConfig embed #54230

Description

@github-actions

Description

CloseOlder<Entity> *string + CloseOlderKey string are independently redeclared in create_issue.go, create_discussion.go, and create_pull_request.go (verified live 2026-08-20). This is distinct from — and not addressed by — prior closed issues #53500/#50938/#47868, which consolidated the handler/adapter logic in close_entity_helpers.go; the config struct fields themselves were never unified, and safe_outputs_handler_registry.go still reads c.CloseOlderKey separately from each of the 3 config types.

Expected Impact

A CloseOlderConfig{Enabled *string, Key string} embeddable type (mirroring the CloseEntityConfig alias pattern already used correctly in close_entity_helpers.go) gives one source of truth for the dedup-key field across all 3 entity types.

Suggested Agent

Existing Go engineering / code-quality refactor agent.

Estimated Effort

Quick (1-2 hours).

Data Source

DeepReport analysis, 2026-08-20 ~12:30Z cycle, sourced from discussion #54213 (Typist - Go Type Consistency Analysis), Cluster 4.

Generated by 🔬 Deep Report · agent · 153.5 AIC · ⌖ 12.9 AIC · ⊞ 11.9K ·

  • expires on Aug 22, 2026, 4:31 AM UTC-08:00

Metadata

Metadata

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions