Skip to content

Commit 18666f4

Browse files
authored
Merge pull request #4619 from github/josefs/bump-min-vscode-version
Bump minimum VS Code version to 1.101.0
2 parents 65d124b + 2e38d79 commit 18666f4

5 files changed

Lines changed: 13 additions & 12 deletions

File tree

‎extensions/ql-vscode/CHANGELOG.md‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
- After an extension-managed CodeQL CLI update, the notification now offers to open the CLI release notes instead of the extension log. [#1095](https://github.com/github/vscode-codeql/issues/1095)
66
- Remove support for CodeQL CLI versions older than 2.24.3. [#4573](https://github.com/github/vscode-codeql/pull/4573)
77
- Add support to the model editor for saving and loading JSON data extensions. [#4576](https://github.com/github/vscode-codeql/pull/4576)
8+
- Increase the required version of VS Code to 1.101.0. [#4619](https://github.com/github/vscode-codeql/pull/4619)
89

910
## 1.17.8 - 17 July 2026
1011

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
{
2-
"chromiumVersion": "122",
3-
"electronVersion": "29.4.0"
2+
"chromiumVersion": "134",
3+
"electronVersion": "35.5.1"
44
}

‎extensions/ql-vscode/package-lock.json‎

Lines changed: 5 additions & 5 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎extensions/ql-vscode/package.json‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
"url": "https://github.com/github/vscode-codeql"
1414
},
1515
"engines": {
16-
"vscode": "^1.90.0",
16+
"vscode": "^1.101.0",
1717
"node": "^22.21.1",
1818
"npm": ">=8.3.0"
1919
},
@@ -2137,7 +2137,7 @@
21372137
"@types/semver": "^7.7.1",
21382138
"@types/tar-stream": "^3.1.4",
21392139
"@types/tmp": "^0.2.6",
2140-
"@types/vscode": "1.90.0",
2140+
"@types/vscode": "1.101.0",
21412141
"@types/yauzl": "^3.4.0",
21422142
"@typescript-eslint/parser": "^8.71.0",
21432143
"@vscode/test-electron": "^3.1.0",

‎extensions/ql-vscode/src/extension.ts‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -315,12 +315,12 @@ const shouldUpdateOnNextActivationKey = "shouldUpdateOnNextActivation";
315315

316316
const codeQlVersionRange = DEFAULT_DISTRIBUTION_VERSION_RANGE;
317317

318-
// This is the minimum version of vscode that we _want_ to support. We want to update to Node 20, but that
319-
// requires 1.90 or later. If we change the minimum version in the package.json, then anyone on an older version of vscode will
318+
// This is the minimum version of vscode that we _want_ to support. We want to update to Node 22, but that
319+
// requires 1.101 or later. If we change the minimum version in the package.json, then anyone on an older version of vscode will
320320
// silently be unable to upgrade. So, the solution is to first bump the minimum version here and release. Then
321321
// bump the version in the package.json and release again. This way, anyone on an older version of vscode will get a warning
322322
// before silently being refused to upgrade.
323-
const MIN_VERSION = "1.90.0";
323+
const MIN_VERSION = "1.101.0";
324324

325325
function sendConfigTelemetryData() {
326326
const config: Record<string, string> = {};

0 commit comments

Comments
 (0)