From 84f6e81a340563909866fa53fe23ce0d9484e52f Mon Sep 17 00:00:00 2001 From: Daniel Cavalcante Date: Fri, 21 Aug 2026 12:38:25 -0300 Subject: [PATCH] fix(inspect): remove duplicate close hint --- src/popups/inspect_commit.rs | 15 +++++++++------ src/strings.rs | 10 ++++++++++ 2 files changed, 19 insertions(+), 6 deletions(-) diff --git a/src/popups/inspect_commit.rs b/src/popups/inspect_commit.rs index 4acfe88e90..9d0d46b4b3 100644 --- a/src/popups/inspect_commit.rs +++ b/src/popups/inspect_commit.rs @@ -112,7 +112,7 @@ impl Component for InspectCommitPopup { CommandInfo::new( strings::commands::close_popup(&self.key_config), true, - true, + !self.diff.focused() || force_all, ) .order(1), ); @@ -123,11 +123,14 @@ impl Component for InspectCommitPopup { !self.diff.focused() || force_all, )); - out.push(CommandInfo::new( - strings::commands::close_popup(&self.key_config), - true, - self.diff.focused() || force_all, - )); + out.push( + CommandInfo::new( + strings::commands::back_popup(&self.key_config), + true, + self.diff.focused() || force_all, + ) + .order(1), + ); out.push(CommandInfo::new( strings::commands::inspect_file_tree( diff --git a/src/strings.rs b/src/strings.rs index 93496cd2ca..f132af5744 100644 --- a/src/strings.rs +++ b/src/strings.rs @@ -864,6 +864,16 @@ pub mod commands { CMD_GROUP_GENERAL, ) } + pub fn back_popup(key_config: &SharedKeyConfig) -> CommandText { + CommandText::new( + format!( + "Back [{}]", + key_config.get_hint(key_config.keys.exit_popup), + ), + "return to previous view", + CMD_GROUP_GENERAL, + ) + } pub fn scroll_popup(key_config: &SharedKeyConfig) -> CommandText { CommandText::new( format!(